Re: [Jsynthlib-devel] synth driver interface change proposal

[Hiroo H. <hir...@co...>]

Hi Rib,

I have a question for you.

When you checked in the bunch of changes for the initial support for XML
at the end of August, you removed the following constructor from
PatchNameWidget class.

    /**
     * Creates a new <code>PatchNameWidget</code> instance.
     * @param label a label text.
     * @param patch a <code>Patch</code>, which is edited.
     */
    public PatchNameWidget(String label, IPatch patch) {
        this(label, patch, ((ISingleDriver) patch.getDriver()).getPatchNameSize());
    }

and replace many lines something like;

    new PatchNameWidget("Program Name ", patch)
to
    new PatchNameWidget("Program Name ", patch, ((Driver) patch.getDriver()).getPatchNameSize()),

Most of the change for the synth drivers on the commit were for this
change.  (More than 40 lines.)


Why you did make the change?
Why you did not keep the constructor and dir not define
IDriver.getPatchNameSize() (or IPatch.getNameSize())?


I'm thinking to revert the change.  But, of course, I cannot do that
without confirming your intention.

Thanks.
-- 
Hiroo Hayashi