Re: [Jsynthlib-devel] Interfaces

[Hiroo H. <hir...@co...>]

I've made calculateChecksum(Patch, int, int, int) static.  It's in head.

Thanks.

On Mon, 16 Aug 2004 07:18:20 -0500
Hiroo Hayashi <hir...@co...> wrote:

Hiroo> Rib,
Hiroo>=20
Hiroo> My baseline is that calculateChecksum(Patch, int, int, int) should b=
e
Hiroo> static.
Hiroo>=20
Hiroo> My next question would be why Converter still extended the Driver:-)
Hiroo> The checksumming is the only reason?  Or did you see any other probl=
ems?
Hiroo>=20
Hiroo> On Sun, 15 Aug 2004 22:34:20 -0700
Hiroo> Rib Rdb <ri...@gm...> wrote:
Hiroo>=20
Hiroo> Rib> Actually I made the public static one because I had originally =
made
Hiroo> Rib> Converter just implement IDriver instead of extending Driver, a=
nd it
Hiroo> Rib> needed to do checksumming.  But then I decided to leave Convert=
er the
Hiroo> Rib> way it was, so I don't think the CalculateChecksum method is ne=
eded.
Hiroo> Rib>=20
Hiroo> Rib> On Sun, 15 Aug 2004 21:49:15 -0500, Hiroo Hayashi
Hiroo> Rib> <hir...@co...> wrote:
Hiroo> Rib> > Hi,
Hiroo> Rib> >=20
Hiroo> Rib> > Rib> Ok. I commited the interfaces. Eclipse gave some kind of=
 error when
Hiroo> Rib> > Rib> commiting, but it looks like it sent everything.  Let me=
 know if it
Hiroo> Rib> > Rib> did miss anything though.
Hiroo> Rib> >=20
Hiroo> Rib> > Your quick job always impresses me.
Hiroo> Rib> >=20
Hiroo> Rib> > I don't see any major problem.
Hiroo> Rib> >=20
Hiroo> Rib> > I've made the following change.
=2E..
Hiroo> Rib> > I'm seeing the following code in Driver.java.
Hiroo> Rib> >=20
Hiroo> Rib> >     protected void calculateChecksum(Patch patch, int start, =
int end, int ofs) {
Hiroo> Rib> >         CalculateChecksum(patch, start, end, ofs);
Hiroo> Rib> >     }
Hiroo> Rib> >=20
Hiroo> Rib> >     public final static void CalculateChecksum(Patch p, int s=
tart, int end, int ofs) {
Hiroo> Rib> >         ... // real code
Hiroo> Rib> >     }
Hiroo> Rib> >=20
Hiroo> Rib> > My take is to have only one method;
Hiroo> Rib> >     public static void calculateChecksum(Patch patch, int sta=
rt, int end,
Hiroo> Rib> >     int ofs)
Hiroo> Rib> >=20
Hiroo> Rib> > I understand you did not do this, because this broke synthdri=
ver
Hiroo> Rib> > compatibility.  But I think it is worth to be changed.  Any c=
omments?
Hiroo>=20
Hiroo> --=20
Hiroo> Hiroo Hayashi
--=20
Hiroo Hayashi