Re: [Jsynthlib-devel] patch editors

[Hiroo H. <hir...@co...>]

On Sun, 15 Aug 2004 22:44:40 -0700
Rib Rdb <ri...@gm...> wrote:

Rib> Hi.  I'm pretty good ad being confusing.  Let me try again.
Rib> 
Rib> On Sun, 15 Aug 2004 20:13:01 -0500, Hiroo Hayashi
Rib> <hir...@co...> wrote:
Rib> > 
Rib> > Rib> As I was making that last commit I started thinking about patch
Rib> > Rib> editors, and I had the idea to move the hasEditor and editPatch
Rib> > Rib> functions from IPatchDriver to IPatch. We could easily put a method in
Rib> > Rib> Patch to maintain compatibility with existing drivers.  The advantage
Rib> > Rib> I see is that when you create an xml based editor, you can simply say
Rib> > Rib> what patch type it supports.  Then when you click to edit a patch, it
Rib> > Rib> could give you a list of possible editors, or if there's only one open
Rib> > Rib> it right away.  How does this sound?
Rib> > 
Rib> > First I thought you were proposing 'IPatch.editPatch()', but it seems
Rib> > you were not.  Could you give me an example which would help me
Rib> > to understand.
Rib> 
Rib> That's exactly what I mean (well, I was thinking IPatch.edit() since
Rib> two Patches is redundant).   What I was trying to explain is that this
Rib> would make it easier to allow multiple editors for a given patch type
Rib> as we discussed before.

My thought was simply to define the following method in Patch.java;
        JSLFrame editPatch(Patch p) { // should be 'edit'
            return driver.editPatch(this);
        }

But I understood you were thinking more.

Rib> > BTW there are many lines like 'patch.getDriver().xxxxx(patch)'.  They can
Rib> > be 'patch.xxxxx()' by defining some one line methods in IPatch.  May I
Rib> > make the change?
Rib> 
Rib> Please do.

OK, I'll do.
-- 
Hiroo Hayashi