Re: [Jsynthlib-devel] Interfaces

[Hiroo H. <hir...@co...>]

Rib,

My baseline is that calculateChecksum(Patch, int, int, int) should be
static.

My next question would be why Converter still extended the Driver:-)
The checksumming is the only reason?  Or did you see any other problems?

On Sun, 15 Aug 2004 22:34:20 -0700
Rib Rdb <ri...@gm...> wrote:

Rib> Actually I made the public static one because I had originally made
Rib> Converter just implement IDriver instead of extending Driver, and it
Rib> needed to do checksumming.  But then I decided to leave Converter the
Rib> way it was, so I don't think the CalculateChecksum method is needed.
Rib> 
Rib> On Sun, 15 Aug 2004 21:49:15 -0500, Hiroo Hayashi
Rib> <hir...@co...> wrote:
Rib> > Hi,
Rib> > 
Rib> > Rib> Ok. I commited the interfaces. Eclipse gave some kind of error when
Rib> > Rib> commiting, but it looks like it sent everything.  Let me know if it
Rib> > Rib> did miss anything though.
Rib> > 
Rib> > Your quick job always impresses me.
Rib> > 
Rib> > I don't see any major problem.
Rib> > 
Rib> > I've made the following change.
Rib> > 
Rib> > 1. I updated the javadoc of new interfaces in core.
Rib> > 2. I replaced IPatchDriver.send(byte[]) with
Rib> > IPatchDriver.send(MidiMessage).
Rib> > 3. I reduced IPatchDriver reference in synthdrivers/*/*.
Rib> > 
Rib> > I'm seeing the following code in Driver.java.
Rib> > 
Rib> >     protected void calculateChecksum(Patch patch, int start, int end, int ofs) {
Rib> >         CalculateChecksum(patch, start, end, ofs);
Rib> >     }
Rib> > 
Rib> >     public final static void CalculateChecksum(Patch p, int start, int end, int ofs) {
Rib> >         ... // real code
Rib> >     }
Rib> > 
Rib> > My take is to have only one method;
Rib> >     public static void calculateChecksum(Patch patch, int start, int end,
Rib> >     int ofs)
Rib> > 
Rib> > I understand you did not do this, because this broke synthdriver
Rib> > compatibility.  But I think it is worth to be changed.  Any comments?

-- 
Hiroo Hayashi