Re: [Jsynthlib-devel] Interfaces

[Hiroo H. <hir...@co...>]

Hi,
        
Rib> Ok. I commited the interfaces. Eclipse gave some kind of error when
Rib> commiting, but it looks like it sent everything.  Let me know if it
Rib> did miss anything though.

Your quick job always impresses me.

I don't see any major problem.

I've made the following change.

1. I updated the javadoc of new interfaces in core.
2. I replaced IPatchDriver.send(byte[]) with
IPatchDriver.send(MidiMessage).
3. I reduced IPatchDriver reference in synthdrivers/*/*.

I'm seeing the following code in Driver.java.

    protected void calculateChecksum(Patch patch, int start, int end, int ofs) {
        CalculateChecksum(patch, start, end, ofs);
    }
    
    public final static void CalculateChecksum(Patch p, int start, int end, int ofs) {
        ... // real code
    }

My take is to have only one method;
    public static void calculateChecksum(Patch patch, int start, int end,
    int ofs)

I understand you did not do this, because this broke synthdriver
compatibility.  But I think it is worth to be changed.  Any comments?
-- 
Hiroo Hayashi