From: Hiroo H. <hir...@co...> - 2004-08-14 20:05:09
|
Rib, If I understand correctly you mentioned about the case where corresponding driver class is unknown. In other words the case where 'new Patch(byte[])' has been used. I agree with you that we need a new class/method to create a proper IPatch object. Neither a class implementing IPatch or a driver class cannot do the job. But on this SysexGetDialog case, the driver class is known. I think driver class needs a new method which creates a IPatch object which the driver uses. Rib> This is why I was talking about some sort of sysex dispatcher class Rib> that would take one or more messages, find which driver supports them, Rib> then pass the messages to it. The driver would create pne pr more Rib> patches either store them in the dispatcher class, or maybe in a Rib> patchbasket that was passed to the dispatcher. I think we need to do Rib> it this way instead of using a method to work with patches composed of Rib> multiple messages. =2E.. Rib> > But what shall we do for the line 165 of SysexGetDialog.java. Rib> >=20 Rib> > Patch p =3D new Patch(patchSysex, driver); Rib> >=20 Rib> > I think we need IPatchDriver.newPatch(byte[]) method. Rib> >=20 Rib> > # IPatchDriver is the interface for single patch driver and bank pat= ch Rib> > # driver. Rib> >=20 Rib> > By introducing IPatch interface, a driver can have its own patch Rib> > class. To enjoy the merit, we will need Rib> > IPatchDriver.newPatch(byte[]). Rib> >=20 Rib> > Any comments? > all Rib> > -- Rib> > Hiroo Hayashi --=20 Hiroo Hayashi |