From: <tt_...@gm...> - 2004-08-05 08:15:30
|
Hi Hiroo Hayashi wrote: > Hi, > > Joachim> Hmm, I suggest to replace the playPatch(IPatch) method > Joachim> on the other synthdrivers with playPatch(), > This OK. But... > > Joachim> remove the deprecated tag from playPatch(IPatch) > Joachim> and change playPatch(IPatch) in the Driver class > Joachim> to be an empty method, so that no new synthdriver > Joachim> will use it until the method is overriden. > > My take is to leave Driver.playPatch(IPatch) marked as @deprecated until > next release (0.20). It it just call Driver.playPatch(). This does not > break any code and synth driver developer can know what's going on. > > > BTW I have a basic question. Why we need playPatch() in each > synth drivers? I think a driver independent dialog window is enough. It > will include Torsten's MIDI sequencer. I see only the reason that the playPatch() method needs the information of the assoziated MIDI port of the concerned driver. But generally I aggree to Hiroo. Bye Torsten |