Re: [Jsynthlib-devel] Deprecated methods questions

[<tt_...@gm...>]

Hi Joachim,

Joachim Backhaus wrote:
> *************************
> 
> /** Play note. 
>      * @param p a <code>IPatch</code> value, which isn't used! !!!FIXIT!!!
>      * @deprecated Use playPatch().
>      */
>     public void playPatch(IPatch p) { // called by core and some Editors
> 	playPatch();
>     }
> 
> Why is that deprecated?
> There are many drivers that override this method and
> change the sysex array values of the Patch.
> And this leads to many deprecation warnings.
> 
> Shouldn't the Driver be modified so that the IPatch is used inside the
> playPatch(IPatch p) method?
> Or shouldn't just the deprecation tag be removed?

I've put this to deprecated, because the core.driver.playPatch doesn't use the parameter Patch.
The current patch to play is send by the menu-, popupmenu-, icon-actions.
These actions send the current patch to the synth and then call the driver.playPatch method.
So the driver.playPatch doesn't need to send the patch.
The playPatch method does only play the patch.

I took a look at the concerning drivers and many drivers doing the same things as in the "sendPatch(IPatch)" method, which isn't
necessary. Only the AlesisA6 and SCIProphet600 drivers seem to make some important things, which are not done by sendPatch().
I like to change these drivers, but without the hardware it's hard to test if I break something. So I let it be.

Maybe I was too aggressiv. So I can remove the deprecated flag again.
But I interpreted the comment at the playPatch method in this kind.

Bye
Torsten