[Jsynthlib-devel] Deprecated methods questions

[Joachim B. <jba...@pi...>]

Hi,

if you compile JSynthLib with deprecation on
(default with ANT using the current build.xml)
you get many depcreation warnings.

There are the following two problems:

    [javac] D:\JSynthLib\JSynthLib CVS\com\dreamfabric\DKnob.java:173:
warning: isManagingFocus() in javax.swing.JCompon
ent has been deprecated
    [javac]     public boolean isManagingFocus() {
    [javac]                    ^

Here is the Javadoc of "javax.swing.JComponent.isManagingFocus()":

"public boolean isManagingFocus()

    Deprecated. As of 1.4, replaced by Component.setFocusTraversalKeys(int,
Set) and Container.setFocusCycleRoot(boolean).

Changes this JComponent's focus traversal keys to CTRL+TAB and
CTRL+SHIFT+TAB. Also prevents SortingFocusTraversalPolicy from considering
descendants of this JComponent when computing a focus traversal cycle."

As "isManagingFocus()" in "DKnob" just returns true everytime I don't really
know what we should do here.

*************************

/** Play note. 
     * @param p a <code>IPatch</code> value, which isn't used! !!!FIXIT!!!
     * @deprecated Use playPatch().
     */
    public void playPatch(IPatch p) { // called by core and some Editors
	playPatch();
    }

Why is that deprecated?
There are many drivers that override this method and
change the sysex array values of the Patch.
And this leads to many deprecation warnings.

Shouldn't the Driver be modified so that the IPatch is used inside the
playPatch(IPatch p) method?
Or shouldn't just the deprecation tag be removed?

Regards,
Joachim