Re: [Jsynthlib-devel] First step towards support for the Yamaha SY85

[Peter G. <pet...@gm...>]

On Fri, Aug 7, 2009 at 12:18 PM, Christopher Arndt <chr...@we...>wrote:

> Hi Peter, hi all,
>
> first of all, many thanks for taking the time to look at my code and
> answering. Given the quietness of this list over the past months I
> wasn't sure whether to expect any answer at all!
>
JSynthLib is still alive :) It doesn't make much noise so today I created a
Facebook group :D
http://www.facebook.com/group.php?gid=232655115011 I hope that's legal ...


> Peter Geirnaert schrieb:
> > I've been trying to keep my focus so i could review your code, but
> > unfortunately got too often distracted.
> > What I can say now is your style looks very clean
>
> Thx. I admit that I am a little bit of a coding style fanatic. I do a
> lot of programming in Python where a clean coding style is considered an
> essential part of the culture.

In JSynthLib's culture, it's an essential part too, and now your code is a
great example.
Well, that's what I think, but I'm just a newbie trying to get a grip on
programming and contributing code to an open-source project, so I might
overlook any mistakes you made.


> Btw, this is my first bigger piece of
> Java code except some fumbling around with RoboCode.

Are you using Eclipse (or another IDE) or do you write your code in a
text-editor ?
I'm asking this because I also don't have any experience writing Java
source, and learning how to use Eclipse doesn't go very easy for me. It
makes looking up examples from the other drivers easier and the Javadoc is
helpful etc. I'm just not sure about building the GUI part with Eclipse so I
installed Netbeans too. For writing website source, I prefer a text-editor.



> [snip]
>
> > PS: What do you think about the wiki <http://jsynthlib.wikispaces.com>
> > I've been working on lately ?
>
> I had a look at it, but my first impression was, that there isn't that
> much more information than in the JSynthLib programming guide. I may be
> totally mistaken, I just didn't look at it very long. I was able to
> learn what I needed to know for patching together the Single Driver from
> the programming guide and looking at the source code of the other
> drivers and the API docs. But when I start writing the Bank driver and
> eventually a Patch Editor, I'll probably need more documentation and
> I'll surely look at your wiki again.
>
> One thing that got me a bit puzzled at first is: what are the different
> make targets and which ones do you use for the different system (Win, OS
> X, Unix) and how do you run your development copy of JSynthLib? The
> programming manual mentioned running JSynthLib with a "2" argument to
> enable debugging, but that didn't seem to work for me.

I read this in the programmer's guide:

Important: Once you've extracted the .jar file and made changes to the
resultant files, you must launch JSynthLib using;

    # On Windows use semicolon (;) instead of colon (:).
    java -classpath '.:groovy.jar' JSynthLib -D 3

instead of java -jar JSynthLib.jar. Otherwise you just run the old .jar file
and none of your alterations get used. The command line option '-D 3' gives
you various debug messages from ErrorMsg class. The messages help you.



> I think it would
> be great to have a quick start guide for developers on every of the
> three major platforms, that just gives the exact steps to compile and
> run a SVN checkout.

That's the reason why I started that wiki, so you can describe the exact
steps
that are working to compile on your platform. That way , the information is
immediately there for newcomers and nobody has to wait for the developers to
update the programmer's guide.
Just start a new page and if it's finished, you can also send it to the
SourceForge project for inclusion in the Programmer's Guide.


> > PPS: Codereview looks like a great tool, and how did you create the
> > issue on sourceforge ?
> > I'd like to add links to information about these subjects on my wiki too.
>
> You just need a sourceforge account (which I already had) and then go to
> "Tracker" on the JSynthLib project page and then go to "Patches" and
> click on "Add new", add a summary and description and upload your diff.
>
> For the Codereview tool, you need a Google account, and then you can
> upload your diffs in different ways. I used the provided "upload.py"
> Python script, which you run from your JSynthLib SVN working dir. It
> will create a diff of your changes and upload them to codereview,
> automatically selecting the right repository. You can then add a
> description and then use the "Publish+Mail Comments" function to send a
> mail requesting for code review, like I did to the mailing list.

Thanks, I used this description on the
wiki<http://jsynthlib.wikispaces.com/contribute>;-)

Cheers!
Peter