From: Rib R. <ri...@us...> - 2009-01-15 16:47:25
|
I am also alive. Before adding you as a developer I'd like to code review at least your first commit. Can you send a patch to the list? On a related note, if this project because active again I think it would be a good idea to make code reviews standard for all commits. I've gotten used to using them at work, and in general having a second set of eyes on each change helps increase code quality. I'd recommend migrating to svn so we could use http://codereview.appspot.com What do other people think of this idea? Thu, Jan 15, 2009 at 3:57 AM, Nicolas Boulicault <nic...@la...> wrote: > > Hi Joe, > thanks for your reply. > Indeed I've been working with the current cvs version, and I don't think > my code breaks anything. > It would be fine for me if you added me to the developers. > I'm already an admin on a few sourceforge projects, I wouldn't mind > becoming one on JSynthLib too. > Anyway I'm glad to see this list (and project ?) alive again ! > > Regards. > > Nicolas > > PS : my sourceforge id is nboul > PS2 : maybe it would be a good idea to cleanup the admins and developers > lists (we could ask all the current members if they wish to remain members) > > Joe Emenaker wrote: > > Nicolas Boulicault wrote: > >> Hi again, > >> I wrote a post few days ago about Novation xioSynth support but got > >> no answer. > >> Would any admin / developer have a look at that and accept / refuse it ? > >> > > Uh... that would take... uh... "work". :) > > > > Have you compiled it against the current CVS code? Does it break > > anything else? If it seems to be okay to you, then I can make you a > > developer and you can commit it yourself. > > > > - Joe > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > _______________________________________________ > Jsynthlib-devel mailing list > Jsy...@li... > https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel |