jsynthlib-devel

[Jsynthlib-devel] Conditional display of "What do you wish to do with the changed copy of the Patch?"

[Joe E. <jo...@em...>]

As far as I can tell, PatchEditorFrame.frameClosing displays the "What
do you wish to do with the changed copy of the Patch?" dialog box
*regardless* of whether the patch data was edited at all. Is this correct?

If it is, then am I the only one who thinks that PatchEditorFrame should
either compare the "before" and "after" data or there should be some
"patchWasChanged()" method in each synth's SingleDriver that it could
call to find out?

- Joe

Re: [Jsynthlib-devel] Conditional display of "What do you wish to do with the changed copy of the Patch?"

[Rib R. <ri...@gm...>]

On 2/6/06, Joe Emenaker <jo...@em...> wrote:
> As far as I can tell, PatchEditorFrame.frameClosing displays the "What
> do you wish to do with the changed copy of the Patch?" dialog box
> *regardless* of whether the patch data was edited at all. Is this correct=
?
>
> If it is, then am I the only one who thinks that PatchEditorFrame should
> either compare the "before" and "after" data or there should be some
> "patchWasChanged()" method in each synth's SingleDriver that it could
> call to find out?

It looks like you are correct that the dialog is always displayed, and
I agree that it should only be displayed if the patch was modified.

Re: [Jsynthlib-devel] Conditional display of "What do you wish to do with the changed copy of the Patch?"

[Joe E. <jo...@em...>]

Rib Rdb wrote:
> On 2/6/06, Joe Emenaker <jo...@em...> wrote:
>   
> It looks like you are correct that the dialog is always displayed, and
> I agree that it should only be displayed if the patch was modified.
>   
Okay, then.... there are two ways to handle this:
1 - We can have the PatchEditorFrame superclass make a "before editing" 
copy of the patch (which it probably does anyway, since you can revert 
to it, right?) and then it can do a byte-by-byte comparison of the 
"after editing" data to decide whether anything was changed.
2 - We can have the PatchEditorFrame implement some kind of "boolean 
wasAltered()" method which would always default to "true", but each 
synthdriver could override.

Or, maybe we could have both. Maybe the default behavior would be a 
byte-by-byte comparison, but individual editors could override it in 
cases where the patch data was just too big.

- Joe

Re: [Jsynthlib-devel] Conditional display of "What do you wish to do with the changed copy of the Patch?"

[Thorsten K. <Tho...@gm...>]

Btw.: A feature which I would like to see in this dialog box is a button, 
which allows to save an edited patch to another bank location.

Currently it's required to copy & paste an existing patch to another
location, before it can be modified without overwriting the old one.

Best Regards, Thorsten.


On Monday 06 February 2006 17:39, Rib Rdb wrote:
> On 2/6/06, Joe Emenaker <jo...@em...> wrote:
> > As far as I can tell, PatchEditorFrame.frameClosing displays the "What
> > do you wish to do with the changed copy of the Patch?" dialog box
> > *regardless* of whether the patch data was edited at all. Is this correct?
> >
> > If it is, then am I the only one who thinks that PatchEditorFrame should
> > either compare the "before" and "after" data or there should be some
> > "patchWasChanged()" method in each synth's SingleDriver that it could
> > call to find out?
> 
> It looks like you are correct that the dialog is always displayed, and
> I agree that it should only be displayed if the patch was modified.
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642
> _______________________________________________
> Jsynthlib-devel mailing list
> Jsy...@li...
> https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel
> 
> 

Re: [Jsynthlib-devel] Conditional display of "What do you wish to do with the changed copy of the Patch?"

[Joe E. <jo...@em...>]

Thorsten Klose wrote:
> Btw.: A feature which I would like to see in this dialog box is a button, 
> which allows to save an edited patch to another bank location.
>   
Probably a good idea. However, in order to do this, we have to let the 
user specify the destination (which means some drop-down boxes). There 
are two ways to do this:
 1 - Have "Save", "Discard", "Save to other location" be *buttons* and, 
if the user chooses the last one, then they'd get *another* dialog box 
asking them where to save it.
 2 - Have "Save", "Discard", "Save to..." be radio-buttons and the 
drop-boxes will always be present, but disabled/greyed unless "Save 
to..." is selected.
> Currently it's required to copy & paste an existing patch to another
> location, before it can be modified without overwriting the old one.
>   
Actually, isn't this what "Save to clipboard" is for? You can save a 
copy to the clipboard and then paste into a bank someplace else?

- Joe