jsynthlib-devel

[Jsynthlib-devel] TX81z editor error

[Martin T. <m.t...@zo...>]

Using the latest SVN versions of JSynthLib I am getting an error when 
trying to open the Yamaha TX81Z voice editor:


The error was:
   99
The exception text is:
java.lang.ArrayIndexOutOfBoundsException: 99
 	at 
synthdrivers.YamahaTX81z.YamahaTX81zSingleEditor.<init>(YamahaTX81zSingleEditor.java:121)
 	at 
synthdrivers.YamahaTX81z.YamahaTX81zSingleDriver.editPatch(YamahaTX81zSingleDriver.java:67)
 	at core.Patch.edit(Patch.java:181)
 	at 
core.AbstractLibraryFrame.editSelectedPatch(AbstractLibraryFrame.java:348)
 	at core.Actions$1Worker.run(Actions.java:969)


I have learnt how to compile and run Java code, but that's where my Java 
skills more or less end. But it looks like this error was introduced 
during the recent SVN activity. Maybe someone can take a look at this?

I have also been doing a few improvements on the envelope graphics for 
the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were missing a 
Sustain segment, which I have fixed now). I will send some 
patches/proposals later, after the above bug has been fixed and after I 
have done some more testing with my locally modified copy.

-- 

MT

Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

Thanks for reporting this, its probably me that broke it because I added 
some images for the waveforms into the editor yesterday. It was working 
for me though! I'll have a look at this later on and see if I can get it 
to happen as well.

frankie

On 09/04/11 11:19, Martin Tarenskeen wrote:
> Using the latest SVN versions of JSynthLib I am getting an error when
> trying to open the Yamaha TX81Z voice editor:
>
>
> The error was:
>     99
> The exception text is:
> java.lang.ArrayIndexOutOfBoundsException: 99
>   	at
> synthdrivers.YamahaTX81z.YamahaTX81zSingleEditor.<init>(YamahaTX81zSingleEditor.java:121)
>   	at
> synthdrivers.YamahaTX81z.YamahaTX81zSingleDriver.editPatch(YamahaTX81zSingleDriver.java:67)
>   	at core.Patch.edit(Patch.java:181)
>   	at
> core.AbstractLibraryFrame.editSelectedPatch(AbstractLibraryFrame.java:348)
>   	at core.Actions$1Worker.run(Actions.java:969)
>
>
> I have learnt how to compile and run Java code, but that's where my Java
> skills more or less end. But it looks like this error was introduced
> during the recent SVN activity. Maybe someone can take a look at this?
>
> I have also been doing a few improvements on the envelope graphics for
> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were missing a
> Sustain segment, which I have fixed now). I will send some
> patches/proposals later, after the above bug has been fixed and after I
> have done some more testing with my locally modified copy.
>

Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

Thanks for reporting this, its probably me that broke it because I added 
some images for the waveforms into the editor yesterday. It was working 
for me though! I'll have a look at this later on and see if I can get it 
to happen as well.

frankie

On 09/04/11 11:19, Martin Tarenskeen wrote:
> Using the latest SVN versions of JSynthLib I am getting an error when
> trying to open the Yamaha TX81Z voice editor:
>
>
> The error was:
>     99
> The exception text is:
> java.lang.ArrayIndexOutOfBoundsException: 99
>   	at
> synthdrivers.YamahaTX81z.YamahaTX81zSingleEditor.<init>(YamahaTX81zSingleEditor.java:121)
>   	at
> synthdrivers.YamahaTX81z.YamahaTX81zSingleDriver.editPatch(YamahaTX81zSingleDriver.java:67)
>   	at core.Patch.edit(Patch.java:181)
>   	at
> core.AbstractLibraryFrame.editSelectedPatch(AbstractLibraryFrame.java:348)
>   	at core.Actions$1Worker.run(Actions.java:969)
>
>
> I have learnt how to compile and run Java code, but that's where my Java
> skills more or less end. But it looks like this error was introduced
> during the recent SVN activity. Maybe someone can take a look at this?
>
> I have also been doing a few improvements on the envelope graphics for
> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were missing a
> Sustain segment, which I have fixed now). I will send some
> patches/proposals later, after the above bug has been fixed and after I
> have done some more testing with my locally modified copy.
>

Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

sorry for the double post before.
I have put a fix to SVN. If you still have this problem, could you send 
me a sysx file containing a patch that triggers it?

thanks
frankie
On 09/04/11 12:37, frankster wrote:
> Thanks for reporting this, its probably me that broke it because I added
> some images for the waveforms into the editor yesterday. It was working
> for me though! I'll have a look at this later on and see if I can get it
> to happen as well.
>
> frankie
>
> On 09/04/11 11:19, Martin Tarenskeen wrote:
>> Using the latest SVN versions of JSynthLib I am getting an error when
>> trying to open the Yamaha TX81Z voice editor:
>>
>>
>> The error was:
>>      99
>> The exception text is:
>> java.lang.ArrayIndexOutOfBoundsException: 99
>>    	at
>> synthdrivers.YamahaTX81z.YamahaTX81zSingleEditor.<init>(YamahaTX81zSingleEditor.java:121)
>>    	at
>> synthdrivers.YamahaTX81z.YamahaTX81zSingleDriver.editPatch(YamahaTX81zSingleDriver.java:67)
>>    	at core.Patch.edit(Patch.java:181)
>>    	at
>> core.AbstractLibraryFrame.editSelectedPatch(AbstractLibraryFrame.java:348)
>>    	at core.Actions$1Worker.run(Actions.java:969)
>>
>>
>> I have learnt how to compile and run Java code, but that's where my Java
>> skills more or less end. But it looks like this error was introduced
>> during the recent SVN activity. Maybe someone can take a look at this?
>>
>> I have also been doing a few improvements on the envelope graphics for
>> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were missing a
>> Sustain segment, which I have fixed now). I will send some
>> patches/proposals later, after the above bug has been fixed and after I
>> have done some more testing with my locally modified copy.
>>
>
>
> ------------------------------------------------------------------------------
> Special Offer -- Download ArcSight Logger for FREE!
> Finally, a world-class log management solution at an even better
> price-free! And you'll get a free "Love Thy Logs" t-shirt when you
> download Logger. Secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsisghtdev2dev
> _______________________________________________
> Jsynthlib-devel mailing list
> Jsy...@li...
> https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel

Re: [Jsynthlib-devel] TX81z editor error

[Martin T. <m.t...@zo...>]

On Sun, 4 Sep 2011, frankster wrote:

> sorry for the double post before.
> I have put a fix to SVN. If you still have this problem, could you send
> me a sysx file containing a patch that triggers it?

Thanks. Problem has gone.

>>> I have also been doing a few improvements on the envelope graphics for
>>> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were missing a
>>> Sustain segment, which I have fixed now). I will send some
>>> patches/proposals later, after the above bug has been fixed and after I
>>> have done some more testing with my locally modified copy.

I have attached patches for the Yamaha DX7, DX100, and TX81z Single Voice 
editor. They change the Envelope Generator (level and pitch) graphics.
1. A sustain segment is now correctly Bdisplayed.
2. DX7 EG, PEG and DX21 PEG: The start level is the same as the end 
level (DX7 Level/Pitch 4, DX21 PEG Level 3). (read the DX7 manual) 
3. The DX21/TX81Z envelope is a hard one. I have choosen to draw a 
horizontal line after the D1L point. This is only true if D2R=0. But it's 
as good as I could get it.

I hope someone who knows how SVN works can merge my ideas into the trunk. 
(I guess I should learn how to use it before asking to get write access 
myself)

-- 

MT

Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

On 04/09/2011 19:26, Martin Tarenskeen wrote:
>
>
> On Sun, 4 Sep 2011, frankster wrote:
>
>> sorry for the double post before.
>> I have put a fix to SVN. If you still have this problem, could you send
>> me a sysx file containing a patch that triggers it?
>
> Thanks. Problem has gone.
>
>>>> I have also been doing a few improvements on the envelope graphics for
>>>> the Yamaha DX7 and DX100/TX81z family (EG and PEG). (All were
>>>> missing a
>>>> Sustain segment, which I have fixed now). I will send some
>>>> patches/proposals later, after the above bug has been fixed and
>>>> after I
>>>> have done some more testing with my locally modified copy.
>
> I have attached patches for the Yamaha DX7, DX100, and TX81z Single
> Voice editor. They change the Envelope Generator (level and pitch)
> graphics.
> 1. A sustain segment is now correctly Bdisplayed.
> 2. DX7 EG, PEG and DX21 PEG: The start level is the same as the end
> level (DX7 Level/Pitch 4, DX21 PEG Level 3). (read the DX7 manual) 3.
> The DX21/TX81Z envelope is a hard one. I have choosen to draw a
> horizontal line after the D1L point. This is only true if D2R=0. But
> it's as good as I could get it.
>
> I hope someone who knows how SVN works can merge my ideas into the
> trunk. (I guess I should learn how to use it before asking to get
> write access myself)
>

I have submitted your patches into SVN - although I have kept the DX7
algorithm images in their own directory (as its marginally neater than
mixed in with the Java files I think) but I have moved the images
directory into the DX7/common directory which solves the crash similarly
to your patch.

frankie

Re: [Jsynthlib-devel] TX81z editor error

[Martin T. <m.t...@zo...>]

On Sun, 4 Sep 2011, frankster wrote:

> I have submitted your patches into SVN - although I have kept the DX7
> algorithm images in their own directory (as its marginally neater than
> mixed in with the Java files I think) but I have moved the images
> directory into the DX7/common directory which solves the crash similarly
> to your patch.

I already knew about your DX7 images directory fix. I accidentally 
attached an old patchfile to my previous mail that was still on my 
harddisk.

The patch attached now is the one I wanted to send: it fixes the DX7 
envelope graphics.

-- 

MT

Re: [Jsynthlib-devel] TX81z editor error

[frankster <jsy...@te...>]

On 04/09/2011 21:32, Martin Tarenskeen wrote:
>
>
> On Sun, 4 Sep 2011, frankster wrote:
>
>> I have submitted your patches into SVN - although I have kept the DX7
>> algorithm images in their own directory (as its marginally neater than
>> mixed in with the Java files I think) but I have moved the images
>> directory into the DX7/common directory which solves the crash similarly
>> to your patch.
>
> I already knew about your DX7 images directory fix. I accidentally
> attached an old patchfile to my previous mail that was still on my
> harddisk.
>
> The patch attached now is the one I wanted to send: it fixes the DX7
> envelope graphics.
>

Ah I wasn't sure if it was a mistake or not. Anyway I have submitted
your new patch as well.

Cheers,
Frankie