jsynthlib-devel

[Jsynthlib-devel] Patch Structure.

[Rib R. <ri...@gm...>]

(I accidentally sent this message to the yahoo groups list.  Please
ignore that one, as it contains an error)

I'm about ready to commit the first part of XML single bank support,
so I want to make sure I put the new files in the right package. After
reviewing the previous thread, here's what it looks like we've suggested so
far (all under org.jsynthlib):

.midi - MIDI support classes
.widgets - Sysex widgets
.desktop - JSL* classes
.editorbuilder - GUI editorbuilder
.utils - MacUtils, ErrorMsg
.jsynthlib - current core
.jsynthlib.synthdrivers - all (xml and java) drivers
.jsynthlib.xml - XML driver and support files

So, first of all, when I commit my changes I propose to create four package=
s:
org.jsynthlib.utils - I will place several generic xml utilities here
                           (it would be confusing to have both org.jsynthli=
b.xml
                            and org.jsynthlib.jsynthlib.xml)
org.jsynthlib.jsynthlib.xml - XML driver's parser, factories, etc.
org.jsynthilb.jsynthlib.plugins - checksum and decoding algorithms for
XML drivers
org.jsynthlib.jsynthlib.synthdrivers.yamaha.motif - YamahaMotif.xml
and NormalVoice.xml

Second, I have one more comment on the package structure (although it
does not conflict with my proposed changes). =A0Since there are so many
dialogs, would it not be a good idea to have a package for them, and
perhaps also a package for the config panels?

Re: [Jsynthlib-devel] Patch Structure.

[<tt_...@gm...>]

Hi Ryan,

Rib Rdb wrote:
> Second, I have one more comment on the package structure (although it
> does not conflict with my proposed changes).  Since there are so many
> dialogs, would it not be a good idea to have a package for them, and
> perhaps also a package for the config panels?

Perhaps this could make a future localization (translation into other languages as english) easier.
Of course, only if we want to do this.

Bye
Torsten

Re: [Jsynthlib-devel] Patch Structure.

[Hiroo H. <hir...@co...>]

Rib and Torsten,

Rib > Second, I have one more comment on the package structure (although it
Rib > does not conflict with my proposed changes).  Since there are so many
Rib > dialogs, would it not be a good idea to have a package for them, and
Rib > perhaps also a package for the config panels?

I'm not sure which is better.

The number of files under jsynthlib (current core) will be about half
of the current one.  I would say the current core has too many files.
Half of files may be enough to be managed.

On the other hand, to access members in a different package we need
more public members (methods and fields).  A dialog class does not
access members of other dialogs, since there are independent each
other in general.  The package will be a collection of independent
classes, and jsynthlib (core) package needs to have more public
members.

If I have to choose one of the selection, I would take not to create a
package for dialogs.  But this is not strong preference.  Please
create it if think it is better.

Torsten> Perhaps this could make a future localization (translation
Torsten> into other languages as english) easier.

Why making package for dialog helps localization?  I think it is
opposite.  But the difference would be very little.
-- 
Hiroo Hayashi

Re: [Jsynthlib-devel] Patch Structure.

[<tt_...@gm...>]

Hi Hiroo,

Hiroo Hayashi wrote:
> Torsten> Perhaps this could make a future localization (translation
> Torsten> into other languages as english) easier.
> 
> Why making package for dialog helps localization?  I think it is
> opposite.  But the difference would be very little.

I got just the idea of localization as an future task and in my imagination it's easier if all dialogs are placed at one place.
That's all.

But I have to admit that I have no experience in this questions.

Bye
Torsten