Menu
▾
▴
jsynthlib-devel
|
From: Hiroo H. <hir...@co...> - 2004-08-04 03:52:40
|
Torsten,
> > Last two days I was out of town, I've not see the recent changes yet.
> >
> > If I understand correctly we will not use Patch class in core anymore
> > (except in Patch class itself).
> >
> > The second change should be;
> > IPatch pk = patarray[k];
>
> OK, but IPatch doesn't know the sysex byte array yet.
>
> So we run into trouble while compiling because the following call failes:
>
> line 206-209:
>
> pk.setComment("Probably a "
> + LookupManufacturer.get(pk.sysex[1],
> pk.sysex[2],
> pk.sysex[3])
> + " Patch, Size: " + pk.sysex.length);
When I wrote my reply I did not realize this problem. But now this
can be solved by getByteArray() as Rib wrote.
But what shall we do for the line 165 of SysexGetDialog.java.
Patch p = new Patch(patchSysex, driver);
I think we need IPatchDriver.newPatch(byte[]) method.
# IPatchDriver is the interface for single patch driver and bank patch
# driver.
By introducing IPatch interface, a driver can have its own patch
class. To enjoy the merit, we will need
IPatchDriver.newPatch(byte[]).
Any comments? > all
--
Hiroo Hayashi
|
|
From: Hiroo H. <hir...@co...> - 2004-08-13 03:57:33
|
Rib, Rib> You should be able to change the method signiture in Driver back to Rib> Patch using the refactoring, then add the new method that uses IPatch. I tried what you wrote. It works great. Eclipse is a really great tool. Now only subclasses of SysexWidget and Converter class use IPatch under synthdrivers. If we decide to create IConverter class I can let subclass of Converter not to use IPatch, but I don't think it is worth to do. Probably I see why you did not let ParamModel use IPatch. The current ParmModel depends on Patch class. We may want to introduce IParamModel interface. I have one question about Eclipse. I'm using the auto-build feature. It causes fails on files under midiprovider directory. I can ignore them, but I don't want to see the fails in Problem view. How do you handle this issue? Thanks. -- Hiroo Hayashi |
|
From: <tt_...@gm...> - 2004-08-13 20:03:02
|
Hi Ryan, Hi Hiroo, after your discussion about Eclipse, I'm interested in this tool. Where is this tool available? Maybe I can use it under my Linux tool. Bye Torsten Hiroo Hayashi wrote: > Rib, > > Rib> You should be able to change the method signiture in Driver back to > Rib> Patch using the refactoring, then add the new method that uses IPatch. > > I tried what you wrote. It works great. Eclipse is a really great tool. > > Now only subclasses of SysexWidget and Converter class use IPatch under > synthdrivers. If we decide to create IConverter class I can let > subclass of Converter not to use IPatch, but I don't think it is worth > to do. > > Probably I see why you did not let ParamModel use IPatch. The current > ParmModel depends on Patch class. We may want to introduce IParamModel > interface. > > I have one question about Eclipse. I'm using the auto-build feature. > It causes fails on files under midiprovider directory. I can ignore them, > but I don't want to see the fails in Problem view. How do you handle > this issue? > > Thanks. |
|
From: <tt_...@gm...> - 2004-08-14 16:41:14
|
Hi Ryan, Uups, that a lot of megs to download. I have to wait till I find a friend with a fast internet connection. Bye Torsten Rib Rdb wrote: > It's available at http://www.eclipse.org/ > > On Fri, 13 Aug 2004 20:08:45 +0200, tt_...@gm... > <tt_...@gm...> wrote: > >>Hi Ryan, Hi Hiroo, >> >>after your discussion about Eclipse, I'm interested in this tool. >>Where is this tool available? >>Maybe I can use it under my Linux tool. >> >>Bye >>Torsten >> >> >> >>Hiroo Hayashi wrote: >> >>>Rib, >>> >>>Rib> You should be able to change the method signiture in Driver back to >>>Rib> Patch using the refactoring, then add the new method that uses IPatch. >>> >>>I tried what you wrote. It works great. Eclipse is a really great tool. >>> >>>Now only subclasses of SysexWidget and Converter class use IPatch under >>>synthdrivers. If we decide to create IConverter class I can let >>>subclass of Converter not to use IPatch, but I don't think it is worth >>>to do. >>> >>>Probably I see why you did not let ParamModel use IPatch. The current >>>ParmModel depends on Patch class. We may want to introduce IParamModel >>>interface. >>> >>>I have one question about Eclipse. I'm using the auto-build feature. >>>It causes fails on files under midiprovider directory. I can ignore them, >>>but I don't want to see the fails in Problem view. How do you handle >>>this issue? >>> >>>Thanks. >> >>------------------------------------------------------- >>SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media >>100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 >>Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. >>http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 >>_______________________________________________ >>Jsynthlib-devel mailing list >>Jsy...@li... >>https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel >> > > > |
|
From: Hiroo H. <hir...@co...> - 2004-08-14 17:16:36
|
Denis, denis> 2/ the master controller midi thru doesn't work, nothing is sent back to the the denis> synth (or any midi port). It's just to mention it because I'm using another prog denis> to do the MIDI thru. I've test on my machine again and am seeing it is working. Does MIDI Monitor show "RECV: Note On..."? Actually I don't have MIDI keyboard in my room (although I have MIDI piano in living room), I'm testing by using MIDI monitor (MIDI-OX). I believe this is fine, but I may be missing something. -- Hiroo Hayashi |
|
From: <tt_...@gm...> - 2004-08-05 08:15:18
|
Hi Hiroo,
Hiroo Hayashi wrote:
> Torsten,
>
>
>>>Last two days I was out of town, I've not see the recent changes yet.
>>>
>>>If I understand correctly we will not use Patch class in core anymore
>>>(except in Patch class itself).
>>>
>>>The second change should be;
>>> IPatch pk = patarray[k];
>>
>>OK, but IPatch doesn't know the sysex byte array yet.
>>
>>So we run into trouble while compiling because the following call failes:
>>
>>line 206-209:
>>
>>pk.setComment("Probably a "
>> + LookupManufacturer.get(pk.sysex[1],
>> pk.sysex[2],
>> pk.sysex[3])
>> + " Patch, Size: " + pk.sysex.length);
>
>
> When I wrote my reply I did not realize this problem. But now this
> can be solved by getByteArray() as Rib wrote.
>
> But what shall we do for the line 165 of SysexGetDialog.java.
>
> Patch p = new Patch(patchSysex, driver);
>
> I think we need IPatchDriver.newPatch(byte[]) method.
>
> # IPatchDriver is the interface for single patch driver and bank patch
> # driver.
>
> By introducing IPatch interface, a driver can have its own patch
> class. To enjoy the merit, we will need
> IPatchDriver.newPatch(byte[]).
>
> Any comments? > all
If I understood your previous proposals to the interfaces right, IPatchDriver will collect all methods which are needed for library
functions.
So IPatchDriver will also have a definition of createNewPatch. Am I right?
From this point it would be clever to define also a function IPatchDriver.newPatch(...). I don't know if we need several newPatch(...)
methods with different parameters like (byte[]), (byte[], Driver), ...
Bye
Torsten
|
|
From: Hiroo H. <hir...@co...> - 2004-08-14 20:05:09
|
Rib, If I understand correctly you mentioned about the case where corresponding driver class is unknown. In other words the case where 'new Patch(byte[])' has been used. I agree with you that we need a new class/method to create a proper IPatch object. Neither a class implementing IPatch or a driver class cannot do the job. But on this SysexGetDialog case, the driver class is known. I think driver class needs a new method which creates a IPatch object which the driver uses. Rib> This is why I was talking about some sort of sysex dispatcher class Rib> that would take one or more messages, find which driver supports them, Rib> then pass the messages to it. The driver would create pne pr more Rib> patches either store them in the dispatcher class, or maybe in a Rib> patchbasket that was passed to the dispatcher. I think we need to do Rib> it this way instead of using a method to work with patches composed of Rib> multiple messages. =2E.. Rib> > But what shall we do for the line 165 of SysexGetDialog.java. Rib> >=20 Rib> > Patch p =3D new Patch(patchSysex, driver); Rib> >=20 Rib> > I think we need IPatchDriver.newPatch(byte[]) method. Rib> >=20 Rib> > # IPatchDriver is the interface for single patch driver and bank pat= ch Rib> > # driver. Rib> >=20 Rib> > By introducing IPatch interface, a driver can have its own patch Rib> > class. To enjoy the merit, we will need Rib> > IPatchDriver.newPatch(byte[]). Rib> >=20 Rib> > Any comments? > all Rib> > -- Rib> > Hiroo Hayashi --=20 Hiroo Hayashi |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X