Menu

#2 pcm2speex buffer size is not checked enough

open
nobody
None
5
2004-01-15
2004-01-15
No

The buffer size of Pcm2SpeexAudioInputStream must be at
least as big as framesPerPacket*frameSize, otherwise it
will never see enough data to process and you end up
with no audio data in your output. This is never
checked in any way. It should probably either change
the frame size if necessary, or throw an exception if
the buffer size is too small for it to ever work.

This bug probably has not been found yet because
without a patch that I just submitted, the input stream
won't work if framesPerPacket is anything but 1!!!

Discussion


Log in to post a comment.