Re: [Jsoncpp-devel] jsoncpp patches from Google

[Aaron J. <ja...@go...>]

On Tue, May 24, 2011 at 3:06 AM, Baptiste Lepilleur
<bap...@gm...> wrote:
> To make sure I understand the issue: sscanf on Mac OS X will write in the
> format string provided as parameter even though it is declared const char *?

That's right. Don't ask me. :-/

> - JSON_FAIL_MESSAGE is bugged if there is no exception (e.g.
> multi-statements). IMHO it should just call a function that dump message and
> then call abort().

Sorry, I'm not sure I understand the first sentence here. Could you clarify?


> - partial duplication of assertions macros already present in json_value.cpp
>
> I think we should move the assertion/failure macros from json_value.cpp  to
> a common private header instead of duplicating them.
> In the future, we may want to provide hook to allow user to customize what
> happens on failure (e.g. like google breakpad integration or whatever stack
> capture tool you happen to use...)

Okay, sounds good.