#69 the boolean expression always return false

[fu zhufang]

hello author, I find a expression that in json_reader.cpp 566 line. like this: bool badTokenType = ( token.type_ == tokenArraySeparator && token.type_ == tokenArrayEnd ); the boolean expression always return false. I think not '&&' but '||', do you thing so ?

[Christopher Dunn]

Seems fine to me. That token must be either tokenArraySeparator or tokenArrayEnd at that point.

[Klaus Gütter]

Then it should be:

bool badTokenType = ( token.type_ != tokenArraySeparator && token.type_ != tokenArrayEnd );

("!=" unstead of "=="), or?

[Christopher Dunn]

Maybe your version is out of date. Look here:
https://github.com/open-source-parsers/jsoncpp/blob/master/src/lib_json/json_reader.cpp#L483

bool badTokenType =
        (token.type_ != tokenArraySeparator && token.type_ != tokenArrayEnd);

That looks correct to me. It's "de morgan" equivalent to

!(t == arraysep || t == end)

[Klaus Gütter]

Indeed - my version is 0.5.0 which seems to be the current "official" version. And in 0.5.0 it's "==" instead of "!=".
Which version would you recommend?

[Christopher Dunn]

Use the latest from GitHub. If you need a tarball, GitHub can supply that.