#25 Robber ghost while moving

open
nobody
None
5
2007-10-13
2007-10-13
No

Currently, the robber disappears from the board graphic while being moved by the current player.

This patch instead "ghosts" (dims out) the robber's previous hex as a reminder to the player.

Two versions attached:

- Patch for clean 1.0.6
- Patch for 1.0.6 + rbrooks9's larger-board patch.

Discussion

  • Jeremy D. Monin

    Jeremy D. Monin - 2007-10-13

    Logged In: YES
    user_id=220161
    Originator: YES

    File Added: jsettlers-1.0.6-robber-ghost-for-lb.diff

     
  • Jeremy D. Monin

    Jeremy D. Monin - 2007-10-14

    Logged In: YES
    user_id=220161
    Originator: YES

    Updating:
    - Eliminate possible array bounds exception
    - Single patch applies to clean 1.0.6 or largerboard

     
  • Jeremy D. Monin

    Jeremy D. Monin - 2007-10-14

    Logged In: YES
    user_id=220161
    Originator: YES

    This patch applies cleanly to 1.0.6, or to 1.0.6 + largerboard patch.
    File Added: jsettlers-1.0.6-robber-ghost.diff

     
  • Jeremy D. Monin

    Jeremy D. Monin - 2007-12-16

    Logged In: YES
    user_id=220161
    Originator: YES

    Updated version: Now draws ghost whenever any player is moving the robber, not just when the current player is moving.

    If you've already applied v1 of this patch, this "diff of the diff" will bring you up to date:

    diff -u3r jsettlers-1.0.6-src/src/java/soc/client/SOCBoardPanel.java jsettlers-1.0.6-src-p/src/java/soc/client/SOCBoardPanel.java
    --- jsettlers-1.0.6-src/src/java/soc/client/SOCBoardPanel.java Wed Nov 28 15:20:40 2007
    +++ jsettlers-1.0.6-src-p/src/java/soc/client/SOCBoardPanel.java Wed Nov 28 18:34:39 2007
    @@ -968,17 +968,17 @@
    drawHex(g, i);
    }

    + int gameState = game.getGameState();
    +
    if (board.getRobberHex() != -1)
    {
    - drawRobber(g, board.getRobberHex(), (mode != PLACE_ROBBER));
    + drawRobber(g, board.getRobberHex(), (gameState != SOCGame.PLACING_ROBBER));
    }

    int pn;
    int idx;
    int max;

    - int gameState = game.getGameState();
    -
    if (gameState != SOCGame.NEW)
    {
    drawArrow(g, game.getCurrentPlayerNumber(), game.getCurrentDice());

    File Added: robber-ghost-v2.diff

     
  • Jeremy D. Monin

    Jeremy D. Monin - 2007-12-16

    Logged In: YES
    user_id=220161
    Originator: YES

    Correct filename of patch: jsettlers-1.0.6-robber-ghost-v2.diff
    File Added: jsettlers-1.0.6-robber-ghost-v2.diff

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks