jsecurity-developer

[JSecurity-Developer] AuthenticationToken / Principal clean up

[lhazlewood (s. by Nabble.com) <li...@na...>]

Heya,

After talking about the 'usefulness' of the Principal interface (since it only requires equals(), toString() and hashCode() implementations) we had discussed removing it as a required dependency of JSecurity framework classes.  I'd like to remove that interface and probably the AuthenticationToken interface for the same reasons.  Any objections to this?  If we're going to do this, I'd like to do it this week.  I really want to get the first release out by Friday (seriously this time).

Les
--
View this message in context: http://www.nabble.com/AuthenticationToken-Principal-clean-up-t1016241c13668.html#a2635900
Sent from the Developer forum at Nabble.com.

[JSecurity-Developer] Re: AuthenticationToken / Principal clean up

[jhaile (s. by Nabble.com) <li...@na...>]

Well, I remember looking at removing the Principal interface when I was changing the AuthorizationContext to support multiple principals, and I remember something about it made me unsure of whether I thought it was a good thing or not.  For example, I think some of our logging printed out the principal of the authorization context, etc. - so there is some nice things about having an interface.

I don't really have any strong feelings either way.  It is nice that there is some type-safety, but at the same time they don't add all that much.  Feel free to try removing them, but if you see anything that convinces you that they do have some value, feel free to leave them in as well.
--
View this message in context: http://www.nabble.com/AuthenticationToken-Principal-clean-up-t1016241c13668.html#a2639516
Sent from the Developer forum at Nabble.com.