Re: [Jsdsi-devel] CertStore Branch

[Sean R. <sra...@ae...>]

Guys,

Done more work on the CertStore branch:

1. jsdsi.certstore.InMemoryCertificateDAO A MultiMap implemenation of 
jsdsi.certstore.CertificateDAO.
2. Fully implemented (with unit tests), a JDBC implementation of 
CertificatedDAO (jsdsi.certstore.jdbc.JdbcCertificateDAO)
3. A extension to CertificateDAO that I presume is needed for an 
LDAPCertificateDAO implementation in jsdsi.certstore.ldap package.
4. Moved jsdsi.MultiMap to jsdsi.util package and made it 'public'.
5. Various code tidy-up and documentation.

I haven't changed JsdsiCertStoreException to be checked... I thought we 
had agreed back April time to use RuntimeExceptions. I've gone more and 
more off Checked Exceptions. Have a read here for other (well known 
peoples' views):

http://www.artima.com/intv/handcuffs.html

http://www.mindview.net/Etc/Discussions/CheckedExceptions


Sameer,

>- There's a misspelled file: jsdsi.JsdiRuntimeException (there's also
>the correctly-spelled version)
>  
>
There sure is, but it is deprecated for the very reason that it is spelt 
wrong.

>In JdbcCertificateDAO.retrieve(), extract the long if-else chain into
>a method that does:
>return retrieve.(...);
>- in each if-branch.  This makes the code easier to read, since it's
>clear "result" is only assigned to once in retrieve().
>  
>
Sorry, but not sure I understand what you mean by this. If you mean to 
not assign to 'result' but just return, then you loose the logging 
information.


Let me know what you think. Regards,

Sean

-- 
Dr. Sean Radford, MBBS, MSc
sra...@ae...
http://www.aegeus-technology.com/