Re: [Fwd: [Jsdsi-devel] Re: [Fwd: Branch-algo]]
Status: Pre-Alpha
Brought to you by:
sajma
From: Sean R. <sra...@ae...> - 2004-10-17 22:02:01
|
Sameer Ajmani wrote: >Sean, > >I took a look through the diff between branch and head: >cvs diff -N -u -r HEAD -r branch-algo > >Your changes look good, but there has been a fair bid of code cleanup >sinc eyou branched (so there's a lot in HEAD that ought to be kept). >Also, since 1.5 offers enums as a language feature, it makes sense to >represent algos with 1.5 enums. > >Here's what I suggest: rather than doign a traditional merge of your >branch into the mainline, consider reimplementing your algo stuff >using 1.5 enums in the mainline, just using your branched code as a >guide.. That way, you'll preserve all the recent changes and get a >chance to make the algo stuff as clean as it can be. > >Thanks for the contribution -- it looks good! >Sameer > >On Sun, 17 Oct 2004 17:38:47 +0100, Sean Radford ><sra...@ae...> wrote: > > >>-- >>Dr. Sean Radford, MBBS, MSc >>sra...@ae... >>http://www.aegeus-technology.com/ >> >> >> >>---------- Forwarded message ---------- >>From: Sean Radford <sra...@ae...> >>To: Sameer Ajmani <aj...@gm...>, jsdsi devel <jsd...@li...> >>Date: Fri, 13 Aug 2004 14:44:24 +0100 >>Subject: [Jsdsi-devel] Re: [Fwd: Branch-algo] >>Sameer Ajmani wrote: >> >> >> >>>Sameer Ajmani wrote: >>> >>> Can you tell me how to check out that branch? I'll be out of town >>>next week, but I'll check it out when I get the chance. >>> >>>Sameer >>> >>> >>> >>> >>> >>Sorry, but looks like I didn't get round to answering this one... >> >>Take a look at: >> >>https://www.cvshome.org/docs/manual/cvs-1.11.17/cvs_5.html#SEC57 >> >>(the branch is called 'branch-algo') >> >>Sean >> >> >> If the consensus is to move to 1.5 then that seems the sensible thing to do. -- Dr. Sean Radford, MBBS, MSc sra...@ae... http://www.aegeus-technology.com/ |