From: Timothy J. H. <tim...@ma...> - 2004-05-20 02:30:10
|
On May 19, 2004, at 6:45 PM, Ken Anderson wrote: > Yes, The original code didn't worry about interfaces. But Tim added > them. My idea was to put things in the "jscheme" package that were not likely to change (e.g. the jscheme.REPL.java class) and to refrain from directly using anything in jsint since those classes were more likely to change (as in fact we have just done in refactoring Scheme.java using Toby's Evaluator class). My preference would be to keep continue this separation.... long-lived features go into jscheme classes, features likely to change go into jsint with some simple interface in jscheme. > > But we never followed through with it. We need to define > SchemeEvaluator to have all the abstract methods we need in Evaluator > and then use SchemeEvaluator everywhere except where we new an > Evaluator. > > Actually lets reverse that. Evaluator is an interface, or abstract > class, and jsint.EvaluatorImpl is the implementation. Yes. In that case, we could move parts of Evaluator into jscheme. > > Some days, i just miss Common Lisp. Some day, I think a descendant of LISP and Java will be the dominant programming language (and maybe Jscheme will play a role in that evolution....) > k > At 10:25 AM 5/20/2004 +1200, Toby Allsopp wrote: >> On Wed, May 19, 2004 at 06:15:28PM -0400, Ken Anderson wrote: >>> I don't think SchemeEvaluator is pulling it's weight. It has no >>> methods and the only thing it really does is cause a runtime coersion >>> in JS. >>> >>> I'd just change things to use Evaluator for now, though we could make >>> Evaluator abstract and use jsint.EvaluatorImpl. >> >> Agreed, it serves no useful purpose presently. I put it there to >> avoid >> exposing jsint classes in the interface of jscheme.JS, which seemed to >> be the general pattern, You're right, that is the general pattern... >> and I couldn't think of any useful methods to >> expose at that level. >> >> Toby. >> >> P.S. Thanks for accepting my changes, it really makes my life a lot >> easier! What applications are you working on that require (or call for....) these changes? ---Tim--- > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle > 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click > _______________________________________________ > Jscheme-user mailing list > Jsc...@li... > https://lists.sourceforge.net/lists/listinfo/jscheme-user |