From: Ken A. <kan...@bb...> - 2004-05-19 22:45:46
|
Yes, The original code didn't worry about interfaces. But Tim added them. But we never followed through with it. We need to define SchemeEvaluator to have all the abstract methods we need in Evaluator and then use SchemeEvaluator everywhere except where we new an Evaluator. Actually lets reverse that. Evaluator is an interface, or abstract class, and jsint.EvaluatorImpl is the implementation. Some days, i just miss Common Lisp. k At 10:25 AM 5/20/2004 +1200, Toby Allsopp wrote: >On Wed, May 19, 2004 at 06:15:28PM -0400, Ken Anderson wrote: >> I don't think SchemeEvaluator is pulling it's weight. It has no >> methods and the only thing it really does is cause a runtime coersion >> in JS. >> >> I'd just change things to use Evaluator for now, though we could make >> Evaluator abstract and use jsint.EvaluatorImpl. > >Agreed, it serves no useful purpose presently. I put it there to avoid >exposing jsint classes in the interface of jscheme.JS, which seemed to >be the general pattern, and I couldn't think of any useful methods to >expose at that level. > >Toby. > >P.S. Thanks for accepting my changes, it really makes my life a lot >easier! |