Conversion.isInt() is slow and allocates unnecessarily

Read Cobol data files in Java

Status: Beta

Brought to you by: bruce_a_martin

#6 Conversion.isInt() is slow and allocates unnecessarily

Milestone: Next_Release_(example)

Status: closed

Owner: Bruce Martin

Labels: performance (1)

Priority: 1

Updated: 2017-11-01

Created: 2015-08-29

Creator: Nick Briggs

Private: No

Noticed, as we started to parse a few million records, that it was spending a lot of time in Conversion.isInt().
Turns out that it was mostly creating BigIntegers and handling exceptions when it failed.
The attached patch should speed that up, while reducing the allocation.
You're free to use it as is, or modify as you see fit.

1 Attachments

patch-isInt-speedup.diff

Discussion

Bruce Martin - 2015-08-29

Thanks for that, I have applied it to my code base.

There are a lot of performance improvements that could be made.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Bruce Martin - 2015-09-25

assigned_to: Bruce Martin
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Bruce Martin - 2015-09-25

Released as part of 0.80.8f

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Bruce Martin - 2016-01-04

This has been fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Bruce Martin - 2016-01-04

status: open --> pending
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Bruce Martin - 2017-11-01

status: pending --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous