Re: [Jpim-devel] Re: next release of jpim

[Dieter W. <di...@wi...>]

Frederick,


>proxy pattern to hide the object tree behind a single
>simple contact object

Actually this "pattern" is more likely called "Facade".
>
>
>Trying to play around a bit with your code... I was wondering if it
>would be possible to use Tony's gui dialog directly in Columba,
>without using a jar file. This would mean that you would allow me
>to use the gui-sources and change their license in the Columba
>sourcetree to MPL (I would of course add a statement where it comes 
>from, too).
>What do you think?

Well, technically speaking there are two possibilities:
1. Tony releases the code aditionally under MPL
2. Releasing the code under MPL does not violate the conditions of 
the BSD style license (i.e. at least one way compatibility).

>First of all the model has seemed to chang, it was necessary
>to replace some stuff with Iterators to make it compile.

Correct, I have been warning about this in my posts. Basically all 
1-n relationships with a preferred item have changed. (Address, 
EmailAddress, PhoneNumber).
The preferred item is now remembered in the Associator; the 
collections have changed from indexed (they are not naturally indexed 
by a number anyway) to unordered collections of unique identifiable 
items.

Related to this changes I have made some adjustments in the backend 
(specifically to the ItemHandler interface and all implementing 
classes).

>Then it openened up the dialog correctly, I was able to
>save it do disc. My test.csv file looks perfectly.
>But when trying to load it fails with the following
>exception:
>
>net.wimpi.pim.util.versitio.versitException: Mandatory tokens missing.
>	at 
>net.wimpi.pim.util.versitio.versitParser.validateCard(Unknown Source)
>	at 
>net.wimpi.pim.util.versitio.versitParser.bundleObjects(Unknown 
>Source)
>	at net.wimpi.pim.util.versitio.versitParser.parse(Unknown Source)
>	at 
>net.wimpi.pim.contact.io.vcard.vCardUnmarshaller.parseStream(Unknown 
>Source)
>	at 
>net.wimpi.pim.contact.io.vcard.vCardUnmarshaller.unmarshallContacts(Unknown 
>Source)
>	at 
>net.wimpi.pim.contact.io.vcard.vCardUnmarshaller.unmarshallContact(Unknown 
>Source)

Hmm, this Exception is thrown if mandatory items are missing from the vCard.
These items are
versitToken.N, versitToken.FN for v3.0 vCards,
as well as
versitToken.N for v2.1 vCards.

Probably these are missing?

>here's a patch fixing some import statements necessary to make the
>gui parts compile correctly. I also replaced some for-loops to
>usage of iterators as that seemed to be changed in the model.
>If you need the patch in another format contact me.

I see about this asap. The patch format prefered is the one from the 
jakarta guidelines.
See
http://jwma.sourceforge.net/development/guidelines.html#source/patches

Did not have time yet to take care for translating this one also to 
jpim documentation yet.
As it looks for the moment, I will release the package whether or not 
I find time to make a lot of documentation....


Regards,
Dieter