Re: [Jpim-devel] Re: jpim's gui

[Stig T. <st...@eu...>]

Hey

> I was away for a few weeks, and i dont have lots of free time at the =
moment, due to militaty service :( so its up to you and Dieter to =
improve jpim, and i would recommend that you get cvs access on jpim, =
work on it, and use it as a library (jpim.jar) in your project. You =
could teach us a few things but also learn a few things if you join the =
development team.

I dont really have time. I said in another mail to this list, that u can =
use my changes if u find them good. But I am reluctant to join another =
project. My experience is I simply dont work on it coz im to hung up =
with my own project. Furthermore, as u will notice from reading the last =
mails, I have done changes to the model, and I cant use jpim as a =
libary. Or at least not the code from ur cvs. Coz I have made changes to =
it, and I will continue to do so when I need it.=20

I am willing to help u change ur code though, regarding my changes, if u =
find some of it (for example the gui) helpfull.=20

>=20
> 1. AddressBook
>=20
> I guess mailsomenthing will need an AddressBook to hold the vCards. =
Columba (another e-mail client written in java columba.sf.net ) will use =
the jpim library as soon as we make a release. They already have an =
Addressbook (that needs some work) and someone has volunteered to put =
some work into it. If you don't have an AddressBook, maybe we could all =
collaborate. We could ask columba people to donate their AddressBook =
code to jpim (and i believe they will). Then we could work on it =
(columba people, jpim people, and mailsomething people) so all 3 =
projects start sharing some good code, and make an excellent AddressBook =
that uses vCards.

I think its a good thing, collaborating, and as I see it, my discussions =
with Dieter is allready some form of collaborating - exchanging ideas =
and views on things. Maybe we dont aggree on everything, but to me that =
discussion has been helpfull.=20

If u read the last correspondance to this list I think its clear that I =
allready have done a 'ContactBook'. AddressBook is to me different, that =
is a list of MailAddresses. I have allready done that and are currently =
working on synchronization with an imap (contact)-mailbox. I am not sure =
its worth collaborating (using same code) doing this...  kinda depends =
on the projects. My 'contact-list' is very simply. I think we could =
collaborate on for example stuff like synchronization. But, my =
synchronization is basicly done through my own mailmodel, and then it =
kinda gets unuseable for columba. But I dont mind discussing and helping =
eachother. Some weeks ago I tested columba (by the way) and I got some =
error when connecting to my imap account that made it totally unusable. =
I posted a bug at their site, but as I know noone have responded.=20

> I did not like refactoring. That could be personal taste, but i tried =
to have the gui code use the same formatting as the code of the model.

Well. When I realized I needed to make some changes to the model, and =
that Dieter wasnt interested in changes in his model, I placed to code =
at mailsomething cvs - I work on the code several places, and it gives =
me a bit of trouble if I cant get the changed code. When I did that I =
thought - well, then I can just as well refactor etc. I use eclipse, and =
I am very glad with the format of eclipse=B4s refactoring.=20

>=20
> Using com.Ostermiller.util for example in Utils was a good thing. =
However you mixed GPL code (Ostermiller's code) with BSD code (jpim's =
code) and that is not a good thing. You should instead try to use it as =
a library. I had the same issued with JCalendar, and Dieter pointed me =
the correct way...

Please explain to me why that is a problem? I dont understand that. =
Firstly ostermillers code doesnt exist in a jar, not when I found it. =
Secondly, as I allready mentioned, I cannot use urs as a jar. I could =
jar it myself, in its own jar, and then keep it seperate when =
distributing my app, but I dont think that is very good, since if u at =
some point upload a jar at the jpim project, people might think the jar =
I am distributing with my project (with ur model and some changes) is =
the same.=20

I ofcourse intent to mention all used libaries/projects in the credits. =
And their different licenses. As for licenses I am a bit confused with =
jpim. I found some license at ur cvs, and it didnt looked like the bsd =
license (I read the bsd license before I decided to build my contacts =
upon ur model).=20

By the way. I did another change to ur gui code which u might be =
interested in - the 'Main' class initialized the Filechooser for loading =
vcard when intializing the code. Only problem with that is, that the =
JFileChooser is SLOW loading. After I changed that I got the startup of =
ur tabbedpane (in a frame) down to 0,7 seconds on my computer, compared =
to the 3,5 secs it took with ur current code.=20

Stig