#3 Half-page scrolling and viewport dragging

[Jonathan Eisenstein]

I did some work to add support for space jumping a bit down the page (or to the next page if you're already at the bottom), and the ability to drag the image around to change what's visible. This doesn't get rid of the horizontal-scrollwheel problem, but gives a nice little quick substitute. I've never done a patch before, so hopefully this is formatted correctly.

[Jonathan Eisenstein]

Patch for scrolling enhancements

[Thomas Aglassinger]

Logged In: YES
user_id=421066
Originator: NO

Thanks! I'll look into it once 0.9.27 is released.

[Thomas Aglassinger]

Logged In: YES
user_id=421066
Originator: NO

Starting to look into it.

[Thomas Aglassinger]

Cleaned up patch with resource leak and formatting fixed

[Thomas Aglassinger]

Logged In: YES
user_id=421066
Originator: NO

I tried to apply it and identified the following issues:

- The scrolling only works vertically, there is no horizontal scrolling.
- Because the new functionality listens for the left mouse button to pressed, the mouse navigation feature ceases to work. Come to think of it, mouse navigation could need some rework anyway, but for now I rather keep it working.
- There is a minor resource leak, the MouseListener does not get removed. I fixed this by adding the remove to dispose().

For now, I'm not going to apply this patch. However, the functionality is very welcome, so it should show up in a later version. Probably after bug 1827855, Error: Problem occurs when computing a tile by the owner, is fixed.
File Added: patch_cleaned_up.txt

[Jonathan Eisenstein]

Logged In: YES
user_id=157951
Originator: YES

The horizontal scrolling is apparently added to Apple's Java in 1.6 (likely Leopard-only). As for the mouse navigation, I couldn't replicate an issue, but I'm on a laptop without an external mouse, and couldn't get backwards-navigation to work in the first place.