Thread: [Jolie-devel] Fwd: [jolie:code] [r3303] - mwallnoefer2: http parsing - some small code improvements
A service-oriented programming language.
Brought to you by:
fmontesi
From: Fabrizio M. <fam...@gm...> - 2015-03-14 18:20:50
|
Hi Matthias, Just a quick check up question: are you sure that this will not affect content containing \r without \n (which can happen AFAIK)? I guess not, right, as we do not use the Scanner for the content parsing. - Fabrizio ---------- Forwarded message ---------- From: Repository Jolie code <no...@co...> Date: Sat, Mar 14, 2015 at 7:15 PM Subject: [jolie:code] [r3303] - mwallnoefer2: http parsing - some small code improvements which I separately commit before the UTF-8 parsing To: Repository Jolie code <no...@co...> http parsing - some small code improvements which I separately commit before the UTF-8 parsing http://sourceforge.net/p/jolie/code/3303/ ------------------------------ Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/jolie/code/ To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ |
From: Matthias D. W. <mat...@ya...> - 2015-03-14 19:44:52
Attachments:
chunks.diff
|
Fabrizio, this implements now the complete HTTP chunks syntax as explained in http://tools.ietf.org/html/rfc2616#section-3.6.1. We were missing some important points like the additional HTTP headers (= trailer) or the chunk parameters. I have tested it with the Jolie website and it definitely works. Now we should be one step further to the UTF-8 parsing of header components, but I will retry keeping the scanner as it is (non UTF-8) otherwise, when introducing the InputStreamReader, this gets messed up and I did not manage to find a fix since the reader intercepts the stream. Cheers, Matthias Matthias Dieter Wallnöfer schrieb: > As far as I see in the code we are *only* using it for header parsing, > since the content parsing is handled directly with a low-level > InputStream.read(). > > Matthias > > Fabrizio Montesi schrieb: >> Hi Matthias, >> >> Just a quick check up question: are you sure that this will not affect >> content containing \r without \n (which can happen AFAIK)? I guess not, >> right, as we do not use the Scanner for the content parsing. >> >> - Fabrizio >> >> ---------- Forwarded message ---------- >> From: *Repository Jolie code* <no...@co... >> <mailto:no...@co...>> >> Date: Sat, Mar 14, 2015 at 7:15 PM >> Subject: [jolie:code] [r3303] - mwallnoefer2: http parsing - some small >> code improvements which I separately commit before the UTF-8 parsing >> To: Repository Jolie code <no...@co... >> <mailto:no...@co...>> >> >> >> http parsing - some small code improvements which I separately commit >> before the UTF-8 parsing http://sourceforge.net/p/jolie/code/3303/ >> <http://sourceforge.net/p/jolie/code/3303> >> >> ------------------------------------------------------------------------ >> >> Sent from sourceforge.net <http://sourceforge.net> because you indicated >> interest in https://sourceforge.net/p/jolie/code/ >> <https://sourceforge.net/p/jolie/code> >> >> To unsubscribe from further messages, please visit >> https://sourceforge.net/auth/subscriptions/ >> <https://sourceforge.net/auth/subscriptions> >> >> >> >> >> ------------------------------------------------------------------------------ >> Dive into the World of Parallel Programming The Go Parallel Website, sponsored >> by Intel and developed in partnership with Slashdot Media, is your hub for all >> things parallel software development, from weekly thought leadership blogs to >> news, videos, case studies, tutorials and more. Take a look and join the >> conversation now. http://goparallel.sourceforge.net/ >> >> >> >> _______________________________________________ >> Jolie-devel mailing list >> Jol...@li... >> https://lists.sourceforge.net/lists/listinfo/jolie-devel >> > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > https://lists.sourceforge.net/lists/listinfo/jolie-devel > |
From: Matthias D. W. <mat...@ya...> - 2015-03-14 18:44:34
|
As far as I see in the code we are *only* using it for header parsing, since the content parsing is handled directly with a low-level InputStream.read(). Matthias Fabrizio Montesi schrieb: > Hi Matthias, > > Just a quick check up question: are you sure that this will not affect > content containing \r without \n (which can happen AFAIK)? I guess not, > right, as we do not use the Scanner for the content parsing. > > - Fabrizio > > ---------- Forwarded message ---------- > From: *Repository Jolie code* <no...@co... > <mailto:no...@co...>> > Date: Sat, Mar 14, 2015 at 7:15 PM > Subject: [jolie:code] [r3303] - mwallnoefer2: http parsing - some small > code improvements which I separately commit before the UTF-8 parsing > To: Repository Jolie code <no...@co... > <mailto:no...@co...>> > > > http parsing - some small code improvements which I separately commit > before the UTF-8 parsing http://sourceforge.net/p/jolie/code/3303/ > <http://sourceforge.net/p/jolie/code/3303> > > ------------------------------------------------------------------------ > > Sent from sourceforge.net <http://sourceforge.net> because you indicated > interest in https://sourceforge.net/p/jolie/code/ > <https://sourceforge.net/p/jolie/code> > > To unsubscribe from further messages, please visit > https://sourceforge.net/auth/subscriptions/ > <https://sourceforge.net/auth/subscriptions> > > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > > > > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > https://lists.sourceforge.net/lists/listinfo/jolie-devel > |
From: Fabrizio M. <fam...@gm...> - 2015-03-14 20:06:30
|
Cool! Can you briefly explain the difference in words wrt what we were doing before? We need to comment this code I think, chunk processing is a bit complex. Ciao, F On Sat, Mar 14, 2015 at 8:44 PM, Matthias Dieter Wallnöfer < mat...@ya...> wrote: > Fabrizio, > > this implements now the complete HTTP chunks syntax as explained in > http://tools.ietf.org/html/rfc2616#section-3.6.1. We were missing some > important points like the additional HTTP headers (= trailer) or the > chunk parameters. > > I have tested it with the Jolie website and it definitely works. > > Now we should be one step further to the UTF-8 parsing of header > components, but I will retry keeping the scanner as it is (non UTF-8) > otherwise, when introducing the InputStreamReader, this gets messed up > and I did not manage to find a fix since the reader intercepts the stream. > > Cheers, > Matthias > > Matthias Dieter Wallnöfer schrieb: > > As far as I see in the code we are *only* using it for header parsing, > > since the content parsing is handled directly with a low-level > > InputStream.read(). > > > > Matthias > > > > Fabrizio Montesi schrieb: > >> Hi Matthias, > >> > >> Just a quick check up question: are you sure that this will not affect > >> content containing \r without \n (which can happen AFAIK)? I guess not, > >> right, as we do not use the Scanner for the content parsing. > >> > >> - Fabrizio > >> > >> ---------- Forwarded message ---------- > >> From: *Repository Jolie code* <no...@co... > >> <mailto:no...@co...>> > >> Date: Sat, Mar 14, 2015 at 7:15 PM > >> Subject: [jolie:code] [r3303] - mwallnoefer2: http parsing - some small > >> code improvements which I separately commit before the UTF-8 parsing > >> To: Repository Jolie code <no...@co... > >> <mailto:no...@co...>> > >> > >> > >> http parsing - some small code improvements which I separately commit > >> before the UTF-8 parsing http://sourceforge.net/p/jolie/code/3303/ > >> <http://sourceforge.net/p/jolie/code/3303> > >> > >> ------------------------------------------------------------------------ > >> > >> Sent from sourceforge.net <http://sourceforge.net> because you > indicated > >> interest in https://sourceforge.net/p/jolie/code/ > >> <https://sourceforge.net/p/jolie/code> > >> > >> To unsubscribe from further messages, please visit > >> https://sourceforge.net/auth/subscriptions/ > >> <https://sourceforge.net/auth/subscriptions> > >> > >> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Dive into the World of Parallel Programming The Go Parallel Website, > sponsored > >> by Intel and developed in partnership with Slashdot Media, is your hub > for all > >> things parallel software development, from weekly thought leadership > blogs to > >> news, videos, case studies, tutorials and more. Take a look and join the > >> conversation now. http://goparallel.sourceforge.net/ > >> > >> > >> > >> _______________________________________________ > >> Jolie-devel mailing list > >> Jol...@li... > >> https://lists.sourceforge.net/lists/listinfo/jolie-devel > >> > > > > > > > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming The Go Parallel Website, > sponsored > > by Intel and developed in partnership with Slashdot Media, is your hub > for all > > things parallel software development, from weekly thought leadership > blogs to > > news, videos, case studies, tutorials and more. Take a look and join the > > conversation now. http://goparallel.sourceforge.net/ > > _______________________________________________ > > Jolie-devel mailing list > > Jol...@li... > > https://lists.sourceforge.net/lists/listinfo/jolie-devel > > > > |
From: Matthias D. W. <mat...@ya...> - 2015-03-14 20:24:12
|
Okay, I will comment it better. Fabrizio Montesi schrieb: > Cool! Can you briefly explain the difference in words wrt what we were > doing before? We need to comment this code I think, chunk processing is > a bit complex. > > Ciao, > F > > On Sat, Mar 14, 2015 at 8:44 PM, Matthias Dieter Wallnöfer > <mat...@ya... <mailto:mat...@ya...>> wrote: > > Fabrizio, > > this implements now the complete HTTP chunks syntax as explained in > http://tools.ietf.org/html/rfc2616#section-3.6.1. We were missing some > important points like the additional HTTP headers (= trailer) or the > chunk parameters. > > I have tested it with the Jolie website and it definitely works. > > Now we should be one step further to the UTF-8 parsing of header > components, but I will retry keeping the scanner as it is (non UTF-8) > otherwise, when introducing the InputStreamReader, this gets messed up > and I did not manage to find a fix since the reader intercepts the > stream. > > Cheers, > Matthias > > Matthias Dieter Wallnöfer schrieb: > > As far as I see in the code we are *only* using it for header parsing, > > since the content parsing is handled directly with a low-level > > InputStream.read(). > > > > Matthias > > > > Fabrizio Montesi schrieb: > >> Hi Matthias, > >> > >> Just a quick check up question: are you sure that this will not > affect > >> content containing \r without \n (which can happen AFAIK)? I > guess not, > >> right, as we do not use the Scanner for the content parsing. > >> > >> - Fabrizio > >> > >> ---------- Forwarded message ---------- > >> From: *Repository Jolie code* <no...@co... > <mailto:no...@co...> > >> <mailto:no...@co... > <mailto:no...@co...>>> > >> Date: Sat, Mar 14, 2015 at 7:15 PM > >> Subject: [jolie:code] [r3303] - mwallnoefer2: http parsing - some > small > >> code improvements which I separately commit before the UTF-8 parsing > >> To: Repository Jolie code <no...@co... > <mailto:no...@co...> > >> <mailto:no...@co... > <mailto:no...@co...>>> > >> > >> > >> http parsing - some small code improvements which I separately commit > >> before the UTF-8 parsing http://sourceforge.net/p/jolie/code/3303/ > >> <http://sourceforge.net/p/jolie/code/3303> > >> > >> > ------------------------------------------------------------------------ > >> > >> Sent from sourceforge.net <http://sourceforge.net> > <http://sourceforge.net> because you indicated > >> interest in https://sourceforge.net/p/jolie/code/ > >> <https://sourceforge.net/p/jolie/code> > >> > >> To unsubscribe from further messages, please visit > >> https://sourceforge.net/auth/subscriptions/ > >> <https://sourceforge.net/auth/subscriptions> > >> > >> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Dive into the World of Parallel Programming The Go Parallel > Website, sponsored > >> by Intel and developed in partnership with Slashdot Media, is > your hub for all > >> things parallel software development, from weekly thought > leadership blogs to > >> news, videos, case studies, tutorials and more. Take a look and > join the > >> conversation now. http://goparallel.sourceforge.net/ > >> > >> > >> > >> _______________________________________________ > >> Jolie-devel mailing list > >> Jol...@li... > <mailto:Jol...@li...> > >> https://lists.sourceforge.net/lists/listinfo/jolie-devel > >> > > > > > > > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming The Go Parallel > Website, sponsored > > by Intel and developed in partnership with Slashdot Media, is your > hub for all > > things parallel software development, from weekly thought > leadership blogs to > > news, videos, case studies, tutorials and more. Take a look and > join the > > conversation now. http://goparallel.sourceforge.net/ > > _______________________________________________ > > Jolie-devel mailing list > > Jol...@li... > <mailto:Jol...@li...> > > https://lists.sourceforge.net/lists/listinfo/jolie-devel > > > > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > > > > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > https://lists.sourceforge.net/lists/listinfo/jolie-devel > |