Thread: [Jolie-devel] wsdl2jolie patches
A service-oriented programming language.
Brought to you by:
fmontesi
Menu
▾
▴
jolie-devel
|
From: Matthias D. W. <mwa...@ya...> - 2013-11-20 11:36:30
|
Hi Fabrizio, when dealing with another webservice I ran into some issues using wsdl2jolie. Address: http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL - At the moment the tool suppresses undefined complex types. This does not work out with the SOAP call "GetWeatherInformation()" - since then it is missing its input argument datatype - When the same call is run by other methods (eg. HTTP) it has some kind of empty input type associated. At the moment the tool prints a declaration like: > GetWeatherInformation()(ArrayOfWeatherDescription) which is denied by Jolie. With a slight change I get a "void" type: > GetWeatherInformation(void)(ArrayOfWeatherDescription) Cheers, Matthias |
|
From: Fabrizio M. <fam...@gm...> - 2013-11-20 11:42:57
|
Hi Matthias, yes, the problem is that complex types in general go out of the types supported by Jolie (since they are not structured, afaik). However, we can certainly work out some cases that we can support in our types. For example, an empty complex type corresponds to a void as you point out. When we are dealing with an unsupported type (as you encountered) we should throw an exception though... it's better than outputting something incorrect. Or, even better, when we find out something that we do not know how to deal with we should print "undefined" as type. Could I see your modification? Cheers, Fabrizio. On Wed, Nov 20, 2013 at 12:36 PM, Matthias Dieter Wallnöfer <mwa...@ya...> wrote: > Hi Fabrizio, > > when dealing with another webservice I ran into some issues using > wsdl2jolie. > > Address: http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL > > - At the moment the tool suppresses undefined complex types. This does not > work out with the SOAP call "GetWeatherInformation()" - since then it is > missing its input argument datatype > - When the same call is run by other methods (eg. HTTP) it has some kind of > empty input type associated. At the moment the tool prints a declaration > like: >> >> GetWeatherInformation()(ArrayOfWeatherDescription) > > which is denied by Jolie. With a slight change I get a "void" type: >> >> GetWeatherInformation(void)(ArrayOfWeatherDescription) > > > Cheers, > Matthias |
|
From: Claudio G. <cg...@it...> - 2013-11-20 12:16:51
|
Hi All, I think that in this particular case we could assume that an element like: <s:element name="GetWeatherInformation"><s:complexType/></s:element> could be considered as a void in Jolie. -------------------------------------------------------------- Claudio Guidi Ph.D. italianaSoftware s.r.l. via Coralli, 66 - 40026 Imola (BO), Italy http://www.italianasoftware.com/ http://www.jolie-lang.org Phone: +39 0542 788201 Mobile: +39 347 0694065 Fax: +39 0542 628048 -------------------------------------------------------------- Nota di riservatezza: Il presente messaggio, corredato dei relativi allegati, contiene informazioni da considerarsi strettamente riservate, ed è destinato esclusivamente al destinatario sopra indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è severamente proibito, ed è pregato di rinviarlo immediatamente al mittente distruggendone l'originale. Grazie per la collaborazione. 2013/11/20 Fabrizio Montesi <fam...@gm...> > Hi Matthias, > yes, the problem is that complex types in general go out of the types > supported by Jolie (since they are not structured, afaik). However, we > can certainly work out some cases that we can support in our types. > For example, an empty complex type corresponds to a void as you point > out. > > When we are dealing with an unsupported type (as you encountered) we > should throw an exception though... it's better than outputting > something incorrect. > Or, even better, when we find out something that we do not know how to > deal with we should print "undefined" as type. > > Could I see your modification? > > Cheers, > Fabrizio. > > On Wed, Nov 20, 2013 at 12:36 PM, Matthias Dieter Wallnöfer > <mwa...@ya...> wrote: > > Hi Fabrizio, > > > > when dealing with another webservice I ran into some issues using > > wsdl2jolie. > > > > Address: http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL > > > > - At the moment the tool suppresses undefined complex types. This does > not > > work out with the SOAP call "GetWeatherInformation()" - since then it is > > missing its input argument datatype > > - When the same call is run by other methods (eg. HTTP) it has some kind > of > > empty input type associated. At the moment the tool prints a declaration > > like: > >> > >> GetWeatherInformation()(ArrayOfWeatherDescription) > > > > which is denied by Jolie. With a slight change I get a "void" type: > >> > >> GetWeatherInformation(void)(ArrayOfWeatherDescription) > > > > > > Cheers, > > Matthias > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up > now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > https://lists.sourceforge.net/lists/listinfo/jolie-devel > |
|
From: Matthias D. W. <mwa...@ya...> - 2013-11-20 12:52:58
Attachments:
jolie_webservices.patch
|
Sorry :-), Matthias Claudio Guidi schrieb: > Hi All, > > I think that in this particular case we could assume that an element like: > > <s:element name="GetWeatherInformation"><s:complexType/></s:element> > > could be considered as a void in Jolie. > > > > -------------------------------------------------------------- > Claudio Guidi Ph.D. > italianaSoftware s.r.l. > via Coralli, 66 - 40026 Imola (BO), Italy > http://www.italianasoftware.com/ > http://www.jolie-lang.org <http://www.jolie-lang.org/> > Phone: +39 0542 788201 > Mobile: +39 347 0694065 > Fax: +39 0542 628048 > -------------------------------------------------------------- > > Nota di riservatezza: Il presente messaggio, corredato dei > relativi allegati, contiene informazioni da considerarsi strettamente > riservate, ed è destinato esclusivamente al destinatario sopra > indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto > la propria responsabilità,diffonderlo. Chiunque ricevesse questo > messaggio per errore o comunque lo leggesse senza esserne legittimato > è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a > persone diverse dal destinatario è severamente proibito, ed è pregato > di rinviarlo immediatamente al mittente distruggendone l'originale. > > Grazie per la collaborazione. > > > 2013/11/20 Fabrizio Montesi <fam...@gm... > <mailto:fam...@gm...>> > > Hi Matthias, > yes, the problem is that complex types in general go out of the types > supported by Jolie (since they are not structured, afaik). However, we > can certainly work out some cases that we can support in our types. > For example, an empty complex type corresponds to a void as you point > out. > > When we are dealing with an unsupported type (as you encountered) we > should throw an exception though... it's better than outputting > something incorrect. > Or, even better, when we find out something that we do not know how to > deal with we should print "undefined" as type. > > Could I see your modification? > > Cheers, > Fabrizio. > > On Wed, Nov 20, 2013 at 12:36 PM, Matthias Dieter Wallnöfer > <mwa...@ya... <mailto:mwa...@ya...>> wrote: > > Hi Fabrizio, > > > > when dealing with another webservice I ran into some issues using > > wsdl2jolie. > > > > Address: http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL > > > > - At the moment the tool suppresses undefined complex types. > This does not > > work out with the SOAP call "GetWeatherInformation()" - since > then it is > > missing its input argument datatype > > - When the same call is run by other methods (eg. HTTP) it has > some kind of > > empty input type associated. At the moment the tool prints a > declaration > > like: > >> > >> GetWeatherInformation()(ArrayOfWeatherDescription) > > > > which is denied by Jolie. With a slight change I get a "void" type: > >> > >> GetWeatherInformation(void)(ArrayOfWeatherDescription) > > > > > > Cheers, > > Matthias > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech > innovation. > Intel(R) Software Adrenaline delivers strategic insight and > game-changing > conversations that shape the rapidly evolving mobile landscape. > Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > <mailto:Jol...@li...> > https://lists.sourceforge.net/lists/listinfo/jolie-devel > > |
|
From: Matthias D. W. <mwa...@ya...> - 2013-11-22 13:37:21
Attachments:
jolie_webservices.patch
|
So what do you think about this patch? Cheers, Matthias Matthias Dieter Wallnöfer schrieb: > Sorry :-), > > Matthias > > Claudio Guidi schrieb: >> Hi All, >> >> I think that in this particular case we could assume that an element >> like: >> >> <s:element name="GetWeatherInformation"><s:complexType/></s:element> >> >> could be considered as a void in Jolie. >> >> >> >> -------------------------------------------------------------- >> Claudio Guidi Ph.D. >> italianaSoftware s.r.l. >> via Coralli, 66 - 40026 Imola (BO), Italy >> http://www.italianasoftware.com/ >> http://www.jolie-lang.org <http://www.jolie-lang.org/> >> Phone: +39 0542 788201 >> Mobile: +39 347 0694065 >> Fax: +39 0542 628048 >> -------------------------------------------------------------- >> >> Nota di riservatezza: Il presente messaggio, corredato dei relativi >> allegati, contiene informazioni da considerarsi strettamente >> riservate, ed è destinato esclusivamente al destinatario sopra >> indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto >> la propria responsabilità,diffonderlo. Chiunque ricevesse questo >> messaggio per errore o comunque lo leggesse senza esserne legittimato >> è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a >> persone diverse dal destinatario è severamente proibito, ed è pregato >> di rinviarlo immediatamente al mittente distruggendone l'originale. >> >> Grazie per la collaborazione. >> >> >> 2013/11/20 Fabrizio Montesi <fam...@gm... >> <mailto:fam...@gm...>> >> >> Hi Matthias, >> yes, the problem is that complex types in general go out of the >> types >> supported by Jolie (since they are not structured, afaik). >> However, we >> can certainly work out some cases that we can support in our types. >> For example, an empty complex type corresponds to a void as you >> point >> out. >> >> When we are dealing with an unsupported type (as you encountered) we >> should throw an exception though... it's better than outputting >> something incorrect. >> Or, even better, when we find out something that we do not know >> how to >> deal with we should print "undefined" as type. >> >> Could I see your modification? >> >> Cheers, >> Fabrizio. >> >> On Wed, Nov 20, 2013 at 12:36 PM, Matthias Dieter Wallnöfer >> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >> > Hi Fabrizio, >> > >> > when dealing with another webservice I ran into some issues using >> > wsdl2jolie. >> > >> > Address: http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL >> > >> > - At the moment the tool suppresses undefined complex types. >> This does not >> > work out with the SOAP call "GetWeatherInformation()" - since >> then it is >> > missing its input argument datatype >> > - When the same call is run by other methods (eg. HTTP) it has >> some kind of >> > empty input type associated. At the moment the tool prints a >> declaration >> > like: >> >> >> >> GetWeatherInformation()(ArrayOfWeatherDescription) >> > >> > which is denied by Jolie. With a slight change I get a "void" >> type: >> >> >> >> GetWeatherInformation(void)(ArrayOfWeatherDescription) >> > >> > >> > Cheers, >> > Matthias >> >> ------------------------------------------------------------------------------ >> Shape the Mobile Experience: Free Subscription >> Software experts and developers: Be at the forefront of tech >> innovation. >> Intel(R) Software Adrenaline delivers strategic insight and >> game-changing >> conversations that shape the rapidly evolving mobile landscape. >> Sign up now. >> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >> _______________________________________________ >> Jolie-devel mailing list >> Jol...@li... >> <mailto:Jol...@li...> >> https://lists.sourceforge.net/lists/listinfo/jolie-devel >> >> > > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > > > _______________________________________________ > Jolie-devel mailing list > Jol...@li... > https://lists.sourceforge.net/lists/listinfo/jolie-devel |
|
From: Fabrizio M. <fam...@gm...> - 2013-11-25 08:40:32
|
Hi all, I'm trying to see why that line has been commented... especially since it has been commented without leaving any other comment explaining the reason in the code. Claudio, any memories? :-) I see it's commented out in many parts of the code. Cheers, Fabrizio. |
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-04 16:50:23
|
Any news on this one (and also on the Exception thing: Re: [Jolie-devel] OneWay messages)? Matthias Fabrizio Montesi schrieb: > Hi all, > I'm trying to see why that line has been commented... especially since > it has been commented without leaving any other comment explaining the > reason in the code. Claudio, any memories? :-) > > I see it's commented out in many parts of the code. > > > Cheers, > Fabrizio. |
|
From: Fabrizio M. <fam...@gm...> - 2013-12-09 18:22:33
|
Hi all, @Claudio: do you have any info on that line? Cheers, Fabrizio. On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer <mwa...@ya...> wrote: > Any news on this one (and also on the Exception thing: Re: [Jolie-devel] > OneWay messages)? > > Matthias > > Fabrizio Montesi schrieb: > >> Hi all, >> I'm trying to see why that line has been commented... especially since >> it has been commented without leaving any other comment explaining the >> reason in the code. Claudio, any memories? :-) >> >> I see it's commented out in many parts of the code. >> >> >> Cheers, >> Fabrizio. > > |
|
From: Claudio G. <cg...@it...> - 2013-12-10 08:43:24
|
Hi all, sorry for the delay. Do you mean this line? jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) ); If I remember well it was commented because, otherwise, you will find type undefined: undefined into the generated interface. -------------------------------------------------------------- Claudio Guidi Ph.D. italianaSoftware s.r.l. via Coralli, 66 - 40026 Imola (BO), Italy http://www.italianasoftware.com/ http://www.jolie-lang.org Phone: +39 0542 788201 Mobile: +39 347 0694065 Fax: +39 0542 628048 -------------------------------------------------------------- Nota di riservatezza: Il presente messaggio, corredato dei relativi allegati, contiene informazioni da considerarsi strettamente riservate, ed è destinato esclusivamente al destinatario sopra indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è severamente proibito, ed è pregato di rinviarlo immediatamente al mittente distruggendone l'originale. Grazie per la collaborazione. 2013/12/9 Fabrizio Montesi <fam...@gm...> > Hi all, > > @Claudio: do you have any info on that line? > > Cheers, > Fabrizio. > > On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer > <mwa...@ya...> wrote: > > Any news on this one (and also on the Exception thing: Re: [Jolie-devel] > > OneWay messages)? > > > > Matthias > > > > Fabrizio Montesi schrieb: > > > >> Hi all, > >> I'm trying to see why that line has been commented... especially since > >> it has been commented without leaving any other comment explaining the > >> reason in the code. Claudio, any memories? :-) > >> > >> I see it's commented out in many parts of the code. > >> > >> > >> Cheers, > >> Fabrizio. > > > > > |
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-10 16:11:12
|
Hi all, not really correct. It generates types like "type <name>:undefined", for instance in my case: > type GetWeatherInformation:undefined So this is required in some cases. Cheers, Matthias Claudio Guidi schrieb: > Hi all, > > sorry for the delay. > > Do you mean this line? > > jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) ); > > If I remember well it was commented because, otherwise, you will find > > type undefined: undefined > > into the generated interface. > > > > -------------------------------------------------------------- > Claudio Guidi Ph.D. > italianaSoftware s.r.l. > via Coralli, 66 - 40026 Imola (BO), Italy > http://www.italianasoftware.com/ > http://www.jolie-lang.org <http://www.jolie-lang.org/> > Phone: +39 0542 788201 > Mobile: +39 347 0694065 > Fax: +39 0542 628048 > -------------------------------------------------------------- > > Nota di riservatezza: Il presente messaggio, corredato dei > relativi allegati, contiene informazioni da considerarsi strettamente > riservate, ed è destinato esclusivamente al destinatario sopra > indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto > la propria responsabilità,diffonderlo. Chiunque ricevesse questo > messaggio per errore o comunque lo leggesse senza esserne legittimato > è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a > persone diverse dal destinatario è severamente proibito, ed è pregato > di rinviarlo immediatamente al mittente distruggendone l'originale. > > Grazie per la collaborazione. > > > 2013/12/9 Fabrizio Montesi <fam...@gm... > <mailto:fam...@gm...>> > > Hi all, > > @Claudio: do you have any info on that line? > > Cheers, > Fabrizio. > > On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer > <mwa...@ya... <mailto:mwa...@ya...>> wrote: > > Any news on this one (and also on the Exception thing: Re: > [Jolie-devel] > > OneWay messages)? > > > > Matthias > > > > Fabrizio Montesi schrieb: > > > >> Hi all, > >> I'm trying to see why that line has been commented... > especially since > >> it has been commented without leaving any other comment > explaining the > >> reason in the code. Claudio, any memories? :-) > >> > >> I see it's commented out in many parts of the code. > >> > >> > >> Cheers, > >> Fabrizio. > > > > > > |
|
From: Fabrizio M. <fam...@gm...> - 2013-12-10 16:32:10
|
Mmh... a possible solution could be that we add a check that verifies whether we're creating a type with the same name of a predefined type in Jolie (in which case we should not create the type) or not (in which case we should create the type). What do you think? If this can work, the systematic way of doing it would be to have some constant set or enum defined somewhere which contains the names of all predefined types (I think we can reuse some predefined map from the parser). - Fabrizio On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer <mwa...@ya...> wrote: > Hi all, > > not really correct. It generates types like "type <name>:undefined", for > instance in my case: >> >> type GetWeatherInformation:undefined > > So this is required in some cases. > > Cheers, > Matthias > > Claudio Guidi schrieb: >> >> Hi all, >> >> sorry for the delay. >> >> Do you mean this line? >> >> jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) ); >> >> If I remember well it was commented because, otherwise, you will find >> >> type undefined: undefined >> >> into the generated interface. >> >> >> >> -------------------------------------------------------------- >> Claudio Guidi Ph.D. >> italianaSoftware s.r.l. >> via Coralli, 66 - 40026 Imola (BO), Italy >> http://www.italianasoftware.com/ >> http://www.jolie-lang.org <http://www.jolie-lang.org/> >> >> Phone: +39 0542 788201 >> Mobile: +39 347 0694065 >> Fax: +39 0542 628048 >> -------------------------------------------------------------- >> >> Nota di riservatezza: Il presente messaggio, corredato dei relativi >> allegati, contiene informazioni da considerarsi strettamente riservate, ed è >> destinato esclusivamente al destinatario sopra indicato, il quale è l'unico >> autorizzato ad usarlo, copiarlo e, sotto la propria >> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o >> comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo, >> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è >> severamente proibito, ed è pregato di rinviarlo immediatamente al mittente >> distruggendone l'originale. >> >> Grazie per la collaborazione. >> >> >> 2013/12/9 Fabrizio Montesi <fam...@gm... >> <mailto:fam...@gm...>> >> >> >> Hi all, >> >> @Claudio: do you have any info on that line? >> >> Cheers, >> Fabrizio. >> >> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >> > Any news on this one (and also on the Exception thing: Re: >> [Jolie-devel] >> > OneWay messages)? >> > >> > Matthias >> > >> > Fabrizio Montesi schrieb: >> > >> >> Hi all, >> >> I'm trying to see why that line has been commented... >> especially since >> >> it has been commented without leaving any other comment >> explaining the >> >> reason in the code. Claudio, any memories? :-) >> >> >> >> I see it's commented out in many parts of the code. >> >> >> >> >> >> Cheers, >> >> Fabrizio. >> > >> > >> >> > |
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-10 16:55:56
|
Hi Fabrizio, did I get your point? You think that declarations as > type GetWeatherInformation:undefined should be omitted and all "GetWeatherInformation" appearances immediately be substituted by "undefined"? Btw. in the WSDL file it is declared like this (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): > <s:element name="GetWeatherInformation"><s:complexType/></s:element> So to be honest I do not see an issue to include it in Jolie's header as well. The right thing would be to change the webservice to not include empty complex types! Matthias Fabrizio Montesi schrieb: > Mmh... a possible solution could be that we add a check that verifies > whether we're creating a type with the same name of a predefined type > in Jolie (in which case we should not create the type) or not (in > which case we should create the type). > > What do you think? > > If this can work, the systematic way of doing it would be to have some > constant set or enum defined somewhere which contains the names of all > predefined types (I think we can reuse some predefined map from the > parser). > > - Fabrizio > > On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer > <mwa...@ya...> wrote: >> Hi all, >> >> not really correct. It generates types like "type <name>:undefined", for >> instance in my case: >>> type GetWeatherInformation:undefined >> So this is required in some cases. >> >> Cheers, >> Matthias >> >> Claudio Guidi schrieb: >>> Hi all, >>> >>> sorry for the delay. >>> >>> Do you mean this line? >>> >>> jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) ); >>> >>> If I remember well it was commented because, otherwise, you will find >>> >>> type undefined: undefined >>> >>> into the generated interface. >>> >>> >>> >>> -------------------------------------------------------------- >>> Claudio Guidi Ph.D. >>> italianaSoftware s.r.l. >>> via Coralli, 66 - 40026 Imola (BO), Italy >>> http://www.italianasoftware.com/ >>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >>> >>> Phone: +39 0542 788201 >>> Mobile: +39 347 0694065 >>> Fax: +39 0542 628048 >>> -------------------------------------------------------------- >>> >>> Nota di riservatezza: Il presente messaggio, corredato dei relativi >>> allegati, contiene informazioni da considerarsi strettamente riservate, ed è >>> destinato esclusivamente al destinatario sopra indicato, il quale è l'unico >>> autorizzato ad usarlo, copiarlo e, sotto la propria >>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o >>> comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo, >>> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è >>> severamente proibito, ed è pregato di rinviarlo immediatamente al mittente >>> distruggendone l'originale. >>> >>> Grazie per la collaborazione. >>> >>> >>> 2013/12/9 Fabrizio Montesi <fam...@gm... >>> <mailto:fam...@gm...>> >>> >>> >>> Hi all, >>> >>> @Claudio: do you have any info on that line? >>> >>> Cheers, >>> Fabrizio. >>> >>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >>> > Any news on this one (and also on the Exception thing: Re: >>> [Jolie-devel] >>> > OneWay messages)? >>> > >>> > Matthias >>> > >>> > Fabrizio Montesi schrieb: >>> > >>> >> Hi all, >>> >> I'm trying to see why that line has been commented... >>> especially since >>> >> it has been commented without leaving any other comment >>> explaining the >>> >> reason in the code. Claudio, any memories? :-) >>> >> >>> >> I see it's commented out in many parts of the code. >>> >> >>> >> >>> >> Cheers, >>> >> Fabrizio. >>> > >>> > >>> >>> |
|
From: Fabrizio M. <fam...@gm...> - 2013-12-10 17:46:34
|
No, I mean that your type should be generated: type GetWeatherInformation:undefined whereas the following should not be generated: type undefined:undefined by implementing some check on the name of the type we are generating, to avoid redefining undefined. The latter is our main problem (@Claudio: right?). Ciao, Fabrizio. On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer <mwa...@ya...> wrote: > Hi Fabrizio, > > did I get your point? > > You think that declarations as >> >> type GetWeatherInformation:undefined > > should be omitted and all "GetWeatherInformation" appearances immediately be > substituted by "undefined"? > > Btw. in the WSDL file it is declared like this > (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): > >> <s:element name="GetWeatherInformation"><s:complexType/></s:element> > > So to be honest I do not see an issue to include it in Jolie's header as > well. The right thing would be to change the webservice to not include empty > complex types! > > Matthias > > Fabrizio Montesi schrieb: > >> Mmh... a possible solution could be that we add a check that verifies >> whether we're creating a type with the same name of a predefined type >> in Jolie (in which case we should not create the type) or not (in >> which case we should create the type). >> >> What do you think? >> >> If this can work, the systematic way of doing it would be to have some >> constant set or enum defined somewhere which contains the names of all >> predefined types (I think we can reuse some predefined map from the >> parser). >> >> - Fabrizio >> >> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer >> <mwa...@ya...> wrote: >>> >>> Hi all, >>> >>> not really correct. It generates types like "type <name>:undefined", for >>> instance in my case: >>>> >>>> type GetWeatherInformation:undefined >>> >>> So this is required in some cases. >>> >>> Cheers, >>> Matthias >>> >>> Claudio Guidi schrieb: >>>> >>>> Hi all, >>>> >>>> sorry for the delay. >>>> >>>> Do you mean this line? >>>> >>>> jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) >>>> ); >>>> >>>> If I remember well it was commented because, otherwise, you will find >>>> >>>> type undefined: undefined >>>> >>>> into the generated interface. >>>> >>>> >>>> >>>> -------------------------------------------------------------- >>>> Claudio Guidi Ph.D. >>>> italianaSoftware s.r.l. >>>> via Coralli, 66 - 40026 Imola (BO), Italy >>>> http://www.italianasoftware.com/ >>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >>>> >>>> Phone: +39 0542 788201 >>>> Mobile: +39 347 0694065 >>>> Fax: +39 0542 628048 >>>> -------------------------------------------------------------- >>>> >>>> Nota di riservatezza: Il presente messaggio, corredato dei relativi >>>> allegati, contiene informazioni da considerarsi strettamente riservate, >>>> ed è >>>> destinato esclusivamente al destinatario sopra indicato, il quale è >>>> l'unico >>>> autorizzato ad usarlo, copiarlo e, sotto la propria >>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per >>>> errore o >>>> comunque lo leggesse senza esserne legittimato è avvertito che >>>> trattenerlo, >>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è >>>> severamente proibito, ed è pregato di rinviarlo immediatamente al >>>> mittente >>>> distruggendone l'originale. >>>> >>>> Grazie per la collaborazione. >>>> >>>> >>>> 2013/12/9 Fabrizio Montesi <fam...@gm... >>>> <mailto:fam...@gm...>> >>>> >>>> >>>> Hi all, >>>> >>>> @Claudio: do you have any info on that line? >>>> >>>> Cheers, >>>> Fabrizio. >>>> >>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >>>> > Any news on this one (and also on the Exception thing: Re: >>>> [Jolie-devel] >>>> > OneWay messages)? >>>> > >>>> > Matthias >>>> > >>>> > Fabrizio Montesi schrieb: >>>> > >>>> >> Hi all, >>>> >> I'm trying to see why that line has been commented... >>>> especially since >>>> >> it has been commented without leaving any other comment >>>> explaining the >>>> >> reason in the code. Claudio, any memories? :-) >>>> >> >>>> >> I see it's commented out in many parts of the code. >>>> >> >>>> >> >>>> >> Cheers, >>>> >> Fabrizio. >>>> > >>>> > >>>> >>>> > |
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-10 18:07:23
|
We should try to understand where and why the generation of > type undefined:undefined happened. Just to make sure - I did not get it in my case (when un-commenting this particular codeline). Matthias Fabrizio Montesi schrieb: > No, I mean that your type should be generated: > > type GetWeatherInformation:undefined > > whereas the following should not be generated: > > type undefined:undefined > > > by implementing some check on the name of the type we are generating, > to avoid redefining undefined. The latter is our main problem > (@Claudio: right?). > > > > Ciao, > Fabrizio. > > On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer > <mwa...@ya...> wrote: >> Hi Fabrizio, >> >> did I get your point? >> >> You think that declarations as >>> type GetWeatherInformation:undefined >> should be omitted and all "GetWeatherInformation" appearances immediately be >> substituted by "undefined"? >> >> Btw. in the WSDL file it is declared like this >> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): >> >>> <s:element name="GetWeatherInformation"><s:complexType/></s:element> >> So to be honest I do not see an issue to include it in Jolie's header as >> well. The right thing would be to change the webservice to not include empty >> complex types! >> >> Matthias >> >> Fabrizio Montesi schrieb: >> >>> Mmh... a possible solution could be that we add a check that verifies >>> whether we're creating a type with the same name of a predefined type >>> in Jolie (in which case we should not create the type) or not (in >>> which case we should create the type). >>> >>> What do you think? >>> >>> If this can work, the systematic way of doing it would be to have some >>> constant set or enum defined somewhere which contains the names of all >>> predefined types (I think we can reuse some predefined map from the >>> parser). >>> >>> - Fabrizio >>> >>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer >>> <mwa...@ya...> wrote: >>>> Hi all, >>>> >>>> not really correct. It generates types like "type <name>:undefined", for >>>> instance in my case: >>>>> type GetWeatherInformation:undefined >>>> So this is required in some cases. >>>> >>>> Cheers, >>>> Matthias >>>> >>>> Claudio Guidi schrieb: >>>>> Hi all, >>>>> >>>>> sorry for the delay. >>>>> >>>>> Do you mean this line? >>>>> >>>>> jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) >>>>> ); >>>>> >>>>> If I remember well it was commented because, otherwise, you will find >>>>> >>>>> type undefined: undefined >>>>> >>>>> into the generated interface. >>>>> >>>>> >>>>> >>>>> -------------------------------------------------------------- >>>>> Claudio Guidi Ph.D. >>>>> italianaSoftware s.r.l. >>>>> via Coralli, 66 - 40026 Imola (BO), Italy >>>>> http://www.italianasoftware.com/ >>>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >>>>> >>>>> Phone: +39 0542 788201 >>>>> Mobile: +39 347 0694065 >>>>> Fax: +39 0542 628048 >>>>> -------------------------------------------------------------- >>>>> >>>>> Nota di riservatezza: Il presente messaggio, corredato dei relativi >>>>> allegati, contiene informazioni da considerarsi strettamente riservate, >>>>> ed è >>>>> destinato esclusivamente al destinatario sopra indicato, il quale è >>>>> l'unico >>>>> autorizzato ad usarlo, copiarlo e, sotto la propria >>>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per >>>>> errore o >>>>> comunque lo leggesse senza esserne legittimato è avvertito che >>>>> trattenerlo, >>>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è >>>>> severamente proibito, ed è pregato di rinviarlo immediatamente al >>>>> mittente >>>>> distruggendone l'originale. >>>>> >>>>> Grazie per la collaborazione. >>>>> >>>>> >>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... >>>>> <mailto:fam...@gm...>> >>>>> >>>>> >>>>> Hi all, >>>>> >>>>> @Claudio: do you have any info on that line? >>>>> >>>>> Cheers, >>>>> Fabrizio. >>>>> >>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >>>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >>>>> > Any news on this one (and also on the Exception thing: Re: >>>>> [Jolie-devel] >>>>> > OneWay messages)? >>>>> > >>>>> > Matthias >>>>> > >>>>> > Fabrizio Montesi schrieb: >>>>> > >>>>> >> Hi all, >>>>> >> I'm trying to see why that line has been commented... >>>>> especially since >>>>> >> it has been commented without leaving any other comment >>>>> explaining the >>>>> >> reason in the code. Claudio, any memories? :-) >>>>> >> >>>>> >> I see it's commented out in many parts of the code. >>>>> >> >>>>> >> >>>>> >> Cheers, >>>>> >> Fabrizio. >>>>> > >>>>> > >>>>> >>>>> |
|
From: Fabrizio M. <fam...@gm...> - 2013-12-10 19:00:17
|
Claudio, do you have an example for raising that error? - Fabrizio On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer <mwa...@ya...> wrote: > We should try to understand where and why the generation of >> >> type undefined:undefined > > happened. > > Just to make sure - I did not get it in my case (when un-commenting this > particular codeline). > > Matthias > > Fabrizio Montesi schrieb: > >> No, I mean that your type should be generated: >> >> type GetWeatherInformation:undefined >> >> whereas the following should not be generated: >> >> type undefined:undefined >> >> >> by implementing some check on the name of the type we are generating, >> to avoid redefining undefined. The latter is our main problem >> (@Claudio: right?). >> >> >> >> Ciao, >> Fabrizio. >> >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer >> <mwa...@ya...> wrote: >>> >>> Hi Fabrizio, >>> >>> did I get your point? >>> >>> You think that declarations as >>>> >>>> type GetWeatherInformation:undefined >>> >>> should be omitted and all "GetWeatherInformation" appearances immediately >>> be >>> substituted by "undefined"? >>> >>> Btw. in the WSDL file it is declared like this >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): >>> >>>> <s:element name="GetWeatherInformation"><s:complexType/></s:element> >>> >>> So to be honest I do not see an issue to include it in Jolie's header as >>> well. The right thing would be to change the webservice to not include >>> empty >>> complex types! >>> >>> Matthias >>> >>> Fabrizio Montesi schrieb: >>> >>>> Mmh... a possible solution could be that we add a check that verifies >>>> whether we're creating a type with the same name of a predefined type >>>> in Jolie (in which case we should not create the type) or not (in >>>> which case we should create the type). >>>> >>>> What do you think? >>>> >>>> If this can work, the systematic way of doing it would be to have some >>>> constant set or enum defined somewhere which contains the names of all >>>> predefined types (I think we can reuse some predefined map from the >>>> parser). >>>> >>>> - Fabrizio >>>> >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer >>>> <mwa...@ya...> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> not really correct. It generates types like "type <name>:undefined", >>>>> for >>>>> instance in my case: >>>>>> >>>>>> type GetWeatherInformation:undefined >>>>> >>>>> So this is required in some cases. >>>>> >>>>> Cheers, >>>>> Matthias >>>>> >>>>> Claudio Guidi schrieb: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> sorry for the delay. >>>>>> >>>>>> Do you mean this line? >>>>>> >>>>>> jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) >>>>>> ); >>>>>> >>>>>> If I remember well it was commented because, otherwise, you will find >>>>>> >>>>>> type undefined: undefined >>>>>> >>>>>> into the generated interface. >>>>>> >>>>>> >>>>>> >>>>>> -------------------------------------------------------------- >>>>>> Claudio Guidi Ph.D. >>>>>> italianaSoftware s.r.l. >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy >>>>>> http://www.italianasoftware.com/ >>>>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >>>>>> >>>>>> Phone: +39 0542 788201 >>>>>> Mobile: +39 347 0694065 >>>>>> Fax: +39 0542 628048 >>>>>> -------------------------------------------------------------- >>>>>> >>>>>> Nota di riservatezza: Il presente messaggio, corredato dei relativi >>>>>> allegati, contiene informazioni da considerarsi strettamente >>>>>> riservate, >>>>>> ed è >>>>>> destinato esclusivamente al destinatario sopra indicato, il quale è >>>>>> l'unico >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria >>>>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per >>>>>> errore o >>>>>> comunque lo leggesse senza esserne legittimato è avvertito che >>>>>> trattenerlo, >>>>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è >>>>>> severamente proibito, ed è pregato di rinviarlo immediatamente al >>>>>> mittente >>>>>> distruggendone l'originale. >>>>>> >>>>>> Grazie per la collaborazione. >>>>>> >>>>>> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... >>>>>> <mailto:fam...@gm...>> >>>>>> >>>>>> >>>>>> Hi all, >>>>>> >>>>>> @Claudio: do you have any info on that line? >>>>>> >>>>>> Cheers, >>>>>> Fabrizio. >>>>>> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >>>>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >>>>>> > Any news on this one (and also on the Exception thing: Re: >>>>>> [Jolie-devel] >>>>>> > OneWay messages)? >>>>>> > >>>>>> > Matthias >>>>>> > >>>>>> > Fabrizio Montesi schrieb: >>>>>> > >>>>>> >> Hi all, >>>>>> >> I'm trying to see why that line has been commented... >>>>>> especially since >>>>>> >> it has been commented without leaving any other comment >>>>>> explaining the >>>>>> >> reason in the code. Claudio, any memories? :-) >>>>>> >> >>>>>> >> I see it's commented out in many parts of the code. >>>>>> >> >>>>>> >> >>>>>> >> Cheers, >>>>>> >> Fabrizio. >>>>>> > >>>>>> > >>>>>> >>>>>> > |
|
From: Claudio G. <cg...@it...> - 2013-12-10 19:12:19
|
If you give me some days I'll try to check the code with some complex wsdl. Il 10/dic/2013 20:00 "Fabrizio Montesi" <fam...@gm...> ha scritto: > Claudio, do you have an example for raising that error? > > - Fabrizio > > On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer > <mwa...@ya...> wrote: > > We should try to understand where and why the generation of > >> > >> type undefined:undefined > > > > happened. > > > > Just to make sure - I did not get it in my case (when un-commenting this > > particular codeline). > > > > Matthias > > > > Fabrizio Montesi schrieb: > > > >> No, I mean that your type should be generated: > >> > >> type GetWeatherInformation:undefined > >> > >> whereas the following should not be generated: > >> > >> type undefined:undefined > >> > >> > >> by implementing some check on the name of the type we are generating, > >> to avoid redefining undefined. The latter is our main problem > >> (@Claudio: right?). > >> > >> > >> > >> Ciao, > >> Fabrizio. > >> > >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer > >> <mwa...@ya...> wrote: > >>> > >>> Hi Fabrizio, > >>> > >>> did I get your point? > >>> > >>> You think that declarations as > >>>> > >>>> type GetWeatherInformation:undefined > >>> > >>> should be omitted and all "GetWeatherInformation" appearances > immediately > >>> be > >>> substituted by "undefined"? > >>> > >>> Btw. in the WSDL file it is declared like this > >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): > >>> > >>>> <s:element name="GetWeatherInformation"><s:complexType/></s:element> > >>> > >>> So to be honest I do not see an issue to include it in Jolie's header > as > >>> well. The right thing would be to change the webservice to not include > >>> empty > >>> complex types! > >>> > >>> Matthias > >>> > >>> Fabrizio Montesi schrieb: > >>> > >>>> Mmh... a possible solution could be that we add a check that verifies > >>>> whether we're creating a type with the same name of a predefined type > >>>> in Jolie (in which case we should not create the type) or not (in > >>>> which case we should create the type). > >>>> > >>>> What do you think? > >>>> > >>>> If this can work, the systematic way of doing it would be to have some > >>>> constant set or enum defined somewhere which contains the names of all > >>>> predefined types (I think we can reuse some predefined map from the > >>>> parser). > >>>> > >>>> - Fabrizio > >>>> > >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer > >>>> <mwa...@ya...> wrote: > >>>>> > >>>>> Hi all, > >>>>> > >>>>> not really correct. It generates types like "type <name>:undefined", > >>>>> for > >>>>> instance in my case: > >>>>>> > >>>>>> type GetWeatherInformation:undefined > >>>>> > >>>>> So this is required in some cases. > >>>>> > >>>>> Cheers, > >>>>> Matthias > >>>>> > >>>>> Claudio Guidi schrieb: > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> sorry for the delay. > >>>>>> > >>>>>> Do you mean this line? > >>>>>> > >>>>>> jolieTypes.add( createAnyOrUndefined( element.getName(), > complexType ) > >>>>>> ); > >>>>>> > >>>>>> If I remember well it was commented because, otherwise, you will > find > >>>>>> > >>>>>> type undefined: undefined > >>>>>> > >>>>>> into the generated interface. > >>>>>> > >>>>>> > >>>>>> > >>>>>> -------------------------------------------------------------- > >>>>>> Claudio Guidi Ph.D. > >>>>>> italianaSoftware s.r.l. > >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy > >>>>>> http://www.italianasoftware.com/ > >>>>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> > >>>>>> > >>>>>> Phone: +39 0542 788201 > >>>>>> Mobile: +39 347 0694065 > >>>>>> Fax: +39 0542 628048 > >>>>>> -------------------------------------------------------------- > >>>>>> > >>>>>> Nota di riservatezza: Il presente messaggio, corredato dei relativi > >>>>>> allegati, contiene informazioni da considerarsi strettamente > >>>>>> riservate, > >>>>>> ed è > >>>>>> destinato esclusivamente al destinatario sopra indicato, il quale è > >>>>>> l'unico > >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria > >>>>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per > >>>>>> errore o > >>>>>> comunque lo leggesse senza esserne legittimato è avvertito che > >>>>>> trattenerlo, > >>>>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal > destinatario è > >>>>>> severamente proibito, ed è pregato di rinviarlo immediatamente al > >>>>>> mittente > >>>>>> distruggendone l'originale. > >>>>>> > >>>>>> Grazie per la collaborazione. > >>>>>> > >>>>>> > >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... > >>>>>> <mailto:fam...@gm...>> > >>>>>> > >>>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> @Claudio: do you have any info on that line? > >>>>>> > >>>>>> Cheers, > >>>>>> Fabrizio. > >>>>>> > >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer > >>>>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: > >>>>>> > Any news on this one (and also on the Exception thing: Re: > >>>>>> [Jolie-devel] > >>>>>> > OneWay messages)? > >>>>>> > > >>>>>> > Matthias > >>>>>> > > >>>>>> > Fabrizio Montesi schrieb: > >>>>>> > > >>>>>> >> Hi all, > >>>>>> >> I'm trying to see why that line has been commented... > >>>>>> especially since > >>>>>> >> it has been commented without leaving any other comment > >>>>>> explaining the > >>>>>> >> reason in the code. Claudio, any memories? :-) > >>>>>> >> > >>>>>> >> I see it's commented out in many parts of the code. > >>>>>> >> > >>>>>> >> > >>>>>> >> Cheers, > >>>>>> >> Fabrizio. > >>>>>> > > >>>>>> > > >>>>>> > >>>>>> > > > |
|
From: Fabrizio M. <fam...@gm...> - 2013-12-10 22:23:48
|
That'd be great. We should also think about adding them to the test suite somehow.. Sent from my phone. On Dec 10, 2013 8:12 PM, "Claudio Guidi" <cg...@it...> wrote: > If you give me some days I'll try to check the code with some complex wsdl. > Il 10/dic/2013 20:00 "Fabrizio Montesi" <fam...@gm...> ha scritto: > >> Claudio, do you have an example for raising that error? >> >> - Fabrizio >> >> On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer >> <mwa...@ya...> wrote: >> > We should try to understand where and why the generation of >> >> >> >> type undefined:undefined >> > >> > happened. >> > >> > Just to make sure - I did not get it in my case (when un-commenting this >> > particular codeline). >> > >> > Matthias >> > >> > Fabrizio Montesi schrieb: >> > >> >> No, I mean that your type should be generated: >> >> >> >> type GetWeatherInformation:undefined >> >> >> >> whereas the following should not be generated: >> >> >> >> type undefined:undefined >> >> >> >> >> >> by implementing some check on the name of the type we are generating, >> >> to avoid redefining undefined. The latter is our main problem >> >> (@Claudio: right?). >> >> >> >> >> >> >> >> Ciao, >> >> Fabrizio. >> >> >> >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer >> >> <mwa...@ya...> wrote: >> >>> >> >>> Hi Fabrizio, >> >>> >> >>> did I get your point? >> >>> >> >>> You think that declarations as >> >>>> >> >>>> type GetWeatherInformation:undefined >> >>> >> >>> should be omitted and all "GetWeatherInformation" appearances >> immediately >> >>> be >> >>> substituted by "undefined"? >> >>> >> >>> Btw. in the WSDL file it is declared like this >> >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): >> >>> >> >>>> <s:element name="GetWeatherInformation"><s:complexType/></s:element> >> >>> >> >>> So to be honest I do not see an issue to include it in Jolie's header >> as >> >>> well. The right thing would be to change the webservice to not include >> >>> empty >> >>> complex types! >> >>> >> >>> Matthias >> >>> >> >>> Fabrizio Montesi schrieb: >> >>> >> >>>> Mmh... a possible solution could be that we add a check that verifies >> >>>> whether we're creating a type with the same name of a predefined type >> >>>> in Jolie (in which case we should not create the type) or not (in >> >>>> which case we should create the type). >> >>>> >> >>>> What do you think? >> >>>> >> >>>> If this can work, the systematic way of doing it would be to have >> some >> >>>> constant set or enum defined somewhere which contains the names of >> all >> >>>> predefined types (I think we can reuse some predefined map from the >> >>>> parser). >> >>>> >> >>>> - Fabrizio >> >>>> >> >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer >> >>>> <mwa...@ya...> wrote: >> >>>>> >> >>>>> Hi all, >> >>>>> >> >>>>> not really correct. It generates types like "type <name>:undefined", >> >>>>> for >> >>>>> instance in my case: >> >>>>>> >> >>>>>> type GetWeatherInformation:undefined >> >>>>> >> >>>>> So this is required in some cases. >> >>>>> >> >>>>> Cheers, >> >>>>> Matthias >> >>>>> >> >>>>> Claudio Guidi schrieb: >> >>>>>> >> >>>>>> Hi all, >> >>>>>> >> >>>>>> sorry for the delay. >> >>>>>> >> >>>>>> Do you mean this line? >> >>>>>> >> >>>>>> jolieTypes.add( createAnyOrUndefined( element.getName(), >> complexType ) >> >>>>>> ); >> >>>>>> >> >>>>>> If I remember well it was commented because, otherwise, you will >> find >> >>>>>> >> >>>>>> type undefined: undefined >> >>>>>> >> >>>>>> into the generated interface. >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> -------------------------------------------------------------- >> >>>>>> Claudio Guidi Ph.D. >> >>>>>> italianaSoftware s.r.l. >> >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy >> >>>>>> http://www.italianasoftware.com/ >> >>>>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >> >>>>>> >> >>>>>> Phone: +39 0542 788201 >> >>>>>> Mobile: +39 347 0694065 >> >>>>>> Fax: +39 0542 628048 >> >>>>>> -------------------------------------------------------------- >> >>>>>> >> >>>>>> Nota di riservatezza: Il presente messaggio, corredato dei relativi >> >>>>>> allegati, contiene informazioni da considerarsi strettamente >> >>>>>> riservate, >> >>>>>> ed è >> >>>>>> destinato esclusivamente al destinatario sopra indicato, il quale è >> >>>>>> l'unico >> >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria >> >>>>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per >> >>>>>> errore o >> >>>>>> comunque lo leggesse senza esserne legittimato è avvertito che >> >>>>>> trattenerlo, >> >>>>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal >> destinatario è >> >>>>>> severamente proibito, ed è pregato di rinviarlo immediatamente al >> >>>>>> mittente >> >>>>>> distruggendone l'originale. >> >>>>>> >> >>>>>> Grazie per la collaborazione. >> >>>>>> >> >>>>>> >> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... >> >>>>>> <mailto:fam...@gm...>> >> >>>>>> >> >>>>>> >> >>>>>> Hi all, >> >>>>>> >> >>>>>> @Claudio: do you have any info on that line? >> >>>>>> >> >>>>>> Cheers, >> >>>>>> Fabrizio. >> >>>>>> >> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >> >>>>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >> >>>>>> > Any news on this one (and also on the Exception thing: Re: >> >>>>>> [Jolie-devel] >> >>>>>> > OneWay messages)? >> >>>>>> > >> >>>>>> > Matthias >> >>>>>> > >> >>>>>> > Fabrizio Montesi schrieb: >> >>>>>> > >> >>>>>> >> Hi all, >> >>>>>> >> I'm trying to see why that line has been commented... >> >>>>>> especially since >> >>>>>> >> it has been commented without leaving any other comment >> >>>>>> explaining the >> >>>>>> >> reason in the code. Claudio, any memories? :-) >> >>>>>> >> >> >>>>>> >> I see it's commented out in many parts of the code. >> >>>>>> >> >> >>>>>> >> >> >>>>>> >> Cheers, >> >>>>>> >> Fabrizio. >> >>>>>> > >> >>>>>> > >> >>>>>> >> >>>>>> >> > >> > |
|
From: Claudio G. <cg...@it...> - 2013-12-12 17:03:13
|
Hi guys, I made some tests with a more complex wsdl. In the following what I found: 1) if a insert the line that Matthias has commented (jolieTypes.add( createAnyOrUndefined( element.getName(), complexType ) );) in the final interface I will found basic types declarations such as type boolean:undefined type string:undefined So far it is not clear to me when exactly happens. I need more time for investigating. Thus, I think we need more test before enabling the patch. new issues!!! 2) XSOMParser seems to not process import tags where schemaLocation is not defined. Ex: <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/"> if you change the line into: <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/" schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/> it wroks. But this is quite annoying because if the wsdl is generated (as in my case) without schemaLocation you always need to download the file,add schemaLocation attributes to all the imports and then launch the wsdl2jolie locally. It's a nightmare! I tried to google the problem but I didn't find anything useful, could you help me to find some fixes? Maybe we need to update the XSOM library? 3) at the present, if the message of an operation contains more than one part, the conversion could fail. Ex: <s:schema targetNamespace="blablabla"> <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/" schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/> <s:complexType name="HomerSimpsons"> some complex content </s:complexContent> </s:complexType> </s:schema> <wsdl:message name="MYMessage"> <wsdl:part name="part1" type="s:string" /> <wsdl:part name="part2" type="s1:HomerSimpsons" /> </wsdl:message> <wsdl:operation name="operationName"> <wsdl:input message="tns:MyMessage" /> <wsdl:output message="tns:AnotherMessage" /> </wsdl:operation> Unfortunately I cannot attach the wsdl file because it is private and protected by copyright. This is a limitation we have so far. -------------------------------------------------------------- Claudio Guidi Ph.D. italianaSoftware s.r.l. via Coralli, 66 - 40026 Imola (BO), Italy http://www.italianasoftware.com/ http://www.jolie-lang.org Phone: +39 0542 788201 Mobile: +39 347 0694065 Fax: +39 0542 628048 -------------------------------------------------------------- Nota di riservatezza: Il presente messaggio, corredato dei relativi allegati, contiene informazioni da considerarsi strettamente riservate, ed è destinato esclusivamente al destinatario sopra indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è severamente proibito, ed è pregato di rinviarlo immediatamente al mittente distruggendone l'originale. Grazie per la collaborazione. 2013/12/10 Fabrizio Montesi <fam...@gm...> > That'd be great. We should also think about adding them to the test suite > somehow.. > > Sent from my phone. > On Dec 10, 2013 8:12 PM, "Claudio Guidi" <cg...@it...> > wrote: > >> If you give me some days I'll try to check the code with some complex >> wsdl. >> Il 10/dic/2013 20:00 "Fabrizio Montesi" <fam...@gm...> ha scritto: >> >>> Claudio, do you have an example for raising that error? >>> >>> - Fabrizio >>> >>> On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer >>> <mwa...@ya...> wrote: >>> > We should try to understand where and why the generation of >>> >> >>> >> type undefined:undefined >>> > >>> > happened. >>> > >>> > Just to make sure - I did not get it in my case (when un-commenting >>> this >>> > particular codeline). >>> > >>> > Matthias >>> > >>> > Fabrizio Montesi schrieb: >>> > >>> >> No, I mean that your type should be generated: >>> >> >>> >> type GetWeatherInformation:undefined >>> >> >>> >> whereas the following should not be generated: >>> >> >>> >> type undefined:undefined >>> >> >>> >> >>> >> by implementing some check on the name of the type we are generating, >>> >> to avoid redefining undefined. The latter is our main problem >>> >> (@Claudio: right?). >>> >> >>> >> >>> >> >>> >> Ciao, >>> >> Fabrizio. >>> >> >>> >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter Wallnöfer >>> >> <mwa...@ya...> wrote: >>> >>> >>> >>> Hi Fabrizio, >>> >>> >>> >>> did I get your point? >>> >>> >>> >>> You think that declarations as >>> >>>> >>> >>>> type GetWeatherInformation:undefined >>> >>> >>> >>> should be omitted and all "GetWeatherInformation" appearances >>> immediately >>> >>> be >>> >>> substituted by "undefined"? >>> >>> >>> >>> Btw. in the WSDL file it is declared like this >>> >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): >>> >>> >>> >>>> <s:element name="GetWeatherInformation"><s:complexType/></s:element> >>> >>> >>> >>> So to be honest I do not see an issue to include it in Jolie's >>> header as >>> >>> well. The right thing would be to change the webservice to not >>> include >>> >>> empty >>> >>> complex types! >>> >>> >>> >>> Matthias >>> >>> >>> >>> Fabrizio Montesi schrieb: >>> >>> >>> >>>> Mmh... a possible solution could be that we add a check that >>> verifies >>> >>>> whether we're creating a type with the same name of a predefined >>> type >>> >>>> in Jolie (in which case we should not create the type) or not (in >>> >>>> which case we should create the type). >>> >>>> >>> >>>> What do you think? >>> >>>> >>> >>>> If this can work, the systematic way of doing it would be to have >>> some >>> >>>> constant set or enum defined somewhere which contains the names of >>> all >>> >>>> predefined types (I think we can reuse some predefined map from the >>> >>>> parser). >>> >>>> >>> >>>> - Fabrizio >>> >>>> >>> >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter Wallnöfer >>> >>>> <mwa...@ya...> wrote: >>> >>>>> >>> >>>>> Hi all, >>> >>>>> >>> >>>>> not really correct. It generates types like "type >>> <name>:undefined", >>> >>>>> for >>> >>>>> instance in my case: >>> >>>>>> >>> >>>>>> type GetWeatherInformation:undefined >>> >>>>> >>> >>>>> So this is required in some cases. >>> >>>>> >>> >>>>> Cheers, >>> >>>>> Matthias >>> >>>>> >>> >>>>> Claudio Guidi schrieb: >>> >>>>>> >>> >>>>>> Hi all, >>> >>>>>> >>> >>>>>> sorry for the delay. >>> >>>>>> >>> >>>>>> Do you mean this line? >>> >>>>>> >>> >>>>>> jolieTypes.add( createAnyOrUndefined( element.getName(), >>> complexType ) >>> >>>>>> ); >>> >>>>>> >>> >>>>>> If I remember well it was commented because, otherwise, you will >>> find >>> >>>>>> >>> >>>>>> type undefined: undefined >>> >>>>>> >>> >>>>>> into the generated interface. >>> >>>>>> >>> >>>>>> >>> >>>>>> >>> >>>>>> -------------------------------------------------------------- >>> >>>>>> Claudio Guidi Ph.D. >>> >>>>>> italianaSoftware s.r.l. >>> >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy >>> >>>>>> http://www.italianasoftware.com/ >>> >>>>>> http://www.jolie-lang.org <http://www.jolie-lang.org/> >>> >>>>>> >>> >>>>>> Phone: +39 0542 788201 >>> >>>>>> Mobile: +39 347 0694065 >>> >>>>>> Fax: +39 0542 628048 >>> >>>>>> -------------------------------------------------------------- >>> >>>>>> >>> >>>>>> Nota di riservatezza: Il presente messaggio, corredato dei >>> relativi >>> >>>>>> allegati, contiene informazioni da considerarsi strettamente >>> >>>>>> riservate, >>> >>>>>> ed è >>> >>>>>> destinato esclusivamente al destinatario sopra indicato, il quale >>> è >>> >>>>>> l'unico >>> >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria >>> >>>>>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio >>> per >>> >>>>>> errore o >>> >>>>>> comunque lo leggesse senza esserne legittimato è avvertito che >>> >>>>>> trattenerlo, >>> >>>>>> copiarlo,divulgarlo, distribuirlo a persone diverse dal >>> destinatario è >>> >>>>>> severamente proibito, ed è pregato di rinviarlo immediatamente al >>> >>>>>> mittente >>> >>>>>> distruggendone l'originale. >>> >>>>>> >>> >>>>>> Grazie per la collaborazione. >>> >>>>>> >>> >>>>>> >>> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... >>> >>>>>> <mailto:fam...@gm...>> >>> >>>>>> >>> >>>>>> >>> >>>>>> Hi all, >>> >>>>>> >>> >>>>>> @Claudio: do you have any info on that line? >>> >>>>>> >>> >>>>>> Cheers, >>> >>>>>> Fabrizio. >>> >>>>>> >>> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias Dieter Wallnöfer >>> >>>>>> <mwa...@ya... <mailto:mwa...@ya...>> wrote: >>> >>>>>> > Any news on this one (and also on the Exception thing: Re: >>> >>>>>> [Jolie-devel] >>> >>>>>> > OneWay messages)? >>> >>>>>> > >>> >>>>>> > Matthias >>> >>>>>> > >>> >>>>>> > Fabrizio Montesi schrieb: >>> >>>>>> > >>> >>>>>> >> Hi all, >>> >>>>>> >> I'm trying to see why that line has been commented... >>> >>>>>> especially since >>> >>>>>> >> it has been commented without leaving any other comment >>> >>>>>> explaining the >>> >>>>>> >> reason in the code. Claudio, any memories? :-) >>> >>>>>> >> >>> >>>>>> >> I see it's commented out in many parts of the code. >>> >>>>>> >> >>> >>>>>> >> >>> >>>>>> >> Cheers, >>> >>>>>> >> Fabrizio. >>> >>>>>> > >>> >>>>>> > >>> >>>>>> >>> >>>>>> >>> > >>> >> |
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-12 18:34:46
|
Hi Claudio,
that's fine, please apply :-).
Matthias
Claudio Guidi schrieb:
> Hi Matthias,
>
> I made some tests and I would patch your patch :-) with the following
> code:
>
> if ( (particle = contentType.asParticle()) == null &&
> !checkSkippedTypes( element.getName(), element.getTargetNamespace() )) {
> jolieTypes.add( createAnyOrUndefined(
> element.getName(), complexType ) );
> continue;
> }
>
> I added && !checkSkippedTypes( element.getName(),
> element.getTargetNamespace() ) which avoid to process basic element types.
>
> So, Matthias could apply the patch with my modifications?
>
> --------------------------------------------------------------
> Claudio Guidi Ph.D.
> italianaSoftware s.r.l.
> via Coralli, 66 - 40026 Imola (BO), Italy
> http://www.italianasoftware.com/
> http://www.jolie-lang.org <http://www.jolie-lang.org/>
> Phone: +39 0542 788201
> Mobile: +39 347 0694065
> Fax: +39 0542 628048
> --------------------------------------------------------------
>
> Nota di riservatezza: Il presente messaggio, corredato dei
> relativi allegati, contiene informazioni da considerarsi strettamente
> riservate, ed è destinato esclusivamente al destinatario sopra
> indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto
> la propria responsabilità,diffonderlo. Chiunque ricevesse questo
> messaggio per errore o comunque lo leggesse senza esserne legittimato
> è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a
> persone diverse dal destinatario è severamente proibito, ed è pregato
> di rinviarlo immediatamente al mittente distruggendone l'originale.
>
> Grazie per la collaborazione.
>
>
> 2013/12/12 Claudio Guidi <cg...@it...
> <mailto:cg...@it...>>
>
> Hi guys,
>
> I made some tests with a more complex wsdl. In the following what
> I found:
>
> 1) if a insert the line that Matthias has commented
> (jolieTypes.add( createAnyOrUndefined( element.getName(),
> complexType ) );) in the final interface I will found basic types
> declarations such as
>
> type boolean:undefined
> type string:undefined
>
> So far it is not clear to me when exactly happens. I need more
> time for investigating.
>
> Thus, I think we need more test before enabling the patch.
>
>
> new issues!!!
> 2) XSOMParser seems to not process import tags where
> schemaLocation is not defined. Ex:
> <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/">
>
> if you change the line into:
> <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/"
> schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/>
> it wroks.
>
> But this is quite annoying because if the wsdl is generated (as in
> my case) without schemaLocation you always need to download the
> file,add schemaLocation attributes to all the imports and then
> launch the wsdl2jolie locally. It's a nightmare!
> I tried to google the problem but I didn't find anything useful,
> could you help me to find some fixes? Maybe we need to update the
> XSOM library?
>
> 3) at the present, if the message of an operation contains more
> than one part, the conversion could fail. Ex:
>
> <s:schema targetNamespace="blablabla">
> <s:import
> namespace="http://schemas.xmlsoap.org/soap/encoding/"
> schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/>
> <s:complexType name="HomerSimpsons">
> some complex content
> </s:complexContent>
> </s:complexType>
> </s:schema>
>
> <wsdl:message name="MYMessage">
> <wsdl:part name="part1" type="s:string" />
> <wsdl:part name="part2" type="s1:HomerSimpsons" />
> </wsdl:message>
>
> <wsdl:operation name="operationName">
> <wsdl:input message="tns:MyMessage" />
> <wsdl:output message="tns:AnotherMessage" />
> </wsdl:operation>
>
> Unfortunately I cannot attach the wsdl file because it is private
> and protected by copyright.
> This is a limitation we have so far.
>
>
>
>
> --------------------------------------------------------------
> Claudio Guidi Ph.D.
> italianaSoftware s.r.l.
> via Coralli, 66 - 40026 Imola (BO), Italy
> http://www.italianasoftware.com/
> http://www.jolie-lang.org <http://www.jolie-lang.org/>
> Phone: +39 0542 788201 <tel:%2B39%200542%20788201>
> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065>
> Fax: +39 0542 628048 <tel:%2B39%200542%20628048>
> --------------------------------------------------------------
>
> Nota di riservatezza: Il presente messaggio, corredato dei
> relativi allegati, contiene informazioni da considerarsi
> strettamente riservate, ed è destinato esclusivamente al
> destinatario sopra indicato, il quale è l'unico autorizzato ad
> usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo.
> Chiunque ricevesse questo messaggio per errore o comunque
> lo leggesse senza esserne legittimato è avvertito che trattenerlo,
> copiarlo,divulgarlo, distribuirlo a persone diverse dal
> destinatario è severamente proibito, ed è pregato di rinviarlo
> immediatamente al mittente distruggendone l'originale.
>
> Grazie per la collaborazione.
>
>
> 2013/12/10 Fabrizio Montesi <fam...@gm...
> <mailto:fam...@gm...>>
>
> That'd be great. We should also think about adding them to the
> test suite somehow..
>
> Sent from my phone.
>
> On Dec 10, 2013 8:12 PM, "Claudio Guidi"
> <cg...@it...
> <mailto:cg...@it...>> wrote:
>
> If you give me some days I'll try to check the code with
> some complex wsdl.
>
> Il 10/dic/2013 20:00 "Fabrizio Montesi"
> <fam...@gm... <mailto:fam...@gm...>> ha scritto:
>
> Claudio, do you have an example for raising that error?
>
> - Fabrizio
>
> On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer
> <mwa...@ya... <mailto:mwa...@ya...>>
> wrote:
> > We should try to understand where and why the
> generation of
> >>
> >> type undefined:undefined
> >
> > happened.
> >
> > Just to make sure - I did not get it in my case
> (when un-commenting this
> > particular codeline).
> >
> > Matthias
> >
> > Fabrizio Montesi schrieb:
> >
> >> No, I mean that your type should be generated:
> >>
> >> type GetWeatherInformation:undefined
> >>
> >> whereas the following should not be generated:
> >>
> >> type undefined:undefined
> >>
> >>
> >> by implementing some check on the name of the type
> we are generating,
> >> to avoid redefining undefined. The latter is our
> main problem
> >> (@Claudio: right?).
> >>
> >>
> >>
> >> Ciao,
> >> Fabrizio.
> >>
> >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter
> Wallnöfer
> >> <mwa...@ya...
> <mailto:mwa...@ya...>> wrote:
> >>>
> >>> Hi Fabrizio,
> >>>
> >>> did I get your point?
> >>>
> >>> You think that declarations as
> >>>>
> >>>> type GetWeatherInformation:undefined
> >>>
> >>> should be omitted and all "GetWeatherInformation"
> appearances immediately
> >>> be
> >>> substituted by "undefined"?
> >>>
> >>> Btw. in the WSDL file it is declared like this
> >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl):
> >>>
> >>>> <s:element
> name="GetWeatherInformation"><s:complexType/></s:element>
> >>>
> >>> So to be honest I do not see an issue to include
> it in Jolie's header as
> >>> well. The right thing would be to change the
> webservice to not include
> >>> empty
> >>> complex types!
> >>>
> >>> Matthias
> >>>
> >>> Fabrizio Montesi schrieb:
> >>>
> >>>> Mmh... a possible solution could be that we add a
> check that verifies
> >>>> whether we're creating a type with the same name
> of a predefined type
> >>>> in Jolie (in which case we should not create the
> type) or not (in
> >>>> which case we should create the type).
> >>>>
> >>>> What do you think?
> >>>>
> >>>> If this can work, the systematic way of doing it
> would be to have some
> >>>> constant set or enum defined somewhere which
> contains the names of all
> >>>> predefined types (I think we can reuse some
> predefined map from the
> >>>> parser).
> >>>>
> >>>> - Fabrizio
> >>>>
> >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter
> Wallnöfer
> >>>> <mwa...@ya...
> <mailto:mwa...@ya...>> wrote:
> >>>>>
> >>>>> Hi all,
> >>>>>
> >>>>> not really correct. It generates types like
> "type <name>:undefined",
> >>>>> for
> >>>>> instance in my case:
> >>>>>>
> >>>>>> type GetWeatherInformation:undefined
> >>>>>
> >>>>> So this is required in some cases.
> >>>>>
> >>>>> Cheers,
> >>>>> Matthias
> >>>>>
> >>>>> Claudio Guidi schrieb:
> >>>>>>
> >>>>>> Hi all,
> >>>>>>
> >>>>>> sorry for the delay.
> >>>>>>
> >>>>>> Do you mean this line?
> >>>>>>
> >>>>>> jolieTypes.add( createAnyOrUndefined(
> element.getName(), complexType )
> >>>>>> );
> >>>>>>
> >>>>>> If I remember well it was commented because,
> otherwise, you will find
> >>>>>>
> >>>>>> type undefined: undefined
> >>>>>>
> >>>>>> into the generated interface.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> --------------------------------------------------------------
> >>>>>> Claudio Guidi Ph.D.
> >>>>>> italianaSoftware s.r.l.
> >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy
> >>>>>> http://www.italianasoftware.com/
> >>>>>> http://www.jolie-lang.org
> <http://www.jolie-lang.org/>
> >>>>>>
> >>>>>> Phone: +39 0542 788201 <tel:%2B39%200542%20788201>
> >>>>>> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065>
> >>>>>> Fax: +39 0542 628048 <tel:%2B39%200542%20628048>
> >>>>>>
> --------------------------------------------------------------
> >>>>>>
> >>>>>> Nota di riservatezza: Il presente messaggio,
> corredato dei relativi
> >>>>>> allegati, contiene informazioni da considerarsi
> strettamente
> >>>>>> riservate,
> >>>>>> ed è
> >>>>>> destinato esclusivamente al destinatario sopra
> indicato, il quale è
> >>>>>> l'unico
> >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria
> >>>>>> responsabilità,diffonderlo. Chiunque ricevesse
> questo messaggio per
> >>>>>> errore o
> >>>>>> comunque lo leggesse senza esserne legittimato
> è avvertito che
> >>>>>> trattenerlo,
> >>>>>> copiarlo,divulgarlo, distribuirlo a persone
> diverse dal destinatario è
> >>>>>> severamente proibito, ed è pregato di rinviarlo
> immediatamente al
> >>>>>> mittente
> >>>>>> distruggendone l'originale.
> >>>>>>
> >>>>>> Grazie per la collaborazione.
> >>>>>>
> >>>>>>
> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm...
> <mailto:fam...@gm...>
> >>>>>> <mailto:fam...@gm...
> <mailto:fam...@gm...>>>
> >>>>>>
> >>>>>>
> >>>>>> Hi all,
> >>>>>>
> >>>>>> @Claudio: do you have any info on that line?
> >>>>>>
> >>>>>> Cheers,
> >>>>>> Fabrizio.
> >>>>>>
> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias
> Dieter Wallnöfer
> >>>>>> <mwa...@ya...
> <mailto:mwa...@ya...>
> <mailto:mwa...@ya...
> <mailto:mwa...@ya...>>> wrote:
> >>>>>> > Any news on this one (and also on the
> Exception thing: Re:
> >>>>>> [Jolie-devel]
> >>>>>> > OneWay messages)?
> >>>>>> >
> >>>>>> > Matthias
> >>>>>> >
> >>>>>> > Fabrizio Montesi schrieb:
> >>>>>> >
> >>>>>> >> Hi all,
> >>>>>> >> I'm trying to see why that line has been
> commented...
> >>>>>> especially since
> >>>>>> >> it has been commented without leaving any
> other comment
> >>>>>> explaining the
> >>>>>> >> reason in the code. Claudio, any memories? :-)
> >>>>>> >>
> >>>>>> >> I see it's commented out in many parts of
> the code.
> >>>>>> >>
> >>>>>> >>
> >>>>>> >> Cheers,
> >>>>>> >> Fabrizio.
> >>>>>> >
> >>>>>> >
> >>>>>>
> >>>>>>
> >
>
>
>
|
|
From: Fabrizio M. <fam...@gm...> - 2013-12-13 06:48:04
|
Is checkSkippedTypes something we already had or something new?
Cheers,
Fabrizio.
On Thu, Dec 12, 2013 at 7:34 PM, Matthias Dieter Wallnöfer
<mwa...@ya...> wrote:
> Hi Claudio,
>
> that's fine, please apply :-).
>
> Matthias
>
> Claudio Guidi schrieb:
>>
>> Hi Matthias,
>>
>>
>> I made some tests and I would patch your patch :-) with the following
>> code:
>>
>> if ( (particle = contentType.asParticle()) == null && !checkSkippedTypes(
>> element.getName(), element.getTargetNamespace() )) {
>> jolieTypes.add( createAnyOrUndefined(
>> element.getName(), complexType ) );
>> continue;
>> }
>>
>> I added && !checkSkippedTypes( element.getName(),
>> element.getTargetNamespace() ) which avoid to process basic element types.
>>
>> So, Matthias could apply the patch with my modifications?
>>
>> --------------------------------------------------------------
>> Claudio Guidi Ph.D.
>> italianaSoftware s.r.l.
>> via Coralli, 66 - 40026 Imola (BO), Italy
>> http://www.italianasoftware.com/
>> http://www.jolie-lang.org <http://www.jolie-lang.org/>
>> Phone: +39 0542 788201
>> Mobile: +39 347 0694065
>> Fax: +39 0542 628048
>> --------------------------------------------------------------
>>
>> Nota di riservatezza: Il presente messaggio, corredato dei relativi
>> allegati, contiene informazioni da considerarsi strettamente riservate, ed è
>> destinato esclusivamente al destinatario sopra indicato, il quale è l'unico
>> autorizzato ad usarlo, copiarlo e, sotto la propria
>> responsabilità,diffonderlo. Chiunque ricevesse questo messaggio per errore o
>> comunque lo leggesse senza esserne legittimato è avvertito che trattenerlo,
>> copiarlo,divulgarlo, distribuirlo a persone diverse dal destinatario è
>> severamente proibito, ed è pregato di rinviarlo immediatamente al mittente
>> distruggendone l'originale.
>>
>> Grazie per la collaborazione.
>>
>>
>> 2013/12/12 Claudio Guidi <cg...@it...
>> <mailto:cg...@it...>>
>>
>>
>> Hi guys,
>>
>> I made some tests with a more complex wsdl. In the following what
>> I found:
>>
>> 1) if a insert the line that Matthias has commented
>> (jolieTypes.add( createAnyOrUndefined( element.getName(),
>> complexType ) );) in the final interface I will found basic types
>> declarations such as
>>
>> type boolean:undefined
>> type string:undefined
>>
>> So far it is not clear to me when exactly happens. I need more
>> time for investigating.
>>
>> Thus, I think we need more test before enabling the patch.
>>
>>
>> new issues!!!
>> 2) XSOMParser seems to not process import tags where
>> schemaLocation is not defined. Ex:
>> <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/">
>>
>> if you change the line into:
>> <s:import namespace="http://schemas.xmlsoap.org/soap/encoding/"
>> schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/>
>> it wroks.
>>
>> But this is quite annoying because if the wsdl is generated (as in
>> my case) without schemaLocation you always need to download the
>> file,add schemaLocation attributes to all the imports and then
>> launch the wsdl2jolie locally. It's a nightmare!
>> I tried to google the problem but I didn't find anything useful,
>> could you help me to find some fixes? Maybe we need to update the
>> XSOM library?
>>
>> 3) at the present, if the message of an operation contains more
>> than one part, the conversion could fail. Ex:
>>
>> <s:schema targetNamespace="blablabla">
>> <s:import
>> namespace="http://schemas.xmlsoap.org/soap/encoding/"
>> schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/>
>> <s:complexType name="HomerSimpsons">
>> some complex content
>> </s:complexContent>
>> </s:complexType>
>> </s:schema>
>>
>> <wsdl:message name="MYMessage">
>> <wsdl:part name="part1" type="s:string" />
>> <wsdl:part name="part2" type="s1:HomerSimpsons" />
>> </wsdl:message>
>>
>> <wsdl:operation name="operationName">
>> <wsdl:input message="tns:MyMessage" />
>> <wsdl:output message="tns:AnotherMessage" />
>> </wsdl:operation>
>>
>> Unfortunately I cannot attach the wsdl file because it is private
>> and protected by copyright.
>> This is a limitation we have so far.
>>
>>
>>
>>
>> --------------------------------------------------------------
>> Claudio Guidi Ph.D.
>> italianaSoftware s.r.l.
>> via Coralli, 66 - 40026 Imola (BO), Italy
>> http://www.italianasoftware.com/
>> http://www.jolie-lang.org <http://www.jolie-lang.org/>
>> Phone: +39 0542 788201 <tel:%2B39%200542%20788201>
>> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065>
>> Fax: +39 0542 628048 <tel:%2B39%200542%20628048>
>>
>> --------------------------------------------------------------
>>
>> Nota di riservatezza: Il presente messaggio, corredato dei
>> relativi allegati, contiene informazioni da considerarsi
>> strettamente riservate, ed è destinato esclusivamente al
>> destinatario sopra indicato, il quale è l'unico autorizzato ad
>> usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo.
>> Chiunque ricevesse questo messaggio per errore o comunque
>> lo leggesse senza esserne legittimato è avvertito che trattenerlo,
>> copiarlo,divulgarlo, distribuirlo a persone diverse dal
>> destinatario è severamente proibito, ed è pregato di rinviarlo
>> immediatamente al mittente distruggendone l'originale.
>>
>> Grazie per la collaborazione.
>>
>>
>> 2013/12/10 Fabrizio Montesi <fam...@gm...
>> <mailto:fam...@gm...>>
>>
>>
>> That'd be great. We should also think about adding them to the
>> test suite somehow..
>>
>> Sent from my phone.
>>
>> On Dec 10, 2013 8:12 PM, "Claudio Guidi"
>> <cg...@it...
>> <mailto:cg...@it...>> wrote:
>>
>> If you give me some days I'll try to check the code with
>> some complex wsdl.
>>
>> Il 10/dic/2013 20:00 "Fabrizio Montesi"
>> <fam...@gm... <mailto:fam...@gm...>> ha scritto:
>>
>>
>> Claudio, do you have an example for raising that error?
>>
>> - Fabrizio
>>
>> On Tue, Dec 10, 2013 at 7:07 PM, Matthias Dieter Wallnöfer
>> <mwa...@ya... <mailto:mwa...@ya...>>
>>
>> wrote:
>> > We should try to understand where and why the
>> generation of
>> >>
>> >> type undefined:undefined
>> >
>> > happened.
>> >
>> > Just to make sure - I did not get it in my case
>> (when un-commenting this
>> > particular codeline).
>> >
>> > Matthias
>> >
>> > Fabrizio Montesi schrieb:
>> >
>> >> No, I mean that your type should be generated:
>> >>
>> >> type GetWeatherInformation:undefined
>> >>
>> >> whereas the following should not be generated:
>> >>
>> >> type undefined:undefined
>> >>
>> >>
>> >> by implementing some check on the name of the type
>> we are generating,
>> >> to avoid redefining undefined. The latter is our
>> main problem
>> >> (@Claudio: right?).
>> >>
>> >>
>> >>
>> >> Ciao,
>> >> Fabrizio.
>> >>
>> >> On Tue, Dec 10, 2013 at 5:55 PM, Matthias Dieter
>> Wallnöfer
>> >> <mwa...@ya...
>> <mailto:mwa...@ya...>> wrote:
>> >>>
>> >>> Hi Fabrizio,
>> >>>
>> >>> did I get your point?
>> >>>
>> >>> You think that declarations as
>> >>>>
>> >>>> type GetWeatherInformation:undefined
>> >>>
>> >>> should be omitted and all "GetWeatherInformation"
>> appearances immediately
>> >>> be
>> >>> substituted by "undefined"?
>> >>>
>> >>> Btw. in the WSDL file it is declared like this
>> >>> (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl):
>> >>>
>> >>>> <s:element
>> name="GetWeatherInformation"><s:complexType/></s:element>
>> >>>
>> >>> So to be honest I do not see an issue to include
>> it in Jolie's header as
>> >>> well. The right thing would be to change the
>> webservice to not include
>> >>> empty
>> >>> complex types!
>> >>>
>> >>> Matthias
>> >>>
>> >>> Fabrizio Montesi schrieb:
>> >>>
>> >>>> Mmh... a possible solution could be that we add a
>> check that verifies
>> >>>> whether we're creating a type with the same name
>> of a predefined type
>> >>>> in Jolie (in which case we should not create the
>> type) or not (in
>> >>>> which case we should create the type).
>> >>>>
>> >>>> What do you think?
>> >>>>
>> >>>> If this can work, the systematic way of doing it
>> would be to have some
>> >>>> constant set or enum defined somewhere which
>> contains the names of all
>> >>>> predefined types (I think we can reuse some
>> predefined map from the
>> >>>> parser).
>> >>>>
>> >>>> - Fabrizio
>> >>>>
>> >>>> On Tue, Dec 10, 2013 at 5:11 PM, Matthias Dieter
>> Wallnöfer
>> >>>> <mwa...@ya...
>> <mailto:mwa...@ya...>> wrote:
>> >>>>>
>> >>>>> Hi all,
>> >>>>>
>> >>>>> not really correct. It generates types like
>> "type <name>:undefined",
>> >>>>> for
>> >>>>> instance in my case:
>> >>>>>>
>> >>>>>> type GetWeatherInformation:undefined
>> >>>>>
>> >>>>> So this is required in some cases.
>> >>>>>
>> >>>>> Cheers,
>> >>>>> Matthias
>> >>>>>
>> >>>>> Claudio Guidi schrieb:
>> >>>>>>
>> >>>>>> Hi all,
>> >>>>>>
>> >>>>>> sorry for the delay.
>> >>>>>>
>> >>>>>> Do you mean this line?
>> >>>>>>
>> >>>>>> jolieTypes.add( createAnyOrUndefined(
>> element.getName(), complexType )
>> >>>>>> );
>> >>>>>>
>> >>>>>> If I remember well it was commented because,
>> otherwise, you will find
>> >>>>>>
>> >>>>>> type undefined: undefined
>> >>>>>>
>> >>>>>> into the generated interface.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>>
>> --------------------------------------------------------------
>> >>>>>> Claudio Guidi Ph.D.
>> >>>>>> italianaSoftware s.r.l.
>> >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy
>> >>>>>> http://www.italianasoftware.com/
>> >>>>>> http://www.jolie-lang.org
>> <http://www.jolie-lang.org/>
>> >>>>>>
>> >>>>>> Phone: +39 0542 788201 <tel:%2B39%200542%20788201>
>> >>>>>> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065>
>> >>>>>> Fax: +39 0542 628048 <tel:%2B39%200542%20628048>
>>
>> >>>>>>
>>
>> --------------------------------------------------------------
>> >>>>>>
>> >>>>>> Nota di riservatezza: Il presente messaggio,
>> corredato dei relativi
>> >>>>>> allegati, contiene informazioni da considerarsi
>> strettamente
>> >>>>>> riservate,
>> >>>>>> ed è
>> >>>>>> destinato esclusivamente al destinatario sopra
>> indicato, il quale è
>> >>>>>> l'unico
>> >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria
>> >>>>>> responsabilità,diffonderlo. Chiunque ricevesse
>> questo messaggio per
>> >>>>>> errore o
>> >>>>>> comunque lo leggesse senza esserne legittimato
>> è avvertito che
>> >>>>>> trattenerlo,
>> >>>>>> copiarlo,divulgarlo, distribuirlo a persone
>> diverse dal destinatario è
>> >>>>>> severamente proibito, ed è pregato di rinviarlo
>> immediatamente al
>> >>>>>> mittente
>> >>>>>> distruggendone l'originale.
>> >>>>>>
>> >>>>>> Grazie per la collaborazione.
>> >>>>>>
>> >>>>>>
>> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm...
>> <mailto:fam...@gm...>
>> >>>>>> <mailto:fam...@gm...
>>
>> <mailto:fam...@gm...>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> Hi all,
>> >>>>>>
>> >>>>>> @Claudio: do you have any info on that line?
>> >>>>>>
>> >>>>>> Cheers,
>> >>>>>> Fabrizio.
>> >>>>>>
>> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias
>> Dieter Wallnöfer
>> >>>>>> <mwa...@ya...
>> <mailto:mwa...@ya...>
>> <mailto:mwa...@ya...
>>
>> <mailto:mwa...@ya...>>> wrote:
>> >>>>>> > Any news on this one (and also on the
>> Exception thing: Re:
>> >>>>>> [Jolie-devel]
>> >>>>>> > OneWay messages)?
>> >>>>>> >
>> >>>>>> > Matthias
>> >>>>>> >
>> >>>>>> > Fabrizio Montesi schrieb:
>> >>>>>> >
>> >>>>>> >> Hi all,
>> >>>>>> >> I'm trying to see why that line has been
>> commented...
>> >>>>>> especially since
>> >>>>>> >> it has been commented without leaving any
>> other comment
>> >>>>>> explaining the
>> >>>>>> >> reason in the code. Claudio, any memories? :-)
>> >>>>>> >>
>> >>>>>> >> I see it's commented out in many parts of
>> the code.
>> >>>>>> >>
>> >>>>>> >>
>> >>>>>> >> Cheers,
>> >>>>>> >> Fabrizio.
>> >>>>>> >
>> >>>>>> >
>> >>>>>>
>> >>>>>>
>> >
>>
>>
>>
>
|
|
From: Matthias D. W. <mwa...@ya...> - 2013-12-16 11:20:56
Attachments:
jolie_webservices.patch
|
Okay, and the rest of the patch? Matthias Claudio Guidi schrieb: > commit done > > -------------------------------------------------------------- > Claudio Guidi Ph.D. > italianaSoftware s.r.l. > via Coralli, 66 - 40026 Imola (BO), Italy > http://www.italianasoftware.com/ > http://www.jolie-lang.org <http://www.jolie-lang.org/> > Phone: +39 0542 788201 > Mobile: +39 347 0694065 > Fax: +39 0542 628048 > -------------------------------------------------------------- > > Nota di riservatezza: Il presente messaggio, corredato dei > relativi allegati, contiene informazioni da considerarsi strettamente > riservate, ed è destinato esclusivamente al destinatario sopra > indicato, il quale è l'unico autorizzato ad usarlo, copiarlo e, sotto > la propria responsabilità,diffonderlo. Chiunque ricevesse questo > messaggio per errore o comunque lo leggesse senza esserne legittimato > è avvertito che trattenerlo, copiarlo,divulgarlo, distribuirlo a > persone diverse dal destinatario è severamente proibito, ed è pregato > di rinviarlo immediatamente al mittente distruggendone l'originale. > > Grazie per la collaborazione. > > > 2013/12/13 Claudio Guidi <cg...@it... > <mailto:cg...@it...>> > > we already had, I just added the condition > > -------------------------------------------------------------- > Claudio Guidi Ph.D. > italianaSoftware s.r.l. > via Coralli, 66 - 40026 Imola (BO), Italy > http://www.italianasoftware.com/ > http://www.jolie-lang.org <http://www.jolie-lang.org/> > Phone: +39 0542 788201 <tel:%2B39%200542%20788201> > Mobile: +39 347 0694065 <tel:%2B39%20347%200694065> > Fax: +39 0542 628048 <tel:%2B39%200542%20628048> > -------------------------------------------------------------- > > Nota di riservatezza: Il presente messaggio, corredato dei > relativi allegati, contiene informazioni da considerarsi > strettamente riservate, ed è destinato esclusivamente al > destinatario sopra indicato, il quale è l'unico autorizzato ad > usarlo, copiarlo e, sotto la propria responsabilità,diffonderlo. > Chiunque ricevesse questo messaggio per errore o comunque > lo leggesse senza esserne legittimato è avvertito che trattenerlo, > copiarlo,divulgarlo, distribuirlo a persone diverse dal > destinatario è severamente proibito, ed è pregato di rinviarlo > immediatamente al mittente distruggendone l'originale. > > Grazie per la collaborazione. > > > 2013/12/13 Fabrizio Montesi <fam...@gm... > <mailto:fam...@gm...>> > > Is checkSkippedTypes something we already had or something new? > > Cheers, > Fabrizio. > > On Thu, Dec 12, 2013 at 7:34 PM, Matthias Dieter Wallnöfer > <mwa...@ya... <mailto:mwa...@ya...>> wrote: > > Hi Claudio, > > > > that's fine, please apply :-). > > > > Matthias > > > > Claudio Guidi schrieb: > >> > >> Hi Matthias, > >> > >> > >> I made some tests and I would patch your patch :-) with the > following > >> code: > >> > >> if ( (particle = contentType.asParticle()) == null && > !checkSkippedTypes( > >> element.getName(), element.getTargetNamespace() )) { > >> jolieTypes.add( createAnyOrUndefined( > >> element.getName(), complexType ) ); > >> continue; > >> } > >> > >> I added && !checkSkippedTypes( element.getName(), > >> element.getTargetNamespace() ) which avoid to process basic > element types. > >> > >> So, Matthias could apply the patch with my modifications? > >> > >> -------------------------------------------------------------- > >> Claudio Guidi Ph.D. > >> italianaSoftware s.r.l. > >> via Coralli, 66 - 40026 Imola (BO), Italy > >> http://www.italianasoftware.com/ > >> http://www.jolie-lang.org <http://www.jolie-lang.org/> > >> Phone: +39 0542 788201 <tel:%2B39%200542%20788201> > >> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065> > >> Fax: +39 0542 628048 <tel:%2B39%200542%20628048> > >> -------------------------------------------------------------- > >> > >> Nota di riservatezza: Il presente messaggio, corredato dei > relativi > >> allegati, contiene informazioni da considerarsi > strettamente riservate, ed è > >> destinato esclusivamente al destinatario sopra indicato, il > quale è l'unico > >> autorizzato ad usarlo, copiarlo e, sotto la propria > >> responsabilità,diffonderlo. Chiunque ricevesse questo > messaggio per errore o > >> comunque lo leggesse senza esserne legittimato è avvertito > che trattenerlo, > >> copiarlo,divulgarlo, distribuirlo a persone diverse dal > destinatario è > >> severamente proibito, ed è pregato di rinviarlo > immediatamente al mittente > >> distruggendone l'originale. > >> > >> Grazie per la collaborazione. > >> > >> > >> 2013/12/12 Claudio Guidi <cg...@it... > <mailto:cg...@it...> > >> <mailto:cg...@it... > <mailto:cg...@it...>>> > >> > >> > >> Hi guys, > >> > >> I made some tests with a more complex wsdl. In the > following what > >> I found: > >> > >> 1) if a insert the line that Matthias has commented > >> (jolieTypes.add( createAnyOrUndefined( element.getName(), > >> complexType ) );) in the final interface I will found > basic types > >> declarations such as > >> > >> type boolean:undefined > >> type string:undefined > >> > >> So far it is not clear to me when exactly happens. I > need more > >> time for investigating. > >> > >> Thus, I think we need more test before enabling the patch. > >> > >> > >> new issues!!! > >> 2) XSOMParser seems to not process import tags where > >> schemaLocation is not defined. Ex: > >> <s:import > namespace="http://schemas.xmlsoap.org/soap/encoding/"> > >> > >> if you change the line into: > >> <s:import > namespace="http://schemas.xmlsoap.org/soap/encoding/" > >> > schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/> > >> it wroks. > >> > >> But this is quite annoying because if the wsdl is > generated (as in > >> my case) without schemaLocation you always need to > download the > >> file,add schemaLocation attributes to all the imports > and then > >> launch the wsdl2jolie locally. It's a nightmare! > >> I tried to google the problem but I didn't find > anything useful, > >> could you help me to find some fixes? Maybe we need to > update the > >> XSOM library? > >> > >> 3) at the present, if the message of an operation > contains more > >> than one part, the conversion could fail. Ex: > >> > >> <s:schema targetNamespace="blablabla"> > >> <s:import > >> namespace="http://schemas.xmlsoap.org/soap/encoding/" > >> > schemaLocation="http://schemas.xmlsoap.org/soap/encoding/"/> > >> <s:complexType name="HomerSimpsons"> > >> some complex content > >> </s:complexContent> > >> </s:complexType> > >> </s:schema> > >> > >> <wsdl:message name="MYMessage"> > >> <wsdl:part name="part1" type="s:string" /> > >> <wsdl:part name="part2" type="s1:HomerSimpsons" /> > >> </wsdl:message> > >> > >> <wsdl:operation name="operationName"> > >> <wsdl:input message="tns:MyMessage" /> > >> <wsdl:output message="tns:AnotherMessage" /> > >> </wsdl:operation> > >> > >> Unfortunately I cannot attach the wsdl file because it > is private > >> and protected by copyright. > >> This is a limitation we have so far. > >> > >> > >> > >> > >> -------------------------------------------------------------- > >> Claudio Guidi Ph.D. > >> italianaSoftware s.r.l. > >> via Coralli, 66 - 40026 Imola (BO), Italy > >> http://www.italianasoftware.com/ > >> http://www.jolie-lang.org <http://www.jolie-lang.org/> > >> Phone: +39 0542 788201 <tel:%2B39%200542%20788201> > <tel:%2B39%200542%20788201> > >> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065> > <tel:%2B39%20347%200694065> > >> Fax: +39 0542 628048 <tel:%2B39%200542%20628048> > <tel:%2B39%200542%20628048> > >> > >> -------------------------------------------------------------- > >> > >> Nota di riservatezza: Il presente messaggio, corredato dei > >> relativi allegati, contiene informazioni da considerarsi > >> strettamente riservate, ed è destinato esclusivamente al > >> destinatario sopra indicato, il quale è l'unico > autorizzato ad > >> usarlo, copiarlo e, sotto la propria > responsabilità,diffonderlo. > >> Chiunque ricevesse questo messaggio per errore o comunque > >> lo leggesse senza esserne legittimato è avvertito che > trattenerlo, > >> copiarlo,divulgarlo, distribuirlo a persone diverse dal > >> destinatario è severamente proibito, ed è pregato di > rinviarlo > >> immediatamente al mittente distruggendone l'originale. > >> > >> Grazie per la collaborazione. > >> > >> > >> 2013/12/10 Fabrizio Montesi <fam...@gm... > <mailto:fam...@gm...> > >> <mailto:fam...@gm... <mailto:fam...@gm...>>> > >> > >> > >> That'd be great. We should also think about adding > them to the > >> test suite somehow.. > >> > >> Sent from my phone. > >> > >> On Dec 10, 2013 8:12 PM, "Claudio Guidi" > >> <cg...@it... > <mailto:cg...@it...> > >> <mailto:cg...@it... > <mailto:cg...@it...>>> wrote: > >> > >> If you give me some days I'll try to check the > code with > >> some complex wsdl. > >> > >> Il 10/dic/2013 20:00 "Fabrizio Montesi" > >> <fam...@gm... > <mailto:fam...@gm...> <mailto:fam...@gm... > <mailto:fam...@gm...>>> ha scritto: > >> > >> > >> Claudio, do you have an example for raising > that error? > >> > >> - Fabrizio > >> > >> On Tue, Dec 10, 2013 at 7:07 PM, Matthias > Dieter Wallnöfer > >> <mwa...@ya... > <mailto:mwa...@ya...> <mailto:mwa...@ya... > <mailto:mwa...@ya...>>> > >> > >> wrote: > >> > We should try to understand where and why the > >> generation of > >> >> > >> >> type undefined:undefined > >> > > >> > happened. > >> > > >> > Just to make sure - I did not get it in > my case > >> (when un-commenting this > >> > particular codeline). > >> > > >> > Matthias > >> > > >> > Fabrizio Montesi schrieb: > >> > > >> >> No, I mean that your type should be > generated: > >> >> > >> >> type GetWeatherInformation:undefined > >> >> > >> >> whereas the following should not be > generated: > >> >> > >> >> type undefined:undefined > >> >> > >> >> > >> >> by implementing some check on the name > of the type > >> we are generating, > >> >> to avoid redefining undefined. The > latter is our > >> main problem > >> >> (@Claudio: right?). > >> >> > >> >> > >> >> > >> >> Ciao, > >> >> Fabrizio. > >> >> > >> >> On Tue, Dec 10, 2013 at 5:55 PM, > Matthias Dieter > >> Wallnöfer > >> >> <mwa...@ya... > <mailto:mwa...@ya...> > >> <mailto:mwa...@ya... > <mailto:mwa...@ya...>>> wrote: > >> >>> > >> >>> Hi Fabrizio, > >> >>> > >> >>> did I get your point? > >> >>> > >> >>> You think that declarations as > >> >>>> > >> >>>> type GetWeatherInformation:undefined > >> >>> > >> >>> should be omitted and all > "GetWeatherInformation" > >> appearances immediately > >> >>> be > >> >>> substituted by "undefined"? > >> >>> > >> >>> Btw. in the WSDL file it is declared > like this > >> >>> > (http://wsf.cdyne.com/WeatherWS/Weather.asmx?wsdl): > >> >>> > >> >>>> <s:element > >> name="GetWeatherInformation"><s:complexType/></s:element> > >> >>> > >> >>> So to be honest I do not see an issue > to include > >> it in Jolie's header as > >> >>> well. The right thing would be to > change the > >> webservice to not include > >> >>> empty > >> >>> complex types! > >> >>> > >> >>> Matthias > >> >>> > >> >>> Fabrizio Montesi schrieb: > >> >>> > >> >>>> Mmh... a possible solution could be > that we add a > >> check that verifies > >> >>>> whether we're creating a type with the > same name > >> of a predefined type > >> >>>> in Jolie (in which case we should not > create the > >> type) or not (in > >> >>>> which case we should create the type). > >> >>>> > >> >>>> What do you think? > >> >>>> > >> >>>> If this can work, the systematic way > of doing it > >> would be to have some > >> >>>> constant set or enum defined somewhere > which > >> contains the names of all > >> >>>> predefined types (I think we can reuse > some > >> predefined map from the > >> >>>> parser). > >> >>>> > >> >>>> - Fabrizio > >> >>>> > >> >>>> On Tue, Dec 10, 2013 at 5:11 PM, > Matthias Dieter > >> Wallnöfer > >> >>>> <mwa...@ya... > <mailto:mwa...@ya...> > >> <mailto:mwa...@ya... > <mailto:mwa...@ya...>>> wrote: > >> >>>>> > >> >>>>> Hi all, > >> >>>>> > >> >>>>> not really correct. It generates > types like > >> "type <name>:undefined", > >> >>>>> for > >> >>>>> instance in my case: > >> >>>>>> > >> >>>>>> type GetWeatherInformation:undefined > >> >>>>> > >> >>>>> So this is required in some cases. > >> >>>>> > >> >>>>> Cheers, > >> >>>>> Matthias > >> >>>>> > >> >>>>> Claudio Guidi schrieb: > >> >>>>>> > >> >>>>>> Hi all, > >> >>>>>> > >> >>>>>> sorry for the delay. > >> >>>>>> > >> >>>>>> Do you mean this line? > >> >>>>>> > >> >>>>>> jolieTypes.add( createAnyOrUndefined( > >> element.getName(), complexType ) > >> >>>>>> ); > >> >>>>>> > >> >>>>>> If I remember well it was commented because, > >> otherwise, you will find > >> >>>>>> > >> >>>>>> type undefined: undefined > >> >>>>>> > >> >>>>>> into the generated interface. > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>> > >> > >> -------------------------------------------------------------- > >> >>>>>> Claudio Guidi Ph.D. > >> >>>>>> italianaSoftware s.r.l. > >> >>>>>> via Coralli, 66 - 40026 Imola (BO), Italy > >> >>>>>> http://www.italianasoftware.com/ > >> >>>>>> http://www.jolie-lang.org > >> <http://www.jolie-lang.org/> > >> >>>>>> > >> >>>>>> Phone: +39 0542 788201 <tel:%2B39%200542%20788201> > <tel:%2B39%200542%20788201> > >> >>>>>> Mobile: +39 347 0694065 <tel:%2B39%20347%200694065> > <tel:%2B39%20347%200694065> > >> >>>>>> Fax: +39 0542 628048 <tel:%2B39%200542%20628048> > <tel:%2B39%200542%20628048> > >> > >> >>>>>> > >> > >> -------------------------------------------------------------- > >> >>>>>> > >> >>>>>> Nota di riservatezza: Il presente messaggio, > >> corredato dei relativi > >> >>>>>> allegati, contiene informazioni da considerarsi > >> strettamente > >> >>>>>> riservate, > >> >>>>>> ed è > >> >>>>>> destinato esclusivamente al destinatario sopra > >> indicato, il quale è > >> >>>>>> l'unico > >> >>>>>> autorizzato ad usarlo, copiarlo e, sotto la propria > >> >>>>>> responsabilità,diffonderlo. Chiunque ricevesse > >> questo messaggio per > >> >>>>>> errore o > >> >>>>>> comunque lo leggesse senza esserne legittimato > >> è avvertito che > >> >>>>>> trattenerlo, > >> >>>>>> copiarlo,divulgarlo, distribuirlo a persone > >> diverse dal destinatario è > >> >>>>>> severamente proibito, ed è pregato di rinviarlo > >> immediatamente al > >> >>>>>> mittente > >> >>>>>> distruggendone l'originale. > >> >>>>>> > >> >>>>>> Grazie per la collaborazione. > >> >>>>>> > >> >>>>>> > >> >>>>>> 2013/12/9 Fabrizio Montesi <fam...@gm... > <mailto:fam...@gm...> > >> <mailto:fam...@gm... > <mailto:fam...@gm...>> > >> >>>>>> <mailto:fam...@gm... <mailto:fam...@gm...> > >> > >> <mailto:fam...@gm... > <mailto:fam...@gm...>>>> > >> >>>>>> > >> >>>>>> > >> >>>>>> Hi all, > >> >>>>>> > >> >>>>>> @Claudio: do you have any info on that line? > >> >>>>>> > >> >>>>>> Cheers, > >> >>>>>> Fabrizio. > >> >>>>>> > >> >>>>>> On Wed, Dec 4, 2013 at 5:50 PM, Matthias > >> Dieter Wallnöfer > >> >>>>>> <mwa...@ya... > <mailto:mwa...@ya...> > >> <mailto:mwa...@ya... > <mailto:mwa...@ya...>> > >> <mailto:mwa...@ya... > <mailto:mwa...@ya...> > >> > >> <mailto:mwa...@ya... > <mailto:mwa...@ya...>>>> wrote: > >> >>>>>> > Any news on this one (and also on the > >> Exception thing: Re: > >> >>>>>> [Jolie-devel] > >> >>>>>> > OneWay messages)? > >> >>>>>> > > >> >>>>>> > Matthias > >> >>>>>> > > >> >>>>>> > Fabrizio Montesi schrieb: > >> >>>>>> > > >> >>>>>> >> Hi all, > >> >>>>>> >> I'm trying to see why that line has been > >> commented... > >> >>>>>> especially since > >> >>>>>> >> it has been commented without leaving any > >> other comment > >> >>>>>> explaining the > >> >>>>>> >> reason in the code. Claudio, any memories? :-) > >> >>>>>> >> > >> >>>>>> >> I see it's commented out in many parts of > >> the code. > >> >>>>>> >> > >> >>>>>> >> > >> >>>>>> >> Cheers, > >> >>>>>> >> Fabrizio. > >> >>>>>> > > >> >>>>>> > > >> >>>>>> > >> >>>>>> > >> > > >> > >> > >> > > > > > |
Thanks for helping keep SourceForge clean.
X