joelib-help

[Joelib-help] problems compiling joelib: wrong weka library?

[Gert S. <Ger...@re...>]

Both the stable version, the developer version and the current cvs version
of weka don't use an Attribute(String,FastVector,int) constructor in the
core.Attribute class, but instead expect a ProtectedProperties object if a
third argument is given in the constructor-call.

And yet, this Attribute(String,FastVector,int) constructor is called in
the algo.dataming.weka.InstancesHelper class.

I tracked down the versions of the Attribute.java file in the weka
repository and apparently the current constructor syntax already exists
for more than 2 years.

So, I must be missing something here. Do I use a wrong weka library, or do
I overlook something else?

Thanks,

Gert Sclep

Re: [Joelib-help] problems compiling joelib: wrong weka library?

[Joerg K. W. <we...@in...>]

Hi Gert,

> Both the stable version, the developer version and the current cvs version
> of weka don't use an Attribute(String,FastVector,int) constructor in the
> core.Attribute class, but instead expect a ProtectedProperties object if a
> third argument is given in the constructor-call.
If i'm reminding this correclty i've just changed this constructor from 
'protected' to 'public' ...
... in my Weka version i've changed some more things, but that's not 
really interesting for you ...

> So, I must be missing something here. Do I use a wrong weka library, or do
> I overlook something else?
Just remind we are using source code, if something does not fit ... we 
change these things !

Regards, Joerg

-- 
Dipl. Chem. Joerg K. Wegner
Center of Bioinformatics Tuebingen (ZBIT)
Department of Computer Architecture
Univ. Tuebingen, Sand 1, D-72076 Tuebingen, Germany
Phone: (+49/0) 7071 29 78970
Fax: (+49/0) 7071 29 5091
E-Mail: mailto:we...@in...
WWW:    http://www-ra.informatik.uni-tuebingen.de
--
Never mistake motion for action.
                          E. Hemingway

Re: [Joelib-help] problems compiling joelib: wrong weka library?

[Joerg K. W. <we...@in...>]

Hi Gert,

> But shouldn't you better add the modified weka.jar to the lib-directory in
> that case? Or mention the necessary modifications to weka in the build.xml
> file?
I think these things can already be freely discussed in the developer 
mailing list. I hope this will not to much 'developer stuff' for the 
subscribers of the helping mailing list. On the other side JOELib has 
(in my opinion) a 70% developer focus, so the division into help-, and 
developer-mailing list is not really clear. Please write a comment if 
you want to tell us your thoughts ...

> Anyway, my opinion would be to try to subclass the classes of the used
> packages in case of a protected modifier or to write new classes in the
> same package as the 'stubborn' class in case of a package modifier. In my
> eyes this is more elegant, since you leave the other peoples code intact.
> How does it look in the eyes of a more skilled coder?
I don't care, because that's only one single entry. Because this 
functionality has it's focus on developers, i think they will be easily 
able to change 'protected' to 'public' and recompile the sources. If not 
i can offer a source code patch and/or the ant target for doing such things.
Furthermore i do not find the weka design decision for this class not 
really good. Protected is to restricted for such an important class, 
that like making atoms protected.

Another possibility is to add a simple Mol2Instance class in the weka 
source package to fullfill the protected case.

Adding the weka.jar is definitely possible, but will increment the 
joelib distribution.

And last but not least you can write a wrapper if you like and pick the 
required functionalites from the InstancesHelper from JOELib.

So i think adding somewere a note in the tutorial would be fine, because 
i've an internal CVS version also. That's my way, when developing 
'machine learning' tools and hacking them.

> Regards,
> Gert

Regards, Joerg

-- 
Dipl. Chem. Joerg K. Wegner
Center of Bioinformatics Tuebingen (ZBIT)
Department of Computer Architecture
Univ. Tuebingen, Sand 1, D-72076 Tuebingen, Germany
Phone: (+49/0) 7071 29 78970
Fax: (+49/0) 7071 29 5091
E-Mail: mailto:we...@in...
WWW:    http://www-ra.informatik.uni-tuebingen.de
--
Never mistake motion for action.
                          E. Hemingway

Re: [Joelib-help] problems compiling joelib: wrong weka library?

[Gert S. <Ger...@re...>]

> > But shouldn't you better add the modified weka.jar to the lib-directory in
> > that case? Or mention the necessary modifications to weka in the build.xml
> > file?
> I think these things can already be freely discussed in the developer
> mailing list. I hope this will not to much 'developer stuff' for the
> subscribers of the helping mailing list. On the other side JOELib has
> (in my opinion) a 70% developer focus, so the division into help-, and
> developer-mailing list is not really clear. Please write a comment if
> you want to tell us your thoughts ...

I still think it is a good thing to have this division between help and
developer list. The help list would be for problems when using the program
or when installing the program. The developer list for problems concerning
analysis and design and for problems when compiling the source code.

Just as long as developers are not to proud to post something in the help
list, there will not be a lot of confusion.