#242 [PATCH] makefile mode

open
nobody
None
5
2014-02-06
2008-11-01
Jari Aalto
No

Cf. Debian Bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=258435

Could you kind take a look at this and let me know
if this is included in later versions.

==========================
Package: joe
Version: 3.1-0.1
Severity: wishlist
Tags: patch

The attached patch and file provide joe with a makefile mode.

=====================================================

On Fri, Jul 09, 2004 at 05:59:30PM +0100, Darren Salt wrote:
> Package: joe
> Version: 3.1-0.1
> Severity: wishlist
> Tags: patch
>
> The attached patch and file provide joe with a makefile mode.

I had forwarded your patch upstream, but they didn't include it yet.
I adjusted it to the 3.5 syntax (there's now a ftyperc), and started
using it, and then I realized the possible reason why they didn't include
it - it's ugly :) The colors are way too intense compared to typical joe
syntax highlighting.

> =Space underline inverse bright red

The red underlined square is just plain uncalled for :)

The parser that detects Space is also buggy. For example, joe-3.5/Makefile
lines 318 and 321 end with it, for no apparent reason.

> =MakeVariable bold yellow

The yellow $( ) are most annoying, too.

> =DotTarget magenta

This one is are also buggy.

In joe-3.5/Makefile:829 it colors .NOEXPORT: as a Label, instead of as
a DotTarget.

> =Assignment bold green

In joe-3.5/Makefile:238 it colors "all:" as an Assignment (variable),
rather than as a target, which makes them indistinct, sort of defeating
the point of highlighting...

Discussion

  • Jari Aalto

    Jari Aalto - 2008-11-01

    make diff

     
  • Jari Aalto

    Jari Aalto - 2008-11-01
     
  • Jari Aalto

    Jari Aalto - 2008-11-01

    Here is the full changed joe-make.jsf (from 3.1-0.1)
    File Added: joe-make.jsf

     
  • Joe Allen

    Joe Allen - 2008-11-02

    I've tried this syntax file: with it Makefiles look like christmas trees :-) I think it needs work so I'm leaving it out for now, but I'll use it as a starting point for a future version.

     
  • Jari Aalto

    Jari Aalto - 2010-12-20

    Any news about including Makefile syntax file with joe?

     

Log in to post a comment.