Re: [Jocr-devels] GOCR improvements

[Dmitry K. <dm...@ma...>]

Hi Joerg,

Thank you for reply!

Initially I checked the sources in the official repository:
http://jocr.cvs.sourceforge.net/viewvc/jocr/jocr/
but indeed, the patches are in tarball you've mentioned. Why you cannot
commit them?

I also suggest to add "--exclude-vcs" in all places in Makefile, where
you create tarball, e.g.

--- a/Makefile.in
+++ b/Makefile.in
@@ -153,7 +153,7 @@
 	-rm -rf jocr/src/api
 	# -rm -rf jocr/CVS jocr/*/CVS jocr/*/*/CVS # CVS tree
 	-rm -rf jocr/Makefile jocr/src/Makefile jocr/include/config.h
-	tar chzf ../jocr.tgz jocr
+	tar --exclude-vcs chzf ../jocr.tgz jocr
 	-gpg -ab --default-key 0x53BDFBE3 ../jocr.tgz # .asc
 	-cp ../jocr.tgz ../jocr.tgz.`date +%y%m%d` # backup, remove later
 	ls -l ../jocr.tgz{,.asc}

I wonder, if we can help you somehow. I also suppose there are memory
leaks in list structures, that GOCR allocates in memory. They are
visible from valgrind output. I would like to have a closer look at
them, if you could manage the removal of global JOB variable. Maybe I
can help you with last one? I tried to analyze it, but I was a bit
confused, as in some places where global and non-global approaches are used.

Joerg Schulenburg wrote on 23.09.2010 00:18:
> 
> Hi,
> 
> Your patches are there.
> Did you checked http://www.ovgu.de/jschulen/ocr/jocr.tgz ?
> But I have to do some other improvements to avoid worse recognition
> before releasing 0.49 official.
> 
> Joerg
> 
> On Mon, 13 Sep 2010, Dmitry Katsubo wrote:
> 
>> Dear GOCR community!
>>
>> I come back to maillist again with the same set of issues. I while ago I
>> have submitted a set of patches, which (I suppose) we all agreed are OK
>> to be applied to the HEAD. However, they are still not there.
>>
>> In particular:
>>
>> * unicode.h.patch
>>  Solves INFINITY constant clash with math.h
>> * list.h.patch
>>  Solves a conflict of types with STL.
>>
>> I think, above two fixes are trivial. If they are not, let me know how
>> can I improve the situation.
>>
>> * Makefile.in.patch
>>  Excludes CVS directories from distribution tarball.
>>  Note here: it is also necessary to remove all makefiles, as they are
>> autogenerated from Makefile.in files. This should be done in "clean" or
>> "distclean" rule.
>>
>> * Makefile.src.in.patch
>>  Provides extra rules to build a library. I see no other way at the
>> moment than to provide all headers together with the library. However,
>> the best way is to define a clean API (= gocr.h), which does not depend
>> on e.g. "config.h". As I mentioned below the candidate functions for API
>> are:
>>
>> job_init(&job);
>> job_free(&job);
>> pgm2asc(&job);
>>
>> I hope that GOCR developers will not block the proposal above concerning
>> GOCR improvement for another tree months.
>>
>> I myself am ready to allocate some time to work on further GOCR
>> improvements, for example:
>> - Eliminate the global variable "job_t *JOB"
>> - Enable the logging information to STDERR only if job->cfg.verbose flag
>> is ON
>> but in order to be sure that my changes do not break the core, I would
>> like GOCR developers to provide basic tests for the project (via "make
>> test" rule).
>>
>> I also provide a complete set of patches and improvements to Debian
>> packaging, which I hope Cosimo will accept for the next release.
>>
>> Thank you in advance for any feedback!

-- 
With best regards,
Dmitry