[Jnode-svn-commits] SF.net SVN: jnode:[5722] trunk/core/src/core/org/jnode

[<ls...@us...>]

Revision: 5722
          http://jnode.svn.sourceforge.net/jnode/?rev=5722&view=rev
Author:   lsantha
Date:     2010-01-30 20:55:58 +0000 (Sat, 30 Jan 2010)

Log Message:
-----------
Findbugs fixes: fields made final.

Modified Paths:
--------------
    trunk/core/src/core/org/jnode/assembler/x86/X86Constants.java
    trunk/core/src/core/org/jnode/boot/Main.java
    trunk/core/src/core/org/jnode/vm/memmgr/VmHeapManager.java
    trunk/core/src/core/org/jnode/vm/memmgr/def/DefaultHeapManager.java

Modified: trunk/core/src/core/org/jnode/assembler/x86/X86Constants.java
===================================================================
--- trunk/core/src/core/org/jnode/assembler/x86/X86Constants.java	2010-01-30 20:55:18 UTC (rev 5721)
+++ trunk/core/src/core/org/jnode/assembler/x86/X86Constants.java	2010-01-30 20:55:58 UTC (rev 5722)
@@ -176,12 +176,12 @@
         /**
          * Use 32-bit code
          */
-        public static Mode CODE32 = new Mode(BITS32);
+        public static final Mode CODE32 = new Mode(BITS32);
 
         /**
          * Use 64-bit code
          */
-        public static Mode CODE64 = new Mode(BITS64);
+        public static final Mode CODE64 = new Mode(BITS64);
 
         private Mode(int operandSize) {
             this.operandSize = operandSize;

Modified: trunk/core/src/core/org/jnode/boot/Main.java
===================================================================
--- trunk/core/src/core/org/jnode/boot/Main.java	2010-01-30 20:55:18 UTC (rev 5721)
+++ trunk/core/src/core/org/jnode/boot/Main.java	2010-01-30 20:55:58 UTC (rev 5722)
@@ -46,7 +46,10 @@
     public static final String MAIN_METHOD_SIGNATURE = "()I";
     public static final String REGISTRY_FIELD_NAME = "pluginRegistry";
 
-    protected static PluginRegistryModel pluginRegistry;
+    /**
+     *  Initialized in org.jnode.build.x86.BootImageBuilder.initMain().
+     */
+    private static PluginRegistryModel pluginRegistry;
 
     /**
      * First java entry point after the assembler kernel has booted.

Modified: trunk/core/src/core/org/jnode/vm/memmgr/VmHeapManager.java
===================================================================
--- trunk/core/src/core/org/jnode/vm/memmgr/VmHeapManager.java	2010-01-30 20:55:18 UTC (rev 5721)
+++ trunk/core/src/core/org/jnode/vm/memmgr/VmHeapManager.java	2010-01-30 20:55:58 UTC (rev 5722)
@@ -46,12 +46,12 @@
 @MagicPermission
 public abstract class VmHeapManager extends VmSystemObject {
 
-    public static int TRACE_BASIC = 1;   // enable basic debugging of GC phases
-    public static int TRACE_ALLOC = 2;   // enable debugging of GC internal allocation
-    public static int TRACE_TRIGGER = 4;   // enable debugging of GC triggering / scheduling
-    public static int TRACE_OOM = 8;   // enable debugging of OOM events
-    public static int TRACE_AD_HOC = 16;  // enable ad hoc debugging
-    public static int TRACE_FLAGS = 31;  // all of the above
+    public static final int TRACE_BASIC = 1;   // enable basic debugging of GC phases
+    public static final int TRACE_ALLOC = 2;   // enable debugging of GC internal allocation
+    public static final int TRACE_TRIGGER = 4;   // enable debugging of GC triggering / scheduling
+    public static final int TRACE_OOM = 8;   // enable debugging of OOM events
+    public static final int TRACE_AD_HOC = 16;  // enable ad hoc debugging
+    public static final int TRACE_FLAGS = 31;  // all of the above
 
     /**
      * Has this manager been initialized yet

Modified: trunk/core/src/core/org/jnode/vm/memmgr/def/DefaultHeapManager.java
===================================================================
--- trunk/core/src/core/org/jnode/vm/memmgr/def/DefaultHeapManager.java	2010-01-30 20:55:18 UTC (rev 5721)
+++ trunk/core/src/core/org/jnode/vm/memmgr/def/DefaultHeapManager.java	2010-01-30 20:55:58 UTC (rev 5722)
@@ -56,7 +56,7 @@
      * When this percentage of the free memory has been allocated, a GC is
      * triggered (0..1.0)
      */
-    public static float GC_TRIGGER_PERCENTAGE = 0.75f;
+    public static final float GC_TRIGGER_PERCENTAGE = 0.75f;
 
     /**
      * The boot heap


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.