Menu
▾
▴
jnode-svn-commits
|
From: <ga...@us...> - 2009-07-30 14:06:17
|
Revision: 5625
http://jnode.svn.sourceforge.net/jnode/?rev=5625&view=rev
Author: galatnm
Date: 2009-07-30 14:06:07 +0000 (Thu, 30 Jul 2009)
Log Message:
-----------
Refactor fdisk command.
.- Better use of PartitionHelper class.
.- Automatically create MBR and empty partition table if no MBR exists.
Modified Paths:
--------------
trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java
trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java
trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java
Modified: trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java 2009-07-30 12:32:50 UTC (rev 5624)
+++ trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java 2009-07-30 14:06:07 UTC (rev 5625)
@@ -17,12 +17,11 @@
* along with this library; If not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
-
+
package org.jnode.partitions.command;
import java.io.IOException;
import java.io.PrintWriter;
-import java.nio.ByteBuffer;
import java.util.Collection;
import java.util.List;
@@ -37,7 +36,6 @@
import org.jnode.naming.InitialNaming;
import org.jnode.partitions.ibm.IBMPartitionTable;
import org.jnode.partitions.ibm.IBMPartitionTableEntry;
-import org.jnode.partitions.ibm.IBMPartitionTableType;
import org.jnode.partitions.ibm.IBMPartitionTypes;
import org.jnode.shell.AbstractCommand;
import org.jnode.shell.syntax.Argument;
@@ -53,183 +51,168 @@
* @author cr...@jn...
*/
public class FdiskCommand extends AbstractCommand {
- // FIXME ... this is a dangerous command and it needs some extra checking to help
- // avoid catastrophic errors. At the very least, it needs a mode that shows the
- // user what would happen but does nothing.
- private final FlagArgument FLAG_INIT_MBR = new FlagArgument(
- "initMBR", Argument.OPTIONAL, "if set, init the device's Master Boot Record");
+ // FIXME ... this is a dangerous command and it needs some extra checking to help
+ // avoid catastrophic errors. At the very least, it needs a mode that shows the
+ // user what would happen but does nothing.
+ private final FlagArgument FLAG_INIT_MBR = new FlagArgument(
+ "initMBR", Argument.OPTIONAL, "if set, init the device's Master Boot Record");
- private final FlagArgument FLAG_DELETE = new FlagArgument(
- "delete", Argument.OPTIONAL, "if set, delete a partition");
+ private final FlagArgument FLAG_DELETE = new FlagArgument(
+ "delete", Argument.OPTIONAL, "if set, delete a partition");
- private final FlagArgument FLAG_BOOTABLE = new FlagArgument(
- "bootable", Argument.OPTIONAL, "if set, toggle the partition's bootable flag");
+ private final FlagArgument FLAG_BOOTABLE = new FlagArgument(
+ "bootable", Argument.OPTIONAL, "if set, toggle the partition's bootable flag");
- private final FlagArgument FLAG_MODIFY = new FlagArgument(
- "modify", Argument.OPTIONAL, "if set, modify or create a partition");
+ private final FlagArgument FLAG_MODIFY = new FlagArgument(
+ "modify", Argument.OPTIONAL, "if set, modify or create a partition");
- private final IntegerArgument ARG_PARTITION = new IntegerArgument(
- "partition", Argument.OPTIONAL, "Target partition number (0..3)");
+ private final IntegerArgument ARG_PARTITION = new IntegerArgument(
+ "partition", Argument.OPTIONAL, "Target partition number (0..3)");
- private final LongArgument ARG_START = new LongArgument(
- "start", Argument.OPTIONAL, "Partition start sector");
+ private final LongArgument ARG_START = new LongArgument(
+ "start", Argument.OPTIONAL, "Partition start sector");
- private final LongArgument ARG_SECTORS = new LongArgument(
- "sectors", Argument.OPTIONAL, "Partition size in sectors");
+ private final LongArgument ARG_SECTORS = new LongArgument(
+ "sectors", Argument.OPTIONAL, "Partition size in sectors");
- private final SizeArgument ARG_BYTES = new SizeArgument(
- "bytes", Argument.OPTIONAL, "Partition size in bytes (300K, 45M, etc)");
+ private final SizeArgument ARG_BYTES = new SizeArgument(
+ "bytes", Argument.OPTIONAL, "Partition size in bytes (300K, 45M, etc)");
- private final IBMPartitionTypeArgument ARG_TYPE = new IBMPartitionTypeArgument(
- "type", Argument.OPTIONAL, "IBM partition type code");
+ private final IBMPartitionTypeArgument ARG_TYPE = new IBMPartitionTypeArgument(
+ "type", Argument.OPTIONAL, "IBM partition type code");
- private final DeviceArgument ARG_DEVICE = new DeviceArgument(
- "deviceId", Argument.OPTIONAL, "Target device", BlockDeviceAPI.class);
+ private final DeviceArgument ARG_DEVICE = new DeviceArgument(
+ "deviceId", Argument.OPTIONAL, "Target device", BlockDeviceAPI.class);
- public FdiskCommand() {
- super("perform disk partition management tasks");
- registerArguments(FLAG_BOOTABLE, FLAG_DELETE, FLAG_INIT_MBR, FLAG_MODIFY,
- ARG_DEVICE, ARG_PARTITION, ARG_START, ARG_SECTORS, ARG_BYTES, ARG_TYPE);
- }
+ public FdiskCommand() {
+ super("perform disk partition management tasks");
+ registerArguments(FLAG_BOOTABLE, FLAG_DELETE, FLAG_INIT_MBR, FLAG_MODIFY,
+ ARG_DEVICE, ARG_PARTITION, ARG_START, ARG_SECTORS, ARG_BYTES, ARG_TYPE);
+ }
- public static void main(String[] args) throws Exception {
- new FdiskCommand().execute(args);
- }
+ public static void main(String[] args) throws Exception {
+ new FdiskCommand().execute(args);
+ }
- public void execute() throws Exception {
- final DeviceManager dm = InitialNaming.lookup(DeviceManager.NAME);
- PrintWriter out = getOutput().getPrintWriter();
- PrintWriter err = getError().getPrintWriter();
- if (!ARG_DEVICE.isSet()) {
- // Show all devices.
- listAvailableDevices(dm, out);
- return;
- }
+ public void execute() throws Exception {
+ final DeviceManager dm = InitialNaming.lookup(DeviceManager.NAME);
+ PrintWriter out = getOutput().getPrintWriter();
+ PrintWriter err = getError().getPrintWriter();
+ if (!ARG_DEVICE.isSet()) {
+ // Show all devices.
+ listAvailableDevices(dm, out);
+ return;
+ }
- Device dev = ARG_DEVICE.getValue();
- // FIXME PartitionHelper assumes that the device is an IDE device !?!
- if (!(dev instanceof IDEDevice)) {
- err.println(dev.getId() + " is not an IDE device");
- exit(1);
- }
- final PartitionHelper helper = new PartitionHelper(dev.getId(), out);
+ Device dev = ARG_DEVICE.getValue();
+ // FIXME PartitionHelper assumes that the device is an IDE device !?!
+ if (!(dev instanceof IDEDevice)) {
+ err.println(dev.getId() + " is not an IDE device");
+ exit(1);
+ }
+ final PartitionHelper helper = new PartitionHelper(dev.getId(), out);
+ try{
+ helper.checkMBR();
+ } catch (IOException ioex){
+ out.println(ioex.getMessage());
+ out.println("Create a new MBR with a valid partition table.");
+ helper.initMbr();
+ helper.write();
+ }
- if (FLAG_BOOTABLE.isSet()) {
- helper.toggleBootable(getPartitionNumber(helper));
- helper.write();
- } else if (FLAG_DELETE.isSet()) {
- helper.deletePartition(getPartitionNumber(helper));
- helper.write();
- } else if (FLAG_MODIFY.isSet()) {
- modifyPartition(helper, getPartitionNumber(helper), out);
- helper.write();
- } else if (FLAG_INIT_MBR.isSet()) {
- helper.initMbr();
- helper.write();
- } else {
- printPartitionTable(dev, out);
- }
- }
+ if (FLAG_BOOTABLE.isSet()) {
+ helper.toggleBootable(getPartitionNumber(helper));
+ helper.write();
+ } else if (FLAG_DELETE.isSet()) {
+ helper.deletePartition(getPartitionNumber(helper));
+ helper.write();
+ } else if (FLAG_MODIFY.isSet()) {
+ modifyPartition(helper, getPartitionNumber(helper), out);
+ helper.write();
+ } else if (FLAG_INIT_MBR.isSet()) {
+ helper.initMbr();
+ helper.write();
+ } else {
+ printPartitionTable(helper, out);
+ }
+ }
- private int getPartitionNumber(PartitionHelper helper) {
- int partNumber = ARG_PARTITION.getValue();
- if (partNumber >= helper.getNbPartitions() || partNumber < 0) {
- throw new IllegalArgumentException("Partition number is invalid");
- }
- return partNumber;
- }
+ private int getPartitionNumber(PartitionHelper helper) {
+ int partNumber = ARG_PARTITION.getValue();
+ if (partNumber >= helper.getNbPartitions() || partNumber < 0) {
+ throw new IllegalArgumentException("Partition number is invalid");
+ }
+ return partNumber;
+ }
- private void modifyPartition(PartitionHelper helper, int id, PrintWriter out) throws IOException {
- long start = ARG_START.getValue();
- long size = ARG_SECTORS.isSet() ? ARG_SECTORS.getValue() : ARG_BYTES.getValue();
- IBMPartitionTypes type = ARG_TYPE.getValue();
+ private void modifyPartition(PartitionHelper helper, int id, PrintWriter out) throws IOException {
+ long start = ARG_START.getValue();
+ long size = ARG_SECTORS.isSet() ? ARG_SECTORS.getValue() : ARG_BYTES.getValue();
+ IBMPartitionTypes type = ARG_TYPE.getValue();
- out.println("Init " + id + " with start = " + start
- + ", size = " + size + ", fs = "
- + Integer.toHexString(type.getCode()));
- boolean sizeUnit = ARG_BYTES.isSet() ?
- PartitionHelper.BYTES : PartitionHelper.SECTORS;
- helper.modifyPartition(id, false, start, size, sizeUnit, type);
- }
+ out.println("Init " + id + " with start = " + start
+ + ", size = " + size + ", fs = "
+ + Integer.toHexString(type.getCode()));
+ boolean sizeUnit = ARG_BYTES.isSet() ?
+ PartitionHelper.BYTES : PartitionHelper.SECTORS;
+ helper.modifyPartition(id, false, start, size, sizeUnit, type);
+ }
- private void printPartitionTable(Device dev, PrintWriter out)
- throws DeviceNotFoundException, ApiNotFoundException, IOException {
- IDEDevice ideDev = null;
- // FIXME ... this needs to be generalized to other disc device types.
- if (dev instanceof IDEDevice) {
- ideDev = (IDEDevice) dev;
- }
- BlockDeviceAPI api = dev.getAPI(BlockDeviceAPI.class);
- IDEDriveDescriptor descriptor = ideDev.getDescriptor();
- int sectorSize = IDEConstants.SECTOR_SIZE;
- ByteBuffer MBR = ByteBuffer.allocate(sectorSize);
- api.read(0, MBR);
- if (IBMPartitionTable.containsPartitionTable(MBR.array())) {
- IBMPartitionTable partitionTable =
- new IBMPartitionTable(new IBMPartitionTableType(), MBR.array(), dev);
- if (ideDev != null) {
- out.println("IDE Disk : " + dev.getId() + ": " +
- descriptor.getSectorsIn28bitAddressing() * 512 + " bytes");
- }
- out.println("Device Boot Start End Blocks System");
+ private void printPartitionTable(PartitionHelper helper, PrintWriter out)
+ throws DeviceNotFoundException, ApiNotFoundException, IOException {
+ IDEDevice ideDev = helper.getDevice();
+ IDEDriveDescriptor descriptor = ideDev.getDescriptor();
+ int sectorSize = IDEConstants.SECTOR_SIZE;
+ if (ideDev != null) {
+ out.println("IDE Disk : " + ideDev.getId() + ": " +
+ descriptor.getSectorsIn28bitAddressing() * 512 + " bytes");
+ }
+ out.println("Device Boot Start End Blocks System");
+ IBMPartitionTable partitionTable = helper.getPartitionTable();
+ int i = 0;
+ for(IBMPartitionTableEntry entry : partitionTable){
+ IBMPartitionTypes si = entry.getSystemIndicator();
+ if (!entry.isEmpty()) {
+ long sectors = entry.getNrSectors();
- int i = 0;
- for (IBMPartitionTableEntry entry : partitionTable) {
- IBMPartitionTypes si = entry.getSystemIndicator();
- if (si != IBMPartitionTypes.PARTTYPE_EMPTY) {
- // Calculate number of blocks
- long sectors = entry.getNrSectors();
- long blocks = sectors;
- long odd = 0;
+ out.println("ID " + i + " " +
+ (entry.getBootIndicator() ? "Boot" : "No") + " " +
+ entry.getStartLba() + " " +
+ (entry.getStartLba() + sectors) + " " +
+ entry.getNbrBlocks(sectorSize) + (entry.isOdd()?"":"+") + " " + si);
+ }
+ if (entry.isExtended()) {
+ final List<IBMPartitionTableEntry> exPartitions = partitionTable.getExtendedPartitions();
+ int j = 0;
+ for (IBMPartitionTableEntry exEntry : exPartitions) {
+ si = exEntry.getSystemIndicator();
+ // FIXME ... this needs work
+ out.println("ID " + i + " " +
+ (exEntry.getBootIndicator() ? "Boot" : "No") + " " +
+ exEntry.getStartLba() + " " +
+ "-----" /* (exEntry.getStartLba() + entry.getNrSectors()) */ + " " +
+ "-----" /* exEntry.getNrSectors() */ + " " + si);
+ j++;
+ }
+ }
+ i++;
+ }
+ }
- if (sectorSize < 1024) {
- blocks /= (1024 / sectorSize);
- odd = sectors % (1024 / sectorSize);
- } else {
- blocks *= (sectorSize / 1024);
- }
-
- out.println("ID " + i + " " +
- (entry.getBootIndicator() ? "Boot" : "No") + " " +
- entry.getStartLba() + " " +
- (entry.getStartLba() + sectors) + " " +
- blocks + ((odd!=0)?"+":"") + " " + si);
- }
- if (entry.isExtended()) {
- final List<IBMPartitionTableEntry> exPartitions = partitionTable.getExtendedPartitions();
- int j = 0;
- for (IBMPartitionTableEntry exEntry : exPartitions) {
- si = exEntry.getSystemIndicator();
- // FIXME ... this needs work
- out.println("ID " + i + " " +
- (exEntry.getBootIndicator() ? "Boot" : "No") + " " +
- exEntry.getStartLba() + " " +
- "-----" /* (exEntry.getStartLba() + entry.getNrSectors()) */ + " " +
- "-----" /* exEntry.getNrSectors() */ + " " + si);
- j++;
- }
- }
- i++;
- }
- } else {
- out.println(" No valid MBR found on this device. Use --initMBR to initialize it.");
- }
- }
-
- private void listAvailableDevices(DeviceManager dm, PrintWriter out) {
- final Collection<Device> allDevices = dm.getDevicesByAPI(BlockDeviceAPI.class);
- for (Device dev : allDevices) {
- out.println("Found device : " + dev.getId() + "[" + dev.getClass() + "]");
- if (dev instanceof IDEDevice) {
- IDEDevice ideDevice = (IDEDevice) dev;
- IDEDriveDescriptor desc = ideDevice.getDescriptor();
- if (desc.isDisk()) {
- out.println(" IDE Disk : " + ideDevice.getId() +
- "(" + desc.getModel() + " " +
- desc.getSectorsIn28bitAddressing() * IDEConstants.SECTOR_SIZE + ")");
- }
- }
- }
- }
+ private void listAvailableDevices(DeviceManager dm, PrintWriter out) {
+ final Collection<Device> allDevices = dm.getDevicesByAPI(BlockDeviceAPI.class);
+ for (Device dev : allDevices) {
+ out.println("Found device : " + dev.getId() + "[" + dev.getClass() + "]");
+ if (dev instanceof IDEDevice) {
+ IDEDevice ideDevice = (IDEDevice) dev;
+ IDEDriveDescriptor desc = ideDevice.getDescriptor();
+ if (desc.isDisk()) {
+ out.println(" IDE Disk : " + ideDevice.getId() +
+ "(" + desc.getModel() + " " +
+ desc.getSectorsIn28bitAddressing() * IDEConstants.SECTOR_SIZE + ")");
+ }
+ }
+ }
+ }
}
Modified: trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java 2009-07-30 12:32:50 UTC (rev 5624)
+++ trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java 2009-07-30 14:06:07 UTC (rev 5625)
@@ -35,7 +35,9 @@
import org.jnode.driver.bus.ide.IDEDevice;
import org.jnode.fs.fat.BootSector;
import org.jnode.fs.fat.GrubBootSector;
+import org.jnode.partitions.ibm.IBMPartitionTable;
import org.jnode.partitions.ibm.IBMPartitionTableEntry;
+import org.jnode.partitions.ibm.IBMPartitionTableType;
import org.jnode.partitions.ibm.IBMPartitionTypes;
import org.jnode.partitions.ibm.MasterBootRecord;
@@ -69,6 +71,10 @@
reloadMBR();
}
+ public IDEDevice getDevice(){
+ return current;
+ }
+
public void initMbr() throws DeviceNotFoundException, ApiNotFoundException, IOException {
out.println("Initialize MBR ...");
@@ -89,8 +95,6 @@
bs.getPartition(2).setSystemIndicator(IBMPartitionTypes.PARTTYPE_EMPTY);
bs.getPartition(3).setSystemIndicator(IBMPartitionTypes.PARTTYPE_EMPTY);
}
-
- // reloadMBR();
}
public void write() throws IOException, Exception {
@@ -117,11 +121,23 @@
bs = new BootSector(MBR.array());
}
- private void checkMBR() throws IOException {
+ public void checkMBR() throws IOException {
if (!MBR.containsPartitionTable())
- throw new IOException("This device doesn't contain a valid MBR, use --initmbr.");
+ throw new IOException("This device doesn't contain a valid partition table.");
}
+
+ public IBMPartitionTable getPartitionTable(){
+ return new IBMPartitionTable(new IBMPartitionTableType(), MBR.array(), current);
+ }
+ public int getNbPartitions() {
+ return bs.getNbPartitions();
+ }
+
+ public IBMPartitionTableEntry getPartition(int partNr) {
+ return bs.getPartition(partNr);
+ }
+
public void modifyPartition(int id, boolean bootIndicator, long start, long size,
boolean sizeUnit, IBMPartitionTypes fs) throws IOException {
checkMBR();
@@ -141,9 +157,7 @@
entry.setNrSectors(nbSectors);
}
- public int getNbPartitions() {
- return bs.getNbPartitions();
- }
+
public void deletePartition(int partNumber) throws IOException {
checkMBR();
Modified: trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java 2009-07-30 12:32:50 UTC (rev 5624)
+++ trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java 2009-07-30 14:06:07 UTC (rev 5625)
@@ -32,6 +32,7 @@
private final byte[] bs;
private final int ofs;
+ private long odd;
@SuppressWarnings("unused")
private final IBMPartitionTable parent;
@@ -137,6 +138,23 @@
public void setNrSectors(long v) {
LittleEndian.setInt32(bs, ofs + 12, (int) v);
}
+
+ public long getNbrBlocks(int sectorSize){
+ long sectors = getNrSectors();
+ long blocks = sectors;
+ if (sectorSize < 1024) {
+ blocks /= (1024 / sectorSize);
+ odd = getNrSectors() % (1024 / sectorSize);
+ } else {
+ blocks *= (sectorSize / 1024);
+ }
+ return blocks;
+ }
+
+ public boolean isOdd(){
+ return odd!=0;
+ }
+
public void clear() {
for (int i = 0; i < 16; i++) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ga...@us...> - 2009-08-10 21:32:06
|
Revision: 5637
http://jnode.svn.sourceforge.net/jnode/?rev=5637&view=rev
Author: galatnm
Date: 2009-08-10 21:31:59 +0000 (Mon, 10 Aug 2009)
Log Message:
-----------
CheckStyle.
Modified Paths:
--------------
trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java
trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java
trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java
Modified: trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java 2009-08-10 21:17:38 UTC (rev 5636)
+++ trunk/fs/src/fs/org/jnode/partitions/command/FdiskCommand.java 2009-08-10 21:31:59 UTC (rev 5637)
@@ -51,168 +51,167 @@
* @author cr...@jn...
*/
public class FdiskCommand extends AbstractCommand {
- // FIXME ... this is a dangerous command and it needs some extra checking to help
- // avoid catastrophic errors. At the very least, it needs a mode that shows the
- // user what would happen but does nothing.
- private final FlagArgument FLAG_INIT_MBR = new FlagArgument(
- "initMBR", Argument.OPTIONAL, "if set, init the device's Master Boot Record");
+ // FIXME ... this is a dangerous command and it needs some extra checking to
+ // help
+ // avoid catastrophic errors. At the very least, it needs a mode that shows
+ // the
+ // user what would happen but does nothing.
+ private final FlagArgument FLAG_INIT_MBR =
+ new FlagArgument("initMBR", Argument.OPTIONAL,
+ "if set, init the device's Master Boot Record");
- private final FlagArgument FLAG_DELETE = new FlagArgument(
- "delete", Argument.OPTIONAL, "if set, delete a partition");
+ private final FlagArgument FLAG_DELETE =
+ new FlagArgument("delete", Argument.OPTIONAL, "if set, delete a partition");
- private final FlagArgument FLAG_BOOTABLE = new FlagArgument(
- "bootable", Argument.OPTIONAL, "if set, toggle the partition's bootable flag");
+ private final FlagArgument FLAG_BOOTABLE =
+ new FlagArgument("bootable", Argument.OPTIONAL,
+ "if set, toggle the partition's bootable flag");
- private final FlagArgument FLAG_MODIFY = new FlagArgument(
- "modify", Argument.OPTIONAL, "if set, modify or create a partition");
+ private final FlagArgument FLAG_MODIFY =
+ new FlagArgument("modify", Argument.OPTIONAL, "if set, modify or create a partition");
- private final IntegerArgument ARG_PARTITION = new IntegerArgument(
- "partition", Argument.OPTIONAL, "Target partition number (0..3)");
+ private final IntegerArgument ARG_PARTITION =
+ new IntegerArgument("partition", Argument.OPTIONAL, "Target partition number (0..3)");
- private final LongArgument ARG_START = new LongArgument(
- "start", Argument.OPTIONAL, "Partition start sector");
+ private final LongArgument ARG_START =
+ new LongArgument("start", Argument.OPTIONAL, "Partition start sector");
- private final LongArgument ARG_SECTORS = new LongArgument(
- "sectors", Argument.OPTIONAL, "Partition size in sectors");
+ private final LongArgument ARG_SECTORS =
+ new LongArgument("sectors", Argument.OPTIONAL, "Partition size in sectors");
- private final SizeArgument ARG_BYTES = new SizeArgument(
- "bytes", Argument.OPTIONAL, "Partition size in bytes (300K, 45M, etc)");
+ private final SizeArgument ARG_BYTES =
+ new SizeArgument("bytes", Argument.OPTIONAL, "Partition size in bytes (300K, 45M, etc)");
- private final IBMPartitionTypeArgument ARG_TYPE = new IBMPartitionTypeArgument(
- "type", Argument.OPTIONAL, "IBM partition type code");
+ private final IBMPartitionTypeArgument ARG_TYPE =
+ new IBMPartitionTypeArgument("type", Argument.OPTIONAL, "IBM partition type code");
- private final DeviceArgument ARG_DEVICE = new DeviceArgument(
- "deviceId", Argument.OPTIONAL, "Target device", BlockDeviceAPI.class);
+ private final DeviceArgument ARG_DEVICE =
+ new DeviceArgument("deviceId", Argument.OPTIONAL, "Target device", BlockDeviceAPI.class);
+ public FdiskCommand() {
+ super("perform disk partition management tasks");
+ registerArguments(FLAG_BOOTABLE, FLAG_DELETE, FLAG_INIT_MBR, FLAG_MODIFY, ARG_DEVICE,
+ ARG_PARTITION, ARG_START, ARG_SECTORS, ARG_BYTES, ARG_TYPE);
+ }
- public FdiskCommand() {
- super("perform disk partition management tasks");
- registerArguments(FLAG_BOOTABLE, FLAG_DELETE, FLAG_INIT_MBR, FLAG_MODIFY,
- ARG_DEVICE, ARG_PARTITION, ARG_START, ARG_SECTORS, ARG_BYTES, ARG_TYPE);
- }
+ public static void main(String[] args) throws Exception {
+ new FdiskCommand().execute(args);
+ }
- public static void main(String[] args) throws Exception {
- new FdiskCommand().execute(args);
- }
+ public void execute() throws Exception {
+ final DeviceManager dm = InitialNaming.lookup(DeviceManager.NAME);
+ PrintWriter out = getOutput().getPrintWriter();
+ PrintWriter err = getError().getPrintWriter();
+ if (!ARG_DEVICE.isSet()) {
+ // Show all devices.
+ listAvailableDevices(dm, out);
+ return;
+ }
- public void execute() throws Exception {
- final DeviceManager dm = InitialNaming.lookup(DeviceManager.NAME);
- PrintWriter out = getOutput().getPrintWriter();
- PrintWriter err = getError().getPrintWriter();
- if (!ARG_DEVICE.isSet()) {
- // Show all devices.
- listAvailableDevices(dm, out);
- return;
- }
+ Device dev = ARG_DEVICE.getValue();
+ // FIXME PartitionHelper assumes that the device is an IDE device !?!
+ if (!(dev instanceof IDEDevice)) {
+ err.println(dev.getId() + " is not an IDE device");
+ exit(1);
+ }
+ final PartitionHelper helper = new PartitionHelper(dev.getId(), out);
+ try {
+ helper.checkMBR();
+ } catch (IOException ioex) {
+ out.println(ioex.getMessage());
+ out.println("Create a new MBR with a valid partition table.");
+ helper.initMbr();
+ helper.write();
+ }
- Device dev = ARG_DEVICE.getValue();
- // FIXME PartitionHelper assumes that the device is an IDE device !?!
- if (!(dev instanceof IDEDevice)) {
- err.println(dev.getId() + " is not an IDE device");
- exit(1);
- }
- final PartitionHelper helper = new PartitionHelper(dev.getId(), out);
- try{
- helper.checkMBR();
- } catch (IOException ioex){
- out.println(ioex.getMessage());
- out.println("Create a new MBR with a valid partition table.");
- helper.initMbr();
- helper.write();
- }
+ if (FLAG_BOOTABLE.isSet()) {
+ helper.toggleBootable(getPartitionNumber(helper));
+ helper.write();
+ } else if (FLAG_DELETE.isSet()) {
+ helper.deletePartition(getPartitionNumber(helper));
+ helper.write();
+ } else if (FLAG_MODIFY.isSet()) {
+ modifyPartition(helper, getPartitionNumber(helper), out);
+ helper.write();
+ } else if (FLAG_INIT_MBR.isSet()) {
+ helper.initMbr();
+ helper.write();
+ } else {
+ printPartitionTable(helper, out);
+ }
+ }
- if (FLAG_BOOTABLE.isSet()) {
- helper.toggleBootable(getPartitionNumber(helper));
- helper.write();
- } else if (FLAG_DELETE.isSet()) {
- helper.deletePartition(getPartitionNumber(helper));
- helper.write();
- } else if (FLAG_MODIFY.isSet()) {
- modifyPartition(helper, getPartitionNumber(helper), out);
- helper.write();
- } else if (FLAG_INIT_MBR.isSet()) {
- helper.initMbr();
- helper.write();
- } else {
- printPartitionTable(helper, out);
- }
- }
+ private int getPartitionNumber(PartitionHelper helper) {
+ int partNumber = ARG_PARTITION.getValue();
+ if (partNumber >= helper.getNbPartitions() || partNumber < 0) {
+ throw new IllegalArgumentException("Partition number is invalid");
+ }
+ return partNumber;
+ }
- private int getPartitionNumber(PartitionHelper helper) {
- int partNumber = ARG_PARTITION.getValue();
- if (partNumber >= helper.getNbPartitions() || partNumber < 0) {
- throw new IllegalArgumentException("Partition number is invalid");
- }
- return partNumber;
- }
+ private void modifyPartition(PartitionHelper helper, int id, PrintWriter out)
+ throws IOException {
+ long start = ARG_START.getValue();
+ long size = ARG_SECTORS.isSet() ? ARG_SECTORS.getValue() : ARG_BYTES.getValue();
+ IBMPartitionTypes type = ARG_TYPE.getValue();
- private void modifyPartition(PartitionHelper helper, int id, PrintWriter out) throws IOException {
- long start = ARG_START.getValue();
- long size = ARG_SECTORS.isSet() ? ARG_SECTORS.getValue() : ARG_BYTES.getValue();
- IBMPartitionTypes type = ARG_TYPE.getValue();
+ out.println("Init " + id + " with start = " + start + ", size = " + size + ", fs = " +
+ Integer.toHexString(type.getCode()));
+ boolean sizeUnit = ARG_BYTES.isSet() ? PartitionHelper.BYTES : PartitionHelper.SECTORS;
+ helper.modifyPartition(id, false, start, size, sizeUnit, type);
+ }
- out.println("Init " + id + " with start = " + start
- + ", size = " + size + ", fs = "
- + Integer.toHexString(type.getCode()));
- boolean sizeUnit = ARG_BYTES.isSet() ?
- PartitionHelper.BYTES : PartitionHelper.SECTORS;
- helper.modifyPartition(id, false, start, size, sizeUnit, type);
- }
+ private void printPartitionTable(PartitionHelper helper, PrintWriter out)
+ throws DeviceNotFoundException, ApiNotFoundException, IOException {
+ IDEDevice ideDev = helper.getDevice();
+ IDEDriveDescriptor descriptor = ideDev.getDescriptor();
+ int sectorSize = IDEConstants.SECTOR_SIZE;
+ if (ideDev != null) {
+ out.println("IDE Disk : " + ideDev.getId() + ": " +
+ descriptor.getSectorsIn28bitAddressing() * 512 + " bytes");
+ }
+ out.println("Device Boot Start End Blocks System");
+ IBMPartitionTable partitionTable = helper.getPartitionTable();
+ int i = 0;
+ for (IBMPartitionTableEntry entry : partitionTable) {
+ IBMPartitionTypes si = entry.getSystemIndicator();
+ if (!entry.isEmpty()) {
+ long sectors = entry.getNrSectors();
- private void printPartitionTable(PartitionHelper helper, PrintWriter out)
- throws DeviceNotFoundException, ApiNotFoundException, IOException {
- IDEDevice ideDev = helper.getDevice();
- IDEDriveDescriptor descriptor = ideDev.getDescriptor();
- int sectorSize = IDEConstants.SECTOR_SIZE;
- if (ideDev != null) {
- out.println("IDE Disk : " + ideDev.getId() + ": " +
- descriptor.getSectorsIn28bitAddressing() * 512 + " bytes");
- }
- out.println("Device Boot Start End Blocks System");
- IBMPartitionTable partitionTable = helper.getPartitionTable();
- int i = 0;
- for(IBMPartitionTableEntry entry : partitionTable){
- IBMPartitionTypes si = entry.getSystemIndicator();
- if (!entry.isEmpty()) {
- long sectors = entry.getNrSectors();
+ out.println("ID " + i + " " + (entry.getBootIndicator() ? "Boot" : "No") + " " +
+ entry.getStartLba() + " " + (entry.getStartLba() + sectors) + " " +
+ entry.getNbrBlocks(sectorSize) + (entry.isOdd() ? "" : "+") + " " + si);
+ }
+ if (entry.isExtended()) {
+ final List<IBMPartitionTableEntry> exPartitions =
+ partitionTable.getExtendedPartitions();
+ int j = 0;
+ for (IBMPartitionTableEntry exEntry : exPartitions) {
+ si = exEntry.getSystemIndicator();
+ // FIXME ... this needs work
+ out.println("ID " + i + " " + (exEntry.getBootIndicator() ? "Boot" : "No") +
+ " " + exEntry.getStartLba() + " " + "-----" + " " + "-----" +
+ " " + si);
+ j++;
+ }
+ }
+ i++;
+ }
+ }
- out.println("ID " + i + " " +
- (entry.getBootIndicator() ? "Boot" : "No") + " " +
- entry.getStartLba() + " " +
- (entry.getStartLba() + sectors) + " " +
- entry.getNbrBlocks(sectorSize) + (entry.isOdd()?"":"+") + " " + si);
- }
- if (entry.isExtended()) {
- final List<IBMPartitionTableEntry> exPartitions = partitionTable.getExtendedPartitions();
- int j = 0;
- for (IBMPartitionTableEntry exEntry : exPartitions) {
- si = exEntry.getSystemIndicator();
- // FIXME ... this needs work
- out.println("ID " + i + " " +
- (exEntry.getBootIndicator() ? "Boot" : "No") + " " +
- exEntry.getStartLba() + " " +
- "-----" /* (exEntry.getStartLba() + entry.getNrSectors()) */ + " " +
- "-----" /* exEntry.getNrSectors() */ + " " + si);
- j++;
- }
- }
- i++;
- }
- }
-
- private void listAvailableDevices(DeviceManager dm, PrintWriter out) {
- final Collection<Device> allDevices = dm.getDevicesByAPI(BlockDeviceAPI.class);
- for (Device dev : allDevices) {
- out.println("Found device : " + dev.getId() + "[" + dev.getClass() + "]");
- if (dev instanceof IDEDevice) {
- IDEDevice ideDevice = (IDEDevice) dev;
- IDEDriveDescriptor desc = ideDevice.getDescriptor();
- if (desc.isDisk()) {
- out.println(" IDE Disk : " + ideDevice.getId() +
- "(" + desc.getModel() + " " +
- desc.getSectorsIn28bitAddressing() * IDEConstants.SECTOR_SIZE + ")");
- }
- }
- }
- }
+ private void listAvailableDevices(DeviceManager dm, PrintWriter out) {
+ final Collection<Device> allDevices = dm.getDevicesByAPI(BlockDeviceAPI.class);
+ for (Device dev : allDevices) {
+ out.println("Found device : " + dev.getId() + "[" + dev.getClass() + "]");
+ if (dev instanceof IDEDevice) {
+ IDEDevice ideDevice = (IDEDevice) dev;
+ IDEDriveDescriptor desc = ideDevice.getDescriptor();
+ if (desc.isDisk()) {
+ out.println(" IDE Disk : " + ideDevice.getId() + "(" + desc.getModel() +
+ " " + desc.getSectorsIn28bitAddressing() * IDEConstants.SECTOR_SIZE +
+ ")");
+ }
+ }
+ }
+ }
}
Modified: trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java 2009-08-10 21:17:38 UTC (rev 5636)
+++ trunk/fs/src/fs/org/jnode/partitions/command/PartitionHelper.java 2009-08-10 21:31:59 UTC (rev 5637)
@@ -17,7 +17,7 @@
* along with this library; If not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
-
+
package org.jnode.partitions.command;
import java.io.IOException;
@@ -53,16 +53,16 @@
private final MasterBootRecord MBR;
private BootSector bs;
-
+
private final PrintWriter out;
- public PartitionHelper(String deviceId, PrintWriter out) throws DeviceNotFoundException, ApiNotFoundException,
- IOException, NameNotFoundException {
+ public PartitionHelper(String deviceId, PrintWriter out) throws DeviceNotFoundException,
+ ApiNotFoundException, IOException, NameNotFoundException {
this((IDEDevice) DeviceUtils.getDeviceManager().getDevice(deviceId), out);
}
- public PartitionHelper(IDEDevice device, PrintWriter out) throws DeviceNotFoundException, ApiNotFoundException,
- IOException {
+ public PartitionHelper(IDEDevice device, PrintWriter out) throws DeviceNotFoundException,
+ ApiNotFoundException, IOException {
this.current = device;
this.api = current.getAPI(BlockDeviceAPI.class);
this.MBR = new MasterBootRecord(api);
@@ -71,10 +71,10 @@
reloadMBR();
}
- public IDEDevice getDevice(){
- return current;
+ public IDEDevice getDevice() {
+ return current;
}
-
+
public void initMbr() throws DeviceNotFoundException, ApiNotFoundException, IOException {
out.println("Initialize MBR ...");
@@ -82,7 +82,8 @@
bs = new GrubBootSector(PLAIN_MASTER_BOOT_SECTOR);
if (MBR.containsPartitionTable()) {
- out.println("This device already contains a partition table. Copy the already existing partitions.");
+ out
+ .println("This device already contains a partition table. Copy the already existing partitions.");
for (int i = 0; i < 4; i++) {
final IBMPartitionTableEntry oldEntry = oldMBR.getPartition(i);
@@ -125,19 +126,19 @@
if (!MBR.containsPartitionTable())
throw new IOException("This device doesn't contain a valid partition table.");
}
-
- public IBMPartitionTable getPartitionTable(){
- return new IBMPartitionTable(new IBMPartitionTableType(), MBR.array(), current);
+
+ public IBMPartitionTable getPartitionTable() {
+ return new IBMPartitionTable(new IBMPartitionTableType(), MBR.array(), current);
}
public int getNbPartitions() {
return bs.getNbPartitions();
}
-
+
public IBMPartitionTableEntry getPartition(int partNr) {
- return bs.getPartition(partNr);
+ return bs.getPartition(partNr);
}
-
+
public void modifyPartition(int id, boolean bootIndicator, long start, long size,
boolean sizeUnit, IBMPartitionTypes fs) throws IOException {
checkMBR();
@@ -157,8 +158,6 @@
entry.setNrSectors(nbSectors);
}
-
-
public void deletePartition(int partNumber) throws IOException {
checkMBR();
bs.getPartition(partNumber).setSystemIndicator(IBMPartitionTypes.PARTTYPE_EMPTY);
@@ -179,8 +178,8 @@
bs.getPartition(partNumber).setBootIndicator(!currentStatus);
}
- private static final byte PLAIN_MASTER_BOOT_SECTOR[] = {
- (byte) 0xEB, (byte) 0x48, (byte) 0x90, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+ private static final byte PLAIN_MASTER_BOOT_SECTOR[] =
+ {(byte) 0xEB, (byte) 0x48, (byte) 0x90, (byte) 0x00, (byte) 0x00, (byte) 0x00,
(byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
(byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
(byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
Modified: trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java 2009-08-10 21:17:38 UTC (rev 5636)
+++ trunk/fs/src/fs/org/jnode/partitions/ibm/IBMPartitionTableEntry.java 2009-08-10 21:31:59 UTC (rev 5637)
@@ -17,7 +17,7 @@
* along with this library; If not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
-
+
package org.jnode.partitions.ibm;
import org.jnode.driver.block.CHS;
@@ -69,8 +69,7 @@
// pgwiasda
// there are more than one type of extended Partitions
return (id == IBMPartitionTypes.PARTTYPE_WIN95_FAT32_EXTENDED ||
- id == IBMPartitionTypes.PARTTYPE_LINUX_EXTENDED ||
- id == IBMPartitionTypes.PARTTYPE_DOS_EXTENDED);
+ id == IBMPartitionTypes.PARTTYPE_LINUX_EXTENDED || id == IBMPartitionTypes.PARTTYPE_DOS_EXTENDED);
}
public boolean getBootIndicator() {
@@ -138,23 +137,22 @@
public void setNrSectors(long v) {
LittleEndian.setInt32(bs, ofs + 12, (int) v);
}
-
- public long getNbrBlocks(int sectorSize){
- long sectors = getNrSectors();
- long blocks = sectors;
- if (sectorSize < 1024) {
- blocks /= (1024 / sectorSize);
- odd = getNrSectors() % (1024 / sectorSize);
- } else {
- blocks *= (sectorSize / 1024);
- }
- return blocks;
+
+ public long getNbrBlocks(int sectorSize) {
+ long sectors = getNrSectors();
+ long blocks = sectors;
+ if (sectorSize < 1024) {
+ blocks /= (1024 / sectorSize);
+ odd = getNrSectors() % (1024 / sectorSize);
+ } else {
+ blocks *= (sectorSize / 1024);
+ }
+ return blocks;
}
-
- public boolean isOdd(){
- return odd!=0;
+
+ public boolean isOdd() {
+ return odd != 0;
}
-
public void clear() {
for (int i = 0; i < 16; i++) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <ga...@us...> - 2012-08-10 06:13:24
|
Revision: 5906
http://jnode.svn.sourceforge.net/jnode/?rev=5906&view=rev
Author: galatnm
Date: 2012-08-10 06:13:18 +0000 (Fri, 10 Aug 2012)
Log Message:
-----------
Code review changes update code style
Modified Paths:
--------------
trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTable.java
trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableEntry.java
trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableType.java
trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTable.java
trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableEntry.java
trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableType.java
Modified: trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTable.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTable.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTable.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -65,8 +65,7 @@
ApmPartitionTableEntry entry = new ApmPartitionTableEntry(this, first16KiB, offset);
- if (entry.isValid())
- {
+ if (entry.isValid()) {
partitions.add(entry);
}
}
@@ -88,6 +87,7 @@
return true;
}
+ @Override
public Iterator<ApmPartitionTableEntry> iterator() {
return Collections.unmodifiableList(partitions).iterator();
}
@@ -95,6 +95,7 @@
/**
* @see org.jnode.partitions.PartitionTable#getType()
*/
+ @Override
public PartitionTableType getType() {
return tableType;
}
Modified: trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableEntry.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableEntry.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableEntry.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -51,6 +51,7 @@
this.offset = offset;
}
+ @Override
public boolean isValid() {
return first16KiB.length > offset + 128;
}
@@ -58,6 +59,7 @@
/**
* @see org.jnode.partitions.PartitionTableEntry#getChildPartitionTable()
*/
+ @Override
public IBMPartitionTable getChildPartitionTable() {
throw new UnsupportedOperationException("No child partitions.");
}
@@ -65,6 +67,7 @@
/**
* @see org.jnode.partitions.PartitionTableEntry#hasChildPartitionTable()
*/
+ @Override
public boolean hasChildPartitionTable() {
return false;
}
@@ -98,9 +101,7 @@
return b.toString();
}
- /**
- * @see Object#toString()
- */
+ @Override
public String toString() {
StringBuilder builder = new StringBuilder(32);
builder.append('[').append(getName()).append(' ');
Modified: trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableType.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableType.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/apm/ApmPartitionTableType.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -33,15 +33,18 @@
*/
public class ApmPartitionTableType implements PartitionTableType {
+ @Override
public PartitionTable<?> create(byte[] firstSector, Device device) throws PartitionTableException {
return new ApmPartitionTable(this, firstSector, device);
}
+ @Override
public String getName() {
return "APM";
}
+ @Override
public boolean supports(byte[] first16KiB, BlockDeviceAPI devApi) {
return ApmPartitionTable.containsPartitionTable(first16KiB);
}
-}
+}
\ No newline at end of file
Modified: trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTable.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTable.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTable.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -70,8 +70,7 @@
GptPartitionTableEntry entry = new GptPartitionTableEntry(this, first16KiB, offset, blockSize);
- if (entry.isValid())
- {
+ if (entry.isValid()) {
partitions.add(entry);
}
}
@@ -115,6 +114,7 @@
return detectBlockSize(first16KiB) != -1;
}
+ @Override
public Iterator<GptPartitionTableEntry> iterator() {
return Collections.unmodifiableList(partitions).iterator();
}
@@ -122,6 +122,7 @@
/**
* @see org.jnode.partitions.PartitionTable#getType()
*/
+ @Override
public PartitionTableType getType() {
return tableType;
}
Modified: trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableEntry.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableEntry.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableEntry.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -56,6 +56,7 @@
this.offset = offset;
}
+ @Override
public boolean isValid() {
return first16KiB.length > offset + 128 && !isEmpty();
}
@@ -63,6 +64,7 @@
/**
* @see org.jnode.partitions.PartitionTableEntry#getChildPartitionTable()
*/
+ @Override
public PartitionTable<?> getChildPartitionTable() {
throw new UnsupportedOperationException("No child partitions.");
}
@@ -70,6 +72,7 @@
/**
* @see org.jnode.partitions.PartitionTableEntry#hasChildPartitionTable()
*/
+ @Override
public boolean hasChildPartitionTable() {
return false;
}
@@ -117,9 +120,7 @@
return b.toString();
}
- /**
- * @see java.lang.Object#toString()
- */
+ @Override
public String toString() {
StringBuilder builder = new StringBuilder(32);
builder.append('[').append(getName()).append(' ');
Modified: trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableType.java
===================================================================
--- trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableType.java 2012-08-10 06:11:00 UTC (rev 5905)
+++ trunk/fs/src/fs/org/jnode/partitions/gpt/GptPartitionTableType.java 2012-08-10 06:13:18 UTC (rev 5906)
@@ -33,15 +33,18 @@
*/
public class GptPartitionTableType implements PartitionTableType {
+ @Override
public PartitionTable<?> create(byte[] firstSector, Device device) throws PartitionTableException {
return new GptPartitionTable(this, firstSector, device);
}
+ @Override
public String getName() {
return "EFI PART";
}
+ @Override
public boolean supports(byte[] first16KiB, BlockDeviceAPI devApi) {
return GptPartitionTable.containsPartitionTable(first16KiB);
}
-}
+}
\ No newline at end of file
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X