Menu

#1074 Add EM-18 RFID Protocol

closed
RFID Update (1)
(none)
5
2015-10-08
2015-09-09
Oscar
No

I created an RFID protocol for the EM-18 RFID reader and updated the SerialDriverAdapter file. I've attached the files. I probably don't need to say, but the em18 folder goes in the rfid protocol folder.

These have been tested on my live system and work just fine. If there is anything I should do different, please let me know.

Thanks,
Oscar

1 Attachments

Discussion

  • Matthew Harris

    Matthew Harris - 2015-09-09
    • assigned_to: Matthew Harris
     
  • Matthew Harris

    Matthew Harris - 2015-09-09

    Oscar,

    Unfortunately, the attached files are the compiled .class files - as they stand, these cannot be integrated.

    What is needed is the source code, ideally as a .patch (or .diff) file.

    Many thanks.

    Best regards,

    Matt H

     
  • Matthew Harris

    Matthew Harris - 2015-09-09

    The following might help with generating the .patch / .diff file from Eclipse:

    https://asudev.jira.com/wiki/pages/viewpage.action?pageId=168755658

    Alternatively, just send the relevant .java files and I can sort it out (but it's rather more work).

    Many thanks again for your contribution.

    Best regards,

    Matt H

     

    Last edit: Matthew Harris 2015-09-09
  • Oscar

    Oscar - 2015-09-09

    Thanks! That's what I was missing. I saw that for netbeans on the JMRI site but not for eclipse. It's creating the patch file now and I'll upload it shortly.

     
  • Oscar

    Oscar - 2015-09-09

    Here's the patch file :)

     
  • Matthew Harris

    Matthew Harris - 2015-09-09

    Thanks Oscar - I'll review it and get it incorporated.

    Also, for correct attribution, could I have your full name please?

    Best regards,

    Matt H

     
  • Oscar

    Oscar - 2015-09-09

    Oscar A. Pruitt

    Also, if there is anything I need to do different just let me know. I take constructive critisism pretty well. I tried to follow the JMRI web site instructions as far as they'd take me but there's a lot of info out there and it's a bit scattered and somewhat confusing sometimes :)

    Thanks

     

    Last edit: Oscar 2015-09-09
  • Matthew Harris

    Matthew Harris - 2015-09-09

    Submitted to SVN

     
  • Matthew Harris

    Matthew Harris - 2015-09-09
    • status: open --> pending
     
  • Matthew Harris

    Matthew Harris - 2015-10-08
    • status: pending --> closed
     
  • Matthew Harris

    Matthew Harris - 2015-10-08

    In 4.1.2