#27 Add a button in 'About Jmol ' pop dialog patch

open
Bob Hanson
5
2012-05-18
2012-05-18
Gong Zhang
No

The patch is about adding a 'Back to About' button at the bottom of pop dialog 'About Jmol'.
After a user clicks one link in the 'About Jmol' pop dialog which includes some web links to
view that link's content, the user can click the 'Back to About' button to return to the origin
dialog which includes several links if that user wants to view the content of another link.

Discussion

  • Bob Hanson
    Bob Hanson
    2012-05-18

    I don't see exactly what the problem is, but Eclipse isn't letting me apply that.

    Are you sure you did that work on the root, Jmol 12.3.16_dev? We don't apply patches to released versions such as 12.2.

     
  • Gong Zhang
    Gong Zhang
    2012-05-19

    I got the source code by SVN command in the sourceforge website.
    This patch is just to add a new button at the bottom of the 'About Jmol' pop
    window to perform a 'back to' function.

     
  • Bob Hanson
    Bob Hanson
    2012-05-19

    Yes, but was it the trunk or the branch? What version of Jmol did you apply it to?

     
  • Gong Zhang
    Gong Zhang
    2012-05-19

     
    Attachments
  • Gong Zhang
    Gong Zhang
    2012-05-19

    Sorry, I work on the Jmol [trunk/Jmol] of the
    'https://jmol.svn.sourceforge.net/svnroot/jmol'. I checked out the source code again today, made sure that the revision is 17159 and version is 12.3.26.
    Then I put the modified code in the
    'Jmol\src\org\openscience\jmol\app\jmolpanel\AboutDialog.java' and created a patch named 'aboutDialog.patch'. It has been patched in this page. I wish it can work.

    Tnanks

     
  • Bob Hanson
    Bob Hanson
    2012-05-19

    That worked this time. Actually, though, I thought of a better idea. It makes little sense to build our own browser for external links. Take a look at what I just checked in.

     
  • Bob Hanson
    Bob Hanson
    2012-05-19

    I decided not to touch About_zh_CN.html because I couldn't be certain my text editor could handle it. -- Could you take care of that?