Previous submission of changes to templates and the java code was included in this description. I am resubmitting it as a file below.
Sorry for any problems this caused. Jonathan
plain text patch generated by Eclipse.
Logged In: YES
A few issues here:
var appletpath = "@APPLETPATH@";
var pathtojmolscripts= appletpath+"/Jmol.js";
Can you tell me what is intended? The variable pathtojmolscripts is not used. Why would one want to know this path? All scripts (spt files) used by the applets must be in the same directory of the data files -- this is because we are using the path to the data files as a variable and defining
set defaultDirectory "."
for the applets. That also sets the default path for the scripts.
I'm also not seeing why you would want to separate the user-definable settings of dataDir and appletpath so far apart.
We seem to also have lost @APPLETDEFS@, which is important in the case of
SET webMakerCreateJS true
s = TextFormat.simpleReplace(s, "@SCRIPT@", name+".spt");
s = TextFormat.simpleReplace(s, "@IMAGE@", instance.pictFile.substring(instance.pictFile.lastIndexOf("/")+1, instance.pictFile.length()));
I can't see the reason for the first. Why not just have ".spt" in the file, and then use only @NAME@?
What is the reason for the @IMAGE@? This is just @NAME@.png, is it not?
Let's discuss it....