From: Robert H. <ha...@st...> - 2010-10-12 13:00:12
|
Jonathan, That was fixed long ago. Are you using http://jmol.svn.sourceforge.net/viewvc/jmol/trunk/Jmol/appletweb/Jmol.js ? * *Bob On Tue, Oct 12, 2010 at 7:53 AM, Jonathan Gutow <gu...@uw...> wrote: > Yes, that would work, but I'm trying to avoid using any of the > internals of Jmol.js in the code for Sage, in case we decide to change > the internals. I think the culprit is the test in _jmolApplet to see > whether a value was passed in the appletID. I believe a value of zero > in appletID returns a false in the if statement, while non-zero #s and > strings work fine. I don't think that behavior matches the documented > behavior of the call. However, I didn't want to check in a fix > without making sure what the behavior is supposed to be and that it > won't mess up some other expected behavior. > > Jonathan > On Oct 11, 2010, at 10:55 PM, Robert Hanson wrote: > > > Jonathan, if it's important to you to have the applets come in as > > applet 0, then what you should do is use > > > > _jmol.appletCount = 0 > > > > and then go from there. > > > > On Mon, Oct 11, 2010 at 8:39 PM, Jonathan Gutow <gu...@uw...> > > wrote: > > I think this is an issue for Angel. > > > > When I make the following call on a page that has other applets on > > it after having destroyed jmolApplet0 to save memory. It creates an > > applet that is not given the name jmolApplet0. I think we are > > running up against a misinterpretation of 0 in the tests near the > > beginning of _jmolApplet. > > > > The call is > > > > jmolApplet([width,height], scriptStr,n); //where n = 0, verified by > > properly setting some other variables. > > > > This is the last of the fixes for the Jmol in Sage interface > > update. A workaround I would like to avoid is to send the zero in > > quotes (ie. "0"). > > > > Things work as expected for n =1 or greater. > > > > Jonathan > > Dr. Jonathan H. Gutow > > Chemistry Department gu...@uw... > > UW-Oshkosh Office: > > 920-424-1326 > > 800 Algoma Boulevard FAX:920-424-2042 > > Oshkosh, WI 54901 > > http://www.uwosh.edu/facstaff/gutow > > > > > > > ------------------------------------------------------------------------------ > > Beautiful is writing same markup. Internet Explorer 9 supports > > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > > Spend less time writing and rewriting code and more time creating > > great > > experiences on the web. Be a part of the beta today. > > http://p.sf.net/sfu/beautyoftheweb > > _______________________________________________ > > Jmol-developers mailing list > > Jmo...@li... > > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > > > > > > > -- > > Robert M. Hanson > > Professor of Chemistry > > St. Olaf College > > 1520 St. Olaf Ave. > > Northfield, MN 55057 > > http://www.stolaf.edu/people/hansonr > > phone: 507-786-3107 > > > > > > If nature does not answer first what we want, > > it is better to take what answer we get. > > > > -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 > > > ------------------------------------------------------------------------------ > > Beautiful is writing same markup. Internet Explorer 9 supports > > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > > Spend less time writing and rewriting code and more time creating > > great > > experiences on the web. Be a part of the beta today. > > http://p.sf.net/sfu/beautyoftheweb > > _______________________________________________ > > Jmol-developers mailing list > > Jmo...@li... > > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > Dr. Jonathan H. Gutow > Chemistry Department gu...@uw... > UW-Oshkosh Office:920-424-1326 > 800 Algoma Boulevard FAX:920-424-2042 > Oshkosh, WI 54901 > http://www.uwosh.edu/facstaff/gutow > > > > > > > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 |