From: A. H. <ang...@ua...> - 2008-12-09 22:38:00
|
While testing the Mediawiki extension, I am having a "too much recursion" error in the Javascript console of Firefox. I haven't yet been able to track it down to a single page or setup. The error points to the "previousOnloadHandler();" line 1096 in Jmol.js: function _jmolOnloadResetForms() { _jmol.previousOnloadHandler = window.onload; window.onload = function() { with (_jmol) { if (buttonCount+checkboxCount+menuCount+radioCount+radioGroupCount > 0) { var forms = document.forms; for (var i = forms.length; --i >= 0; ) forms[i].reset(); } if (previousOnloadHandler) previousOnloadHandler(); } } } I will try to chase it, but if you have any hints they will be appreciated |
From: Robert H. <ha...@st...> - 2008-12-09 23:49:56
|
yeah, that sounds right. _jmol.previousOnloadHandler is being assigned to itself by the execution of that function twice. We set up the initialization business so that it would only run once (I thought). This function is being run multiple times on your page, perhaps because you have multiple applets, and each is calling in Jmol.js. In any case, it should read: function _jmolOnloadResetForms() { if(window.onload && !_jmol.previousOnloadHandler) _jmol.previousOnloadHandler = window.onload; window.onload = function() { with (_jmol) { if (buttonCount+checkboxCount+menuCount+radioCount+radioGroupCount > 0) { var forms = document.forms; for (var i = forms.length; --i >= 0; ) forms[i].reset(); } if (previousOnloadHandler) previousOnloadHandler(); } } } On Tue, Dec 9, 2008 at 2:13 PM, Angel Herráez <ang...@ua...> wrote: > While testing the Mediawiki extension, I am having a > "too much recursion" error in the Javascript console of Firefox. > > I haven't yet been able to track it down to a single page or setup. > > The error points to the "previousOnloadHandler();" line 1096 in Jmol.js: > > function _jmolOnloadResetForms() { > _jmol.previousOnloadHandler = window.onload; > window.onload = > function() { > with (_jmol) { > if (buttonCount+checkboxCount+menuCount+radioCount+radioGroupCount > 0) { > var forms = document.forms; > for (var i = forms.length; --i >= 0; ) > forms[i].reset(); > } > if (previousOnloadHandler) > previousOnloadHandler(); > } > } > } > > > I will try to chase it, but if you have any hints they will be appreciated > > > > ------------------------------------------------------------------------------ > SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. > The future of the web can't happen without you. Join us at MIX09 to help > pave the way to the Next Web now. Learn more and register at > http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 |