From: Nicolas V. <nve...@cl...> - 2006-08-31 16:36:03
|
Should we merge this one ? "reintroduce compiler support for multiple embedded expressions" http://svn.sourceforge.net/viewvc/jmol?view=rev&revision=4838 I don't know why it was done. Nico |
From: Bob H. <ha...@st...> - 2006-08-31 16:47:21
|
Hmm. That's a good question. This was Miguel's rewrite of my compiler change to allow for multiple expressions. It was nice, but the compiler is working fine for multiple expressions; maybe we should leave it out. It would not add anything new, I think, just make the code cleaner. But I have worked on the compiler some since then, so I'm a bit reticent to put it in. You could try it. If load caffeine.xyz;connect 3.5 (oxygen) (hydrogen) hbond create; works, then I guess it's fine. Bob Nicolas Vervelle wrote: >Should we merge this one ? >"reintroduce compiler support for multiple embedded expressions" >http://svn.sourceforge.net/viewvc/jmol?view=rev&revision=4838 > >I don't know why it was done. > >Nico > >------------------------------------------------------------------------- >Using Tomcat but need to do more? Need to support web services, security? >Get stuff done quickly with pre-integrated technology to make your job easier >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >_______________________________________________ >Jmol-developers mailing list >Jmo...@li... >https://lists.sourceforge.net/lists/listinfo/jmol-developers > > |
From: Nicolas V. <nve...@cl...> - 2006-08-31 18:55:53
|
The merge is not easy in fact: some of your changes are in the same area. If it's not useful, I leave it as it is Bob Hanson wrote: > Hmm. That's a good question. This was Miguel's rewrite of my compiler > change to allow for multiple expressions. It was nice, but the compiler > is working fine for multiple expressions; maybe we should leave it out. > It would not add anything new, I think, just make the code cleaner. But > I have worked on the compiler some since then, so I'm a bit reticent to > put it in. You could try it. If > > load caffeine.xyz;connect 3.5 (oxygen) (hydrogen) hbond create; > > works, then I guess it's fine. > > Bob > > > > > Nicolas Vervelle wrote: > > >> Should we merge this one ? >> "reintroduce compiler support for multiple embedded expressions" >> http://svn.sourceforge.net/viewvc/jmol?view=rev&revision=4838 >> >> I don't know why it was done. >> >> Nico >> >> > |
From: Bob H. <ha...@st...> - 2006-08-31 20:59:56
|
OK, leave it. Someday I may look it over and see if there is anything there that would make a difference. Mostly it was just better coding. Bob Nicolas Vervelle wrote: >The merge is not easy in fact: some of your changes are in the same area. >If it's not useful, I leave it as it is > >Bob Hanson wrote: > > >>Hmm. That's a good question. This was Miguel's rewrite of my compiler >>change to allow for multiple expressions. It was nice, but the compiler >>is working fine for multiple expressions; maybe we should leave it out. >>It would not add anything new, I think, just make the code cleaner. But >>I have worked on the compiler some since then, so I'm a bit reticent to >>put it in. You could try it. If >> >>load caffeine.xyz;connect 3.5 (oxygen) (hydrogen) hbond create; >> >>works, then I guess it's fine. >> >>Bob >> >> >> >> >>Nicolas Vervelle wrote: >> >> >> >> >>>Should we merge this one ? >>>"reintroduce compiler support for multiple embedded expressions" >>>http://svn.sourceforge.net/viewvc/jmol?view=rev&revision=4838 >>> >>>I don't know why it was done. >>> >>>Nico >>> >>> >>> >>> > >------------------------------------------------------------------------- >Using Tomcat but need to do more? Need to support web services, security? >Get stuff done quickly with pre-integrated technology to make your job easier >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >_______________________________________________ >Jmol-developers mailing list >Jmo...@li... >https://lists.sourceforge.net/lists/listinfo/jmol-developers > > |