On Mon, Oct 15, 2012 at 2:50 PM, Angel HerrŠez <angel.herraez@uah.es> wrote:
Hi Bob

Having fun evangelizing? ;-)


On 14 Oct 2012 at 22:38, Bob Hanson wrote:
> You must both specify the jar file and whether or not it is signed. JmolJSO doesn't make the call on that.

Yes, I see that's the case. What I'm arguing is that if a user sets isSigned to
true, that should be enough without the need to know or care to specify the
name of the signed applet jarfile.

nope. That's a change. The "isSigned" part must be specified along with the jar file name. No more assumptions about what a jar file name is supposed to be.

That is,

var myInfo = {
† † isSigned: true

should work, by itself.

It will, provided all your versions of "JmolApplet0_xxxx.jar" are signed.

I've made an attempt at editing Core.js that seems to work. I am attaching it
here in patch format, for you consideration.

I understand what you are saying, but we need to emphasize that people should specify all values. Perhaps I should remove the default for Info.jarFile, but I'd rather just document the importance of specifying both those values, Info.jarFile and Info.isSigned. Do not change one without also changing the other to match.

Enjoy Washington!

The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any other MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

† †---- File information -----------
† † †File: †JmolCore.js.patch
† † †Date: †15 Oct 2012, 20:44
† † †Size: †443 bytes.
† † †Type: †Unknown

Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
Jmol-developers mailing list

Robert M. Hanson
Larson-Anderson Professor of Chemistry
Chair, Chemistry Department
St. Olaf College
Northfield, MN

If nature does not answer first what we want,
it is better to take what answer we get.

-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900