Re: [jgrapht-developers] RE : Re: RE : Some contributions

[John V. S. <js...@gm...>]

I have checked Guillaume's contributions (biconnectivity/cutpoint 
inspection; k-shortest-paths; masked subgraphs) into Subversion. 
They'll be released when JGraphT 0.7.2 goes out.

Guillaume, a few notes on changes I made as part of commit:

- I genericized some of the classes that needed it.  For future 
contributions, it's mandatory that they compile without warnings (for 
both functional code and unit tests).  I've got the ant compile to pass 
cleanly, but still need to work through Eclipse warnings in the unit 
tests (since I didn't propagate the generics there yet).

- In particular, clone doesn't work well with generics; I replaced that 
with a copy constructor pattern.

- I left out the heap utility code, since it's not used by any of the 
new classes, and we already have an existing heap implementation with 
equivalent functionality.  We can revisit this if there's a good reason 
to maintain multiple or replace.

- I moved ClassBasedVertexFactory to org.jgrapht.graph as a peer to 
ClassBasedEdgeFactory (you had it as unit test infrastructure).

- I renamed IMaskFunction to MaskFunctor to match naming conventions.

- I put the copyright as France Telecom to match what you requested for 
earlier contributions; let me know if that is no longer correct.

- I ran Jalopy to standardize formatting, and made a few other 
standardizations and removed the public modifier from some classes that 
should remain internal until they are ready for formal publication.  For 
future contributions, please add standard JGraphT file and class headers 
for all files.

- I deleted French-language comments (mostly in unit tests), because (a) 
the non-ASCII characters were giving javadoc warnings and (b) the rest 
of the library uses English.  My apologies for the cultural imperialism.

Thanks again for the great contributions; every one strengthens the library!

JVS

gu boulmi wrote:
>   Hi,
> 
>   Since last time, I've migrated to JGraphT v 0.7.
> So you will find enclosed almost the same constributions that I posted 
> few months ago but 0.7-compliant so that it could be added to next 
> release without any problem.
> I've added some JUnit tests and I've specified in the javadoc the 
> running time of the algorithms when possible.
> 
> Zip file includes among other things:
> - Element (vertex/edge) mask to allow to create a subgraph in O(1).
> - BiconnectivityInspector and BlockCutpointGraph
> - Algorithm for the K shortest paths
> 
> Any feedback is welcome.
> 
>   BR,
> 
>   Guillaume
> 
> N.B.: I've renamed the zip file with .zip2 extension so that the file 
> will not be blocked.
> 
> 
> */"John V. Sichi" <js...@gm...>/* a écrit :
> 
>     gu boulmi wrote:
>      > It seems that .zip extension is blocked. That's why I've renamed
>     the zip
>      > file with .zip2 extension and I retry to send my mail above.
> 
>     Thanks, got it. I'll respond as soon as I get some time.
> 
>     I notice that you're still referring to org._3pq.jgrapht; the package
>     got renamed to org.jgrapht as part of the 0.7.0 release. It would help
>     if all files sent were baselined against the subversion head, or at
>     least 0.7.0, since there have been many changes.
> 
>     JVS
> 
> 
> ------------------------------------------------------------------------
> Stockage illimité de vos mails avec Yahoo! Mail. Changez aujourd'hui de 
> mail ! <http://fr.promotions.yahoo.com/mail/nouveau_yahoomail2.html>