Re: [jgrapht-developers] Subgraph issues

[Barak N. <ba...@3p...>]

> 1. Why doesn't Subgraph have a toString method (and why doesn't=20
> AbstractGraph simply have the toString method=20
> AbstractBaseGraph has)?

i am traveling for a few weeks, and wont have convenient access to the so=
urce,
but if that=B4s the situation, its a mistake.  toString should move to pa=
rent.
feel free to fix.

> 2. degreeOf returns the degree of the vertex in the base graph=20
> which is not asked for.

i thought i fixed that bug. if fix not in CVS, you can go ahead and fix i=
t. i
believe there are also a similar bugs in inDegreeOf, outDegreeOf. it=B4s =
a chance
to fix them too while there. there should be bug reports related to them =
--
worth checking.

> 3. Subgraph should be able to be created as an induced subgraph
> and keep track of this property. This can be done either by
> changing the class or subclassing it.

i=B4m not sure i perfectly understand what you mean.
i once thought of using the filter pattern to provide a subgraph that fol=
lows
the base graph. using a filter with methods acceptEdge(e) and acceptVerte=
x(v)
could be a useful generalization on the existing subgraph. if that is wha=
t
you=B4re having in mind, feel free to go ahead and implement. make sure, =
though,
to keep backward competability. adding another constructor to Sugraph wit=
h the
filter might do the trick.=20

> 4. Subgraph should be listenable as well such that one can create=20
> subgraphs of subgraphs.

i cannot check the source now, but i believe there was a reason for Subgr=
aph
not to be listenable. yuo can go ahead and make it listaneable -- we can =
always
roll-back if need be. However, make sure to do it as a separate and last
change, so if roll-back is required, the rest of your changes will not be
affected.

barak.

--
ps: will be back from my travel mid-october.=20