Re: [jgrapht-users] graphbuilder classes?

[John S. <js...@gm...>]

On Tue, Jun 23, 2015 at 8:36 AM, Joris Kinable <de...@gm...> wrote:

> a. Is there a particular reason I cannot find these classes in the javadoc
> linked from jgrapht's website: http://jgrapht.org/javadoc/. Could it be
> that the javadoc hasn't been updated with the latest release of jgrapht?
>

Looks like I must have screwed up the Javadoc refresh when I released
0.9.1, since it still says 0.9.0.  I'll look into that.


> b. Perhaps a bit of a sensitive point: I'm not entirely sure what these
> classes add to jgrapht? The majority of methods in these builder classes
> were already supported by the default graph classes, or through the Graphs
> class. The only new method I can really see is: 'addEdgeChain(V first, V
> second, V ... rest). I would recommend to add this method to the Graphs
> class, and, unless there's a valid use for these builder classes, consider
> to remove them from jgrapht.
>

The rationale was in this pull request:

https://github.com/jgrapht/jgrapht/pull/115

I tend to think that builders are mostly superfluous in general (not just
in this case), but it's a matter of taste.