jgloss-discussion

[JGloss] Bugs found by FindBug

[Mateusz K. <ma...@gm...>]

I used Eclipse plugin FindBugs for jgloss-1.0.10. I found 104 bugs. One of them:
In class JGloss in function displayError in line 448:
Bug: Unconditional wait
Pattern id: UW_UNCOND_WAIT, type: UW, category: MT_CORRECTNESS
This method contains a call to java.lang.Object.wait() which is not guarded by
conditional control flow.  The code should verify that condition it intends to
wait for is not already satisfied before calling wait; any previous
notifications will be ignored. 

Re: [JGloss] Bugs found by FindBug

[Michael K. <ten...@gm...>]

Hi Mateusz!
> I used Eclipse plugin FindBugs for jgloss-1.0.10. I found 104 bugs. One of them:
> In class JGloss in function displayError in line 448
> [snip]
>   
It has been some time since I wrote JGloss. Most of it has been written
with an Emacs/Command line combination. I've leared a lot since then and
now usually use Eclipse for my Java work. I am also a big fan of
FindBugs and use it in my projects at work. I haven't had time to work
on JGloss for a long time, however, and I don't think this will change
soon. Maybe you would be interested in doing something about the
FindBugs warnings. I'd be happy to integrate your patches. You'd better
work on the trunk version of JGloss though.

I am actually surprised that JGloss still works with current Java VMs,
even though I haven't touched it for such a long time. I guess that
means good things about the backwards compatibility of the Java platform.

Cheers
Michael Koch