[Jfs4bsd-devel] Re: [jfs4bsd] cvs commit: j4b/src/sys/gnu/jfs jfs_imap.c,1.12,1.13

[Hiten P. <hit...@ya...>]

--- dr...@so... wrote:
> Log Message:
> it is compiles now

Hi.

Some things I had to point out.  First of all, I am working on chkSuper(),
updateSuper() and readSuper() as well as logMOUNT().  The last three are
done, but the other one is a tough cookie. ;)

Nevertheless, I am planning to put these four routines in a seperate file
called jfs_misc.c because they are used all over the JFS codebase.  Other
thing is, I have got jfs_mountfs(), and jfs_mount() ported.  Once they
compile cleanly, I will add them straight to the jfs_vfsops.c file.

I have a request.  Please dont make any changes to the jfs_nmount.c, and you
can leave the jfs_mount and jfs_mountfs for now, as I will be committing them
soon; which will give you a more better base.

>  	if (S_ISCHR(ip->i_mode) || S_ISBLK(ip->i_mode))
> -		dip->di_rdev = cpu_to_le32(kdev_t_to_nr(ip->i_rdev));
> +		dip->di_rdev = ip->i_rdev;

Hmm. I am a bit concerned about this bit.  This convert would raise a heck
lot of endian issues, and secondly, the kdev_t_to_nr() routine is used to
return the major and minor number of the corresponding device pointed to by
kdev_t in Linux.  Our functionally equivalent would be dev2unit() which is
prototyped in /sys/kern/kern_conf.c.

The correct version should look like:
dip->di_rdev = cpu_to_le32(dev2unit(ip->i_rdev));

One more thing is important.  It is very important to post some patches on
the net for review, which make big changes for the only reason that it can
be reviewed; and we should not just try and get things compiling if they dont
appear right in the first place... it would just provide us with wrong
results, hence sucking all our time in debugging with gdb. :-)

I am sure you understand.  I apologise if I sounded blunt, but I didnt mean
to sound like that. ;)

Hope that helps. :-)
Regards.


 -- Hiten Pandya
 -- <hi...@uk...>

__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com