Re: [Jfs4bsd-devel] Draft version of jfs_mount for review and addition

[Sergey L. <de...@as...>]

On Mon, Jun 24, 2002 at 01:32:44AM -0700, Hiten Pandya wrote:
> --- Sergey Lyubka <de...@as...> wrote:
> > Hi Hiten,
> 
> Hi! :)
> 
> > few comments about the patch.
> > 
> > line 187: you're calling chkSuper,
> > but superblock has not being read into memory yet,
> > and mout structure has not being alloc-ed.
> 
> I apologise, but if you have a look at the code for chkSuper() which is in
> the JFS4BSD repository, (sorry, I didn't include it in the patch because it
> is not ported yet) then you will notice that it is chkSuper() which does
> the reading of the superblock into memory; or am I missing a point?

Auch :-)
yes, it is OK, chkSuper allocates the memory.

but you still need to allocate jfsmount struct.
you're referencing it, and it is not initialized.