#249 findRangeBounds and BarRenderers/ScatterRenderer

closed-accepted
None
5
2009-05-16
2009-05-13
Peter Kolb
No

BarRenderer.findRangeBounds(CategoryDataset dataset) calls DatasetUtilities.findRangeBounds(dataset) and thus ignores the dataBoundsIncludesVisibleSeriesOnly flag.
StatisticalBarRenderer and IntervalBarRenderer inherit this behaviour. Moreover, neither of the latter two renderers overrides the findRangeBounds-method of the BarRenderer though both should use true for the includeInterval flag.
The ScatterRenderer doesn´t override findRangeBounds as well, and a specific treatment of a MultiValueCategoryDataset in the DatasetUtilities.findRangeBounds() was missing.
The patch is adressing these issues.

Discussion

  • David Gilbert

    David Gilbert - 2009-05-16
    • assigned_to: nobody --> mungady
     
  • David Gilbert

    David Gilbert - 2009-05-16

    I think this line in the DatasetUtilities patch:

    Object o = iterator.next();

    should be:

    Object o = valueIterator.next();

    Apart from that, the patch is great - thanks! I'll commit it soon (just adding a few JUnit tests).

     
  • David Gilbert

    David Gilbert - 2009-05-16
    • status: open --> closed-accepted
     
  • David Gilbert

    David Gilbert - 2009-05-16

    Committed for inclusion in the 1.0.14 release.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks