From: Creighton K. <cki...@ho...> - 2002-05-02 12:58:10
|
I have been going through the code of the datasets and I cam across the following code in DefaultPieDataset. It looks like the variable section is not getting incremented which means that all the values are mapped to the string "1". Am I wrong??? Do I have an old version of the code? I have ran some test it does tie all values to 1. //**********************Problem code************************** /** * Constructs a pie dataset, and populates it with the given values. * @param value A collection of values. */ public DefaultPieDataset(Collection values) { data = new TreeMap(); int section = 1; Iterator iterator = values.iterator(); while (iterator.hasNext()) { Number value = (Number)iterator.next(); data.put(String.valueOf(section), value); } } //**********************Problem code************************** //**********************Easy Fix************************** /** * Constructs a pie dataset, and populates it with the given values. * @param value A collection of values. */ public DefaultPieDataset(Collection values) { data = new TreeMap(); int section = 1; Iterator iterator = values.iterator(); while (iterator.hasNext()) { Number value = (Number)iterator.next(); data.put(String.valueOf(section++), value); //section++ } } //**********************Easy Fix************************** Creighton Kirkendall |
From: Sam K. <ol...@ol...> - 2002-05-02 15:27:46
|
Creighton: > //**********************Problem code************************** > > /** > * Constructs a pie dataset, and populates it with the given values. > * @param value A collection of values. > */ > public DefaultPieDataset(Collection values) { > > data = new TreeMap(); > int section = 1; > Iterator iterator = values.iterator(); > while (iterator.hasNext()) { > Number value = (Number)iterator.next(); > data.put(String.valueOf(section), value); > } > > } > //**********************Problem code************************** The version of DefaultPieDataset (v1.1) that contains the bug you have found has been updated a few times and the new version is 1.3. Although I do not beleive this has not been released as part of JCommon 0.6.1, you can still access the most up-to-date version using CVS. Let me know if you have any questions. -- Sam (oldman) |
From: Sam K. <ol...@ol...> - 2002-05-02 16:24:09
|
Creighton: I just realized my reply was quite ambiguous... DefaultPieDataset has been re-implemented to resolve another issue (new version guarantees the data set will maintain the order in which items are added). In the process, the bug you have found has been resolved and commited to the CVS repository (not in the recent release package). -- Sam (oldman) |